fb-contrib-commit

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1560] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseVarArgs.java

[<dbr...@us...>]

Revision: 1560
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1560&view=rev
Author:   dbrosius
Date:     2010-05-19 05:35:24 +0000 (Wed, 19 May 2010)

Log Message:
-----------
don't report multi array parmed methods

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java	2010-05-19 05:31:14 UTC (rev 1559)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java	2010-05-19 05:35:24 UTC (rev 1560)
@@ -65,6 +65,12 @@
 				return;
 			}
 			
+			for (int i = 0; i < types.length - 1; i++) {
+				if (types[i].getSignature().startsWith("[")) {
+					return;
+				}
+			}
+			
 			if (obj.isStatic() && "main".equals(obj.getName()) && "([Ljava/lang/String;)V".equals(obj.getSignature())) {
 				return;
 			}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1561] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseVarArgs.java

[<dbr...@us...>]

Revision: 1561
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1561&view=rev
Author:   dbrosius
Date:     2010-05-19 13:06:39 +0000 (Wed, 19 May 2010)

Log Message:
-----------
if it's already a vararg, don't report duh!

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java	2010-05-19 05:35:24 UTC (rev 1560)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java	2010-05-19 13:06:39 UTC (rev 1561)
@@ -60,6 +60,10 @@
 				return;
 			}
 			
+			if ((obj.getAccessFlags() & Constants.ACC_VARARGS) != 0) {
+				return;
+			}
+			
 			String lastParmSig = types[types.length-1].getSignature();
 			if (!lastParmSig.startsWith("[") || lastParmSig.startsWith("[[")) {
 				return;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1564] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseVarArgs.java

[<dbr...@us...>]

Revision: 1564
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1564&view=rev
Author:   dbrosius
Date:     2010-05-25 03:30:23 +0000 (Tue, 25 May 2010)

Log Message:
-----------
always report UVA as LOW

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java	2010-05-25 03:27:51 UTC (rev 1563)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseVarArgs.java	2010-05-25 03:30:23 UTC (rev 1564)
@@ -82,7 +82,7 @@
 			}
 			
 			super.visitMethod(obj);
-			bugReporter.reportBug(new BugInstance(this, "UVA_USE_VAR_ARGS", (types.length == 1) ? NORMAL_PRIORITY : LOW_PRIORITY)
+			bugReporter.reportBug(new BugInstance(this, "UVA_USE_VAR_ARGS", LOW_PRIORITY)
 						.addClass(this)
 						.addMethod(this));
 			


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.