fb-contrib-commit

[Fb-contrib-commit] SF.net SVN: fb-contrib: [950] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/ConfusingFunctionSemantics.java

[<dbr...@us...>]

Revision: 950
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=950&view=rev
Author:   dbrosius
Date:     2007-11-02 16:16:33 -0700 (Fri, 02 Nov 2007)

Log Message:
-----------
clear possibleParmRegs on method entry

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-02 05:00:22 UTC (rev 949)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-02 23:16:33 UTC (rev 950)
@@ -60,7 +60,7 @@
 		knownImmutables.add("Ljava/lang/Class;");
 	};
 	
-	private BugReporter bugReporter;
+	private final BugReporter bugReporter;
 	private Map<Integer, ParmUsage> possibleParmRegs;
 	private OpcodeStack stack;
 	
@@ -96,6 +96,7 @@
 	@Override
 	public void visitCode(Code obj) {
 		try {
+		    possibleParmRegs.clear();
 			Method m = getMethod();
 			String methodSignature = m.getSignature();
 			String retSignature = Type.getReturnType(methodSignature).getSignature();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [968] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/ConfusingFunctionSemantics.java

[<dbr...@us...>]

Revision: 968
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=968&view=rev
Author:   dbrosius
Date:     2007-11-09 19:31:23 -0800 (Fri, 09 Nov 2007)

Log Message:
-----------
better engrish

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-10 03:30:12 UTC (rev 967)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-10 03:31:23 UTC (rev 968)
@@ -39,7 +39,7 @@
 import edu.umd.cs.findbugs.ba.ClassContext;
 
 /** looks for methods that return a parameter after making what looks like
- * modifications to that parameter. This leads to confusing on the user of this
+ * modifications to that parameter. This leads to confusion for the user of this
  * method as it isn't obvious that the 'original' object is modified. If the
  * point of this method is to modify the parameter, it is probably better just
  * to have the method be a void method, to avoid confusion.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [1008] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/ConfusingFunctionSemantics.java

[<dbr...@us...>]

Revision: 1008
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1008&view=rev
Author:   dbrosius
Date:     2008-03-16 10:35:14 -0700 (Sun, 16 Mar 2008)

Log Message:
-----------
avoid index out of bounds exceptions

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2008-03-16 02:45:28 UTC (rev 1007)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2008-03-16 17:35:14 UTC (rev 1008)
@@ -169,7 +169,7 @@
 				String calledRet = Type.getReturnType(calledSig).getSignature();
 				if ("V".equals(calledRet)) {
 					int calledObjOffset = Type.getArgumentTypes(calledSig).length;
-					if (stack.getStackDepth() >= calledObjOffset) {
+					if (stack.getStackDepth() > calledObjOffset) {
 						OpcodeStack.Item item = stack.getStackItem(calledObjOffset);
 						int reg = item.getRegisterNumber();
 						ParmUsage pu = possibleParmRegs.get(Integer14.valueOf(reg));


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [1014] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/ConfusingFunctionSemantics.java

[<dbr...@us...>]

Revision: 1014
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1014&view=rev
Author:   dbrosius
Date:     2008-03-23 18:44:54 -0700 (Sun, 23 Mar 2008)

Log Message:
-----------
remove xs semi

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2008-03-23 05:10:55 UTC (rev 1013)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2008-03-24 01:44:54 UTC (rev 1014)
@@ -58,7 +58,7 @@
 		knownImmutables.add("Ljava/lang/Double;");
 		knownImmutables.add("Ljava/lang/Boolean;");
 		knownImmutables.add("Ljava/lang/Class;");
-	};
+	}
 	
 	private final BugReporter bugReporter;
 	private Map<Integer, ParmUsage> possibleParmRegs;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.