Revision: 1011
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1011&view=rev
Author: dbrosius
Date: 2008-03-19 14:52:53 -0700 (Wed, 19 Mar 2008)
Log Message:
-----------
fix for [ 1919533 ] WEM: false positive
Modified Paths:
--------------
trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java 2008-03-16 18:36:53 UTC (rev 1010)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java 2008-03-19 21:52:53 UTC (rev 1011)
@@ -133,8 +133,10 @@
if (exCls.instanceOf(exceptionClass)) {
String sig = getSigConstantOperand();
Type[] argTypes = Type.getArgumentTypes(sig);
+ int stringParms = 0;
for (int t = 0; t < argTypes.length; t++) {
if ("Ljava/lang/String;".equals(argTypes[t].getSignature())) {
+ stringParms++;
int stackOffset = argTypes.length - t - 1;
if (stack.getStackDepth() > stackOffset) {
OpcodeStack.Item item = stack.getStackItem(stackOffset);
@@ -143,7 +145,7 @@
}
}
}
- allConstantStrings = true;
+ allConstantStrings = stringParms > 0;
}
}
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
