fb-contrib-commit

[Fb-contrib-commit] SF.net SVN: fb-contrib: [754] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/NeedlessMemberCollectionSynchronization.java

[<dbr...@us...>]

Revision: 754
          http://svn.sourceforge.net/fb-contrib/?rev=754&view=rev
Author:   dbrosius
Date:     2006-12-22 13:33:16 -0800 (Fri, 22 Dec 2006)

Log Message:
-----------
remove unused parm

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2006-12-22 21:32:07 UTC (rev 753)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2006-12-22 21:33:16 UTC (rev 754)
@@ -218,7 +218,7 @@
 			stack.mergeJumps(this);
 			isSyncCollection = isSyncCollectionCreation(seen);
 			if (seen == PUTSTATIC)
-				processCollectionStore(seen);
+				processCollectionStore();
 		} finally {
 			stack.sawOpcode(this, seen);
 			if (isSyncCollection) {
@@ -242,7 +242,7 @@
 			stack.mergeJumps(this);
 			isSyncCollection = isSyncCollectionCreation(seen);
 			if (seen == PUTFIELD)
-				processCollectionStore(seen);
+				processCollectionStore();
 		} finally {
 			stack.sawOpcode(this, seen);
 			if (isSyncCollection) {
@@ -359,10 +359,8 @@
 	/**
 	 * sets the source line annotation of a store to a collection if that collection
 	 * is synchronized.
-	 * 
-	 * @param seen the opcode of the currently parsed instruction
 	 */
-	private void processCollectionStore(int seen) {
+	private void processCollectionStore() {
 		String fieldClassName = getDottedClassConstantOperand();
 		if (fieldClassName.equals(className)) {
 			if (stack.getStackDepth() > 0) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [793] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/NeedlessMemberCollectionSynchronization.java

[<dbr...@us...>]

Revision: 793
          http://svn.sourceforge.net/fb-contrib/?rev=793&view=rev
Author:   dbrosius
Date:     2007-01-28 12:42:31 -0800 (Sun, 28 Jan 2007)

Log Message:
-----------
BAS fixes

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2007-01-28 20:37:48 UTC (rev 792)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2007-01-28 20:42:31 UTC (rev 793)
@@ -349,9 +349,10 @@
 				return (syncCollections.contains(getClassConstantOperand()));
 			}
 		} else if (seen == INVOKESTATIC) {
-			String methodName = getNameConstantOperand();
-			return "java/util/Collections".equals(getClassConstantOperand())
-			    &&  ("synchronizedMap".equals(methodName) || "synchronizedSet".equals(methodName));
+			if ("java/util/Collections".equals(getClassConstantOperand())) {
+				String methodName = getNameConstantOperand();
+				return ("synchronizedMap".equals(methodName) || "synchronizedSet".equals(methodName));
+			}
 		}
 		return false;
 	}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.