fb-contrib-commit

[Fb-contrib-commit] SF.net SVN: fb-contrib: [651] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/RedundantMethodCalls.java

[<dbr...@us...>]

Revision: 651
          http://svn.sourceforge.net/fb-contrib/?rev=651&view=rev
Author:   dbrosius
Date:     2006-09-15 20:39:53 -0700 (Fri, 15 Sep 2006)

Log Message:
-----------
add 'skip' as risky

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java	2006-09-15 22:44:04 UTC (rev 650)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java	2006-09-16 03:39:53 UTC (rev 651)
@@ -60,6 +60,7 @@
 		riskyMethodNameContents.add("write");
 		riskyMethodNameContents.add("push");
 		riskyMethodNameContents.add("pop");
+		riskyMethodNameContents.add("skip");
 		riskyMethodNameContents.add("clone");
 		
 		String userNameProp = System.getProperty(RMC_RISKY_FIELD_USER_KEY);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [653] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/RedundantMethodCalls.java

[<dbr...@us...>]

Revision: 653
          http://svn.sourceforge.net/fb-contrib/?rev=653&view=rev
Author:   dbrosius
Date:     2006-09-16 06:52:22 -0700 (Sat, 16 Sep 2006)

Log Message:
-----------
change simple getter reporting to EXP_PRIORITY

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java	2006-09-16 04:38:48 UTC (rev 652)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/RedundantMethodCalls.java	2006-09-16 13:52:22 UTC (rev 653)
@@ -190,7 +190,7 @@
 							Object[] parms = mc.getParms();
 							if (Arrays.equals(parms, parmConstants)) {
 								Statistics statistics = Statistics.getStatistics();
-								bugReporter.reportBug(new BugInstance(this, "RMC_REDUNDANT_METHOD_CALLS", statistics.isSimpleGetter(getClassConstantOperand(), methodName, signature) ? LOW_PRIORITY : NORMAL_PRIORITY)
+								bugReporter.reportBug(new BugInstance(this, "RMC_REDUNDANT_METHOD_CALLS", statistics.isSimpleGetter(getClassConstantOperand(), methodName, signature) ? EXP_PRIORITY : NORMAL_PRIORITY)
 											.addClass(this)
 											.addMethod(this)
 											.addSourceLine(this)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.