fb-contrib-commit

[Fb-contrib-commit] SF.net SVN: fb-contrib: [539] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java

[<dbr...@us...>]

Revision: 539
Author:   dbrosius
Date:     2006-05-15 21:33:50 -0700 (Mon, 15 May 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=539&view=rev

Log Message:
-----------
make sure the supposed array size is > 0

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2006-05-16 04:17:35 UTC (rev 538)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2006-05-16 04:33:50 UTC (rev 539)
@@ -67,10 +67,12 @@
 			case SEEN_NOTHING:
 				if (seen == BIPUSH) {
 					arraySize = getIntConstant();
-					state = SEEN_ARRAY_SIZE;
+					if (arraySize > 0)
+						state = SEEN_ARRAY_SIZE;
 				}else if ((seen >= ICONST_M1) && (seen <= ICONST_5)) {
 					arraySize = seen - ICONST_M1 - 1;
-					state = SEEN_ARRAY_SIZE;
+					if (arraySize > 0)
+						state = SEEN_ARRAY_SIZE;
 				}
 			break;
 			


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [540] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java

[<dbr...@us...>]

Revision: 540
Author:   dbrosius
Date:     2006-05-16 21:03:41 -0700 (Tue, 16 May 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=540&view=rev

Log Message:
-----------
prioritize based on array size

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2006-05-16 04:33:50 UTC (rev 539)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2006-05-17 04:03:41 UTC (rev 540)
@@ -126,7 +126,7 @@
 			case SEEN_INDEX_STORE:
 				if ((seen == ASTORE)
 				||  ((seen >= ASTORE_0) && (seen <= ASTORE_3))) {
-					bugReporter.reportBug(new BugInstance(this, "SACM_STATIC_ARRAY_CREATED_IN_METHOD", NORMAL_PRIORITY)
+					bugReporter.reportBug(new BugInstance(this, "SACM_STATIC_ARRAY_CREATED_IN_METHOD", (arraySize < 3) ? LOW_PRIORITY : ((arraySize < 10) ? NORMAL_PRIORITY : HIGH_PRIORITY))
 							   .addClass(this)
 							   .addMethod(this)
 							   .addSourceLine(this, getPC()));


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [557] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java

[<dbr...@us...>]

Revision: 557
Author:   dbrosius
Date:     2006-06-06 09:08:04 -0700 (Tue, 06 Jun 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=557&view=rev

Log Message:
-----------
fix javadoc

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2006-06-06 16:04:36 UTC (rev 556)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2006-06-06 16:08:04 UTC (rev 557)
@@ -44,7 +44,7 @@
 	/**
 	 * implements the visitor by forwarding calls for methods that are the static initializer
 	 * 
-	 * @obj the context object of the currently parsed code block
+	 * @param obj the context object of the currently parsed code block
 	 */
 	@Override
 	public void visitCode(Code obj) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.