fb-contrib-commit

[Fb-contrib-commit] SF.net SVN: fb-contrib: [410] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java

[<dbr...@us...>]

Revision: 410
Author:   dbrosius
Date:     2006-04-07 07:27:43 -0700 (Fri, 07 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=410&view=rev

Log Message:
-----------
prescreen for NEWARRAY or ANEWARRAY

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2006-04-07 13:58:31 UTC (rev 409)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2006-04-07 14:27:43 UTC (rev 410)
@@ -18,13 +18,17 @@
  */
 package com.mebigfatguy.fbcontrib.detect;
 
+import java.util.BitSet;
 import java.util.HashMap;
 import java.util.Map;
 
+import org.apache.bcel.Constants;
 import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.Method;
 import org.apache.bcel.generic.Type;
 
 import com.mebigfatguy.fbcontrib.utils.RegisterUtils;
+import com.mebigfatguy.fbcontrib.utils.VersionTransition;
 
 import edu.umd.cs.findbugs.BugInstance;
 import edu.umd.cs.findbugs.BugReporter;
@@ -73,15 +77,28 @@
 	}
 	
 	/**
+	 * looks for methods that contain a NEWARRAY or ANEWARRAY opcodes
+	 * 
+	 * @param method the context object of the current method
+	 * @return if the class uses synchronization
+	 */
+	public boolean prescreen(Method method) {
+		BitSet bytecodeSet = VersionTransition.getBytecodeSet(getClassContext(), method);
+		return (bytecodeSet != null) && (bytecodeSet.get(Constants.NEWARRAY) || bytecodeSet.get(Constants.ANEWARRAY));
+	}
+	
+	/**
 	 * implements the visitor to reset the stack of opcodes
 	 * 
 	 * @param obj the context object for the currently parsed code block
 	 */
 	@Override
 	public void visitCode(Code obj) {
-		stack.resetForMethodEntry(this);
-		wrappers.clear();
-		super.visitCode(obj);
+		if (prescreen(getMethod())) {
+			stack.resetForMethodEntry(this);
+			wrappers.clear();
+			super.visitCode(obj);
+		}
 	}
 	
 	/**


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [453] trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java

[<dbr...@us...>]

Revision: 453
Author:   dbrosius
Date:     2006-04-16 20:36:08 -0700 (Sun, 16 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/fb-contrib/?rev=453&view=rev

Log Message:
-----------
Manually cleanup memory now that StatelessDetector is removed.

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2006-04-17 03:33:31 UTC (rev 452)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2006-04-17 03:36:08 UTC (rev 453)
@@ -33,14 +33,14 @@
 import edu.umd.cs.findbugs.BugReporter;
 import edu.umd.cs.findbugs.BytecodeScanningDetector;
 import edu.umd.cs.findbugs.OpcodeStack;
-import edu.umd.cs.findbugs.StatelessDetector;
+import edu.umd.cs.findbugs.ba.ClassContext;
 
 /**
  * looks for methods that use an array of length one to pass a variable to achieve call
  * by pointer ala C++. It is better to define a proper return class type that holds all
  * the relevant information retrieved from the called method.
  */
-public class ArrayWrappedCallByReference extends BytecodeScanningDetector implements StatelessDetector {
+public class ArrayWrappedCallByReference extends BytecodeScanningDetector {
 	
 	static class WrapperInfo {
 		public int wrappedReg;
@@ -53,8 +53,8 @@
 	}
 	
 	private BugReporter bugReporter;
-	private OpcodeStack stack = new OpcodeStack();
-	private Map<Integer, WrapperInfo> wrappers = new HashMap<Integer, WrapperInfo>();
+	private OpcodeStack stack;
+	private Map<Integer, WrapperInfo> wrappers;
 	
     /**
      * constructs a AWCBR detector given the reporter to report bugs on
@@ -65,17 +65,21 @@
 		this.bugReporter = bugReporter;
 	}
 	
- 	/**
- 	 * clone this detector so that it can be a StatelessDetector
- 	 * 
- 	 * @return a clone of this object
- 	 */    
+	/**
+	 * implement the visitor to create and clear the stack and wrappers
+	 *
+	 * @param classContext the context object of the currently parsed class
+	 */
 	@Override
-	public Object clone() throws CloneNotSupportedException {
-		return super.clone();
+	public void visitClassContext(ClassContext classContext) {
+		stack = new OpcodeStack();
+		wrappers = new HashMap<Integer, WrapperInfo>();
+		super.visitClassContext(classContext);
+		stack = null;
+		wrappers = null;
 	}
 	
-	/**
+    /**
 	 * looks for methods that contain a NEWARRAY or ANEWARRAY opcodes
 	 * 
 	 * @param method the context object of the current method


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.