Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27576/src/com/mebigfatguy/fbcontrib/detect
Modified Files:
SuspiciousWaitOnConcurrentObject.java
Log Message:
guard against npe's
Index: SuspiciousWaitOnConcurrentObject.java
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- SuspiciousWaitOnConcurrentObject.java 5 Mar 2006 04:37:15 -0000 1.1
+++ SuspiciousWaitOnConcurrentObject.java 12 Mar 2006 02:48:00 -0000 1.2
@@ -88,12 +88,14 @@
if (stack.getStackDepth() > 0) {
OpcodeStack.Item itm = stack.getStackItem(0);
JavaClass cls = itm.getJavaClass();
- String clsName = cls.getClassName();
- if (concurrentAwaitClasses.contains(clsName)) {
- bugReporter.reportBug(new BugInstance(this, "SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT", NORMAL_PRIORITY)
- .addClass(this)
- .addMethod(this)
- .addSourceLine(this));
+ if (cls != null) {
+ String clsName = cls.getClassName();
+ if (concurrentAwaitClasses.contains(clsName)) {
+ bugReporter.reportBug(new BugInstance(this, "SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT", NORMAL_PRIORITY)
+ .addClass(this)
+ .addMethod(this)
+ .addSourceLine(this));
+ }
}
}
}
|
