Update of /cvsroot/fb-contrib/fb-contrib/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9538/etc
Modified Files:
findbugs.xml messages.xml
Log Message:
intial checkin - new LSYC detector
Index: messages.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/messages.xml,v
retrieving revision 1.61
retrieving revision 1.62
diff -u -d -r1.61 -r1.62
--- messages.xml 8 Mar 2006 04:45:16 -0000 1.61
+++ messages.xml 11 Mar 2006 05:01:35 -0000 1.62
@@ -481,6 +481,18 @@
</Details>
</Detector>
+ <Detector class="com.mebigfatguy.fbcontrib.detect.LocalSynchronizedCollection">
+ <Details>
+ <![CDATA[
+ <p>looks for allocations of synchronized collections that are stored in local
+ variables, and never stored in fields or returned from methods. As local variables
+ are by definition thread safe, using synchronized collections in this context
+ makes no sense.</p>
+ <p>It is a fast detector</p>
+ ]]>
+ </Details>
+ </Detector>
+
<!-- BugPattern -->
<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -980,6 +992,18 @@
</Details>
</BugPattern>
+ <BugPattern type="LSYC_LOCAL_SYNCHRONIZED_COLLECTION">
+ <ShortDescription>method creates local variable-based synchronized collection</ShortDescription>
+ <LongDescription>method {1} creates local variable-based synchronized collection</LongDescription>
+ <Details>
+ <![CDATA[
+ <p>This method creates a synchronized collection and store the reference to it
+ in a local variable. As local variables are by definition threadsafe, it seems
+ questionable that this collection needs to be synchronized.</p>
+ ]]>
+ </Details>
+ </BugPattern>
+
<!-- BugCode -->
<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -1020,4 +1044,5 @@
<BugCode abbrev="SWCO">Suspicious Wait on Concurrent Object</BugCode>
<BugCode abbrev="JVR">JDBC Vendor Reliance</BugCode>
<BugCode abbrev="PMB">Possible Memory Bloat</BugCode>
+ <BugCode abbrev="LSYC">Local Synchronized Collection</BugCode>
</MessageCollection>
\ No newline at end of file
Index: findbugs.xml
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/etc/findbugs.xml,v
retrieving revision 1.68
retrieving revision 1.69
diff -u -d -r1.68 -r1.69
--- findbugs.xml 7 Mar 2006 06:17:24 -0000 1.68
+++ findbugs.xml 11 Mar 2006 05:01:35 -0000 1.69
@@ -129,7 +129,7 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedSynchronizedBlock"
speed="fast"
reports="BSB_BLOATED_SYNCHRONIZED_BLOCK"
- disabled="true" />
+ hidden="true" />
<Detector class="com.mebigfatguy.fbcontrib.detect.ConstantListIndex"
speed="fast"
@@ -167,7 +167,10 @@
speed="fast"
reports="PMB_POSSIBLE_MEMORY_BLOAT" />
-
+ <Detector class="com.mebigfatguy.fbcontrib.detect.LocalSynchronizedCollection"
+ speed="fast"
+ reports="LSYC_LOCAL_SYNCHRONIZED_COLLECTION" />
+
<!-- BugPattern -->
<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -208,4 +211,5 @@
<BugPattern abbrev="SWCO" type="SWCO_SUSPICIOUS_WAIT_ON_CONCURRENT_OBJECT" category="CORRECTNESS" experimental="true" />
<BugPattern abbrev="JVR" type="JVR_JDBC_VENDOR_RELIANCE" category="CORRECTNESS" experimental="true" />
<BugPattern abbrev="PMB" type="PMB_POSSIBLE_MEMORY_BLOAT" category="CORRECTNESS" experimental="true" />
+ <BugPattern abbrev="LSYC" type="LSYC_LOCAL_SYNCHRONIZED_COLLECTION" category="CORRECTNESS" experimental="true" />
</FindbugsPlugin>
\ No newline at end of file
|
