Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6893/src/com/mebigfatguy/fbcontrib/detect
Modified Files:
ConfusingAutoboxedOverloading.java
Log Message:
if a method signature is only different in return type, don't report it for CAO
Index: ConfusingAutoboxedOverloading.java
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- ConfusingAutoboxedOverloading.java 2 Nov 2005 06:07:01 -0000 1.1
+++ ConfusingAutoboxedOverloading.java 3 Nov 2005 05:19:08 -0000 1.2
@@ -45,7 +45,7 @@
primitiveSigs.add("I");
primitiveSigs.add("J");
primitiveSigs.add("D");
- primitiveSigs.add("F");
+ primitiveSigs.add("F");
}
private BugReporter bugReporter;
@@ -95,6 +95,7 @@
if (type1.length != type2.length)
return false;
+ boolean foundParmDiff = false;
for (int i = 0; i < type1.length; i++) {
Type t1 = type1[i];
Type t2 = type2[i];
@@ -108,10 +109,11 @@
return false;
} else
return false;
+ foundParmDiff = true;
}
}
- return true;
+ return foundParmDiff;
}
private void populateMethodInfo(JavaClass cls, Map<String, Set<String>> methodInfo) {
|
