Update of /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19825/src/com/mebigfatguy/fbcontrib/detect
Modified Files:
InefficientStringBuffering.java
Log Message:
report ISB at LOW for toString methods
Index: InefficientStringBuffering.java
===================================================================
RCS file: /cvsroot/fb-contrib/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- InefficientStringBuffering.java 1 Oct 2005 07:38:02 -0000 1.3
+++ InefficientStringBuffering.java 18 Oct 2005 03:56:57 -0000 1.4
@@ -65,7 +65,7 @@
if ("Ljava/lang/StringBuffer;".equals(signature)
|| "Ljava/lang/StringBuilder;".equals(signature)) {
bugReporter.reportBug(
- new BugInstance(this, "ISB_INEFFICIENT_STRING_BUFFERING", NORMAL_PRIORITY)
+ new BugInstance(this, "ISB_INEFFICIENT_STRING_BUFFERING", "toString".equals(this.getMethodName()) ? LOW_PRIORITY : NORMAL_PRIORITY)
.addClass(this)
.addMethod(this)
.addSourceLine(this));
|
