fb-contrib-commit Mailing List for fb-contrib (Page 9)
Brought to you by:
dbrosius
Menu
▾
▴
fb-contrib-commit — Log for cvs commits of fb-contrib code
You can subscribe to this list here.
| 2005 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(56) |
Oct
(60) |
Nov
(58) |
Dec
(89) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2006 |
Jan
(66) |
Feb
(55) |
Mar
(85) |
Apr
(115) |
May
(35) |
Jun
(28) |
Jul
(3) |
Aug
(48) |
Sep
(37) |
Oct
(22) |
Nov
(14) |
Dec
(66) |
| 2007 |
Jan
(45) |
Feb
(63) |
Mar
(10) |
Apr
(1) |
May
(1) |
Jun
(12) |
Jul
|
Aug
|
Sep
(25) |
Oct
(21) |
Nov
(39) |
Dec
|
| 2008 |
Jan
(7) |
Feb
|
Mar
(26) |
Apr
(5) |
May
(2) |
Jun
(32) |
Jul
(9) |
Aug
(10) |
Sep
|
Oct
(3) |
Nov
(1) |
Dec
|
| 2009 |
Jan
(10) |
Feb
(31) |
Mar
(32) |
Apr
(35) |
May
(25) |
Jun
|
Jul
(31) |
Aug
(10) |
Sep
(95) |
Oct
(35) |
Nov
(10) |
Dec
(34) |
| 2010 |
Jan
(90) |
Feb
(4) |
Mar
(7) |
Apr
(20) |
May
(20) |
Jun
(13) |
Jul
(7) |
Aug
(18) |
Sep
(25) |
Oct
(4) |
Nov
(16) |
Dec
(2) |
| 2011 |
Jan
(1) |
Feb
|
Mar
(11) |
Apr
(3) |
May
(2) |
Jun
(26) |
Jul
(10) |
Aug
(2) |
Sep
|
Oct
(1) |
Nov
(1) |
Dec
(1) |
| 2012 |
Jan
(3) |
Feb
(4) |
Mar
|
Apr
|
May
|
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
(14) |
Nov
(3) |
Dec
(4) |
| 2013 |
Jan
(3) |
Feb
(2) |
Mar
(1) |
Apr
(4) |
May
|
Jun
(1) |
Jul
(3) |
Aug
|
Sep
|
Oct
(4) |
Nov
(3) |
Dec
(3) |
| 2014 |
Jan
(4) |
Feb
(2) |
Mar
(4) |
Apr
(1) |
May
(2) |
Jun
|
Jul
(2) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2015 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(4) |
Jun
|
Jul
|
Aug
(3) |
Sep
|
Oct
|
Nov
(3) |
Dec
(3) |
| 2016 |
Jan
(2) |
Feb
|
Mar
|
Apr
(2) |
May
|
Jun
|
Jul
(1) |
Aug
(2) |
Sep
(4) |
Oct
(2) |
Nov
(7) |
Dec
|
| 2017 |
Jan
(1) |
Feb
|
Mar
(4) |
Apr
(5) |
May
(2) |
Jun
|
Jul
(2) |
Aug
|
Sep
(4) |
Oct
|
Nov
|
Dec
(3) |
| 2018 |
Jan
|
Feb
|
Mar
(2) |
Apr
|
May
(5) |
Jun
(2) |
Jul
(2) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <dbr...@us...> - 2010-11-24 05:30:53
|
Revision: 1640
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1640&view=rev
Author: dbrosius
Date: 2010-11-24 05:30:46 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
[maven-release-plugin] copy for tag fb-contrib-4.6.0
Added Paths:
-----------
tags/fb-contrib-4.6.0/
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 05:30:39
|
Revision: 1639
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1639&view=rev
Author: dbrosius
Date: 2010-11-24 05:30:31 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
[maven-release-plugin] prepare release fb-contrib-4.6.0
Modified Paths:
--------------
tags/v4_6_0/pom.xml
Modified: tags/v4_6_0/pom.xml
===================================================================
--- tags/v4_6_0/pom.xml 2010-11-24 05:29:05 UTC (rev 1638)
+++ tags/v4_6_0/pom.xml 2010-11-24 05:30:31 UTC (rev 1639)
@@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>4.6.0-SNAPSHOT</version>
+ <version>4.6.0</version>
<parent>
<groupId>org.sonatype.oss</groupId>
@@ -51,9 +51,9 @@
</licenses>
<scm>
- <connection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/trunk/</connection>
- <developerConnection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/trunk/</developerConnection>
- <url>http://fb-contrib.svn.sourceforge.net/viewvc/fb-contrib/trunk/</url>
+ <connection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/tags/fb-contrib-4.6.0</connection>
+ <developerConnection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/tags/fb-contrib-4.6.0</developerConnection>
+ <url>http://fb-contrib.svn.sourceforge.net/viewvc/fb-contrib/tags/fb-contrib-4.6.0</url>
</scm>
<mailingLists>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 05:29:12
|
Revision: 1638
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1638&view=rev
Author: dbrosius
Date: 2010-11-24 05:29:05 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
v4.6.0
Modified Paths:
--------------
tags/v4_6_0/pom.xml
Modified: tags/v4_6_0/pom.xml
===================================================================
--- tags/v4_6_0/pom.xml 2010-11-24 05:25:35 UTC (rev 1637)
+++ tags/v4_6_0/pom.xml 2010-11-24 05:29:05 UTC (rev 1638)
@@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>4.6.0</version>
+ <version>4.6.0-SNAPSHOT</version>
<parent>
<groupId>org.sonatype.oss</groupId>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 05:25:41
|
Revision: 1637
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1637&view=rev
Author: dbrosius
Date: 2010-11-24 05:25:35 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
v4.6.0
Modified Paths:
--------------
tags/v4_6_0/pom.xml
Modified: tags/v4_6_0/pom.xml
===================================================================
--- tags/v4_6_0/pom.xml 2010-11-24 05:11:48 UTC (rev 1636)
+++ tags/v4_6_0/pom.xml 2010-11-24 05:25:35 UTC (rev 1637)
@@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>4.7.0</version>
+ <version>4.6.0</version>
<parent>
<groupId>org.sonatype.oss</groupId>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 05:11:54
|
Revision: 1636
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1636&view=rev
Author: dbrosius
Date: 2010-11-24 05:11:48 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
[maven-release-plugin] prepare for next development iteration
Modified Paths:
--------------
tags/v4_6_0/pom.xml
Modified: tags/v4_6_0/pom.xml
===================================================================
--- tags/v4_6_0/pom.xml 2010-11-24 05:11:42 UTC (rev 1635)
+++ tags/v4_6_0/pom.xml 2010-11-24 05:11:48 UTC (rev 1636)
@@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>4.6.0</version>
+ <version>4.7.0</version>
<parent>
<groupId>org.sonatype.oss</groupId>
@@ -51,9 +51,9 @@
</licenses>
<scm>
- <connection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/tags/v4_6_0</connection>
- <developerConnection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/tags/v4_6_0</developerConnection>
- <url>http://fb-contrib.svn.sourceforge.net/viewvc/fb-contrib/tags/v4_6_0</url>
+ <connection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/trunk/</connection>
+ <developerConnection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/trunk/</developerConnection>
+ <url>http://fb-contrib.svn.sourceforge.net/viewvc/fb-contrib/trunk/</url>
</scm>
<mailingLists>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 05:11:48
|
Revision: 1635
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1635&view=rev
Author: dbrosius
Date: 2010-11-24 05:11:42 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
[maven-release-plugin] copy for tag v4_6_0
Added Paths:
-----------
tags/v4_6_0/trunk/
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 05:11:22
|
Revision: 1634
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1634&view=rev
Author: dbrosius
Date: 2010-11-24 05:11:16 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
[maven-release-plugin] prepare release v4_6_0
Modified Paths:
--------------
tags/v4_6_0/pom.xml
Modified: tags/v4_6_0/pom.xml
===================================================================
--- tags/v4_6_0/pom.xml 2010-11-24 05:08:59 UTC (rev 1633)
+++ tags/v4_6_0/pom.xml 2010-11-24 05:11:16 UTC (rev 1634)
@@ -1,14 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- pom.xml developed by Grzegorz Slowikowski -->
-<project
- xmlns="http://maven.apache.org/POM/4.0.0"
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>4.6.0-SNAPSHOT</version>
+ <version>4.6.0</version>
<parent>
<groupId>org.sonatype.oss</groupId>
@@ -54,9 +51,9 @@
</licenses>
<scm>
- <connection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/trunk/</connection>
- <developerConnection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/trunk/</developerConnection>
- <url>http://fb-contrib.svn.sourceforge.net/viewvc/fb-contrib/trunk/</url>
+ <connection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/tags/v4_6_0</connection>
+ <developerConnection>scm:svn:https://fb-contrib.svn.sourceforge.net/svnroot/fb-contrib/tags/v4_6_0</developerConnection>
+ <url>http://fb-contrib.svn.sourceforge.net/viewvc/fb-contrib/tags/v4_6_0</url>
</scm>
<mailingLists>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 05:09:06
|
Revision: 1633
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1633&view=rev
Author: dbrosius
Date: 2010-11-24 05:08:59 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
Version 4.6.0
Modified Paths:
--------------
tags/v4_6_0/pom.xml
Modified: tags/v4_6_0/pom.xml
===================================================================
--- tags/v4_6_0/pom.xml 2010-11-24 04:55:18 UTC (rev 1632)
+++ tags/v4_6_0/pom.xml 2010-11-24 05:08:59 UTC (rev 1633)
@@ -9,6 +9,12 @@
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
<version>4.6.0-SNAPSHOT</version>
+
+ <parent>
+ <groupId>org.sonatype.oss</groupId>
+ <artifactId>oss-parent</artifactId>
+ <version>5</version>
+ </parent>
<name>FindBugs Contrib plugin library</name>
<description>An auxiliary findbugs.sourceforge.net plugin for java bug detectors that fall outside the narrow scope of detectors to be packaged with the product itself.</description>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-11-24 04:55:24
|
Revision: 1632
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1632&view=rev
Author: dbrosius
Date: 2010-11-24 04:55:18 +0000 (Wed, 24 Nov 2010)
Log Message:
-----------
change to 4.6.0
Modified Paths:
--------------
tags/v4_6_0/pom.xml
Modified: tags/v4_6_0/pom.xml
===================================================================
--- tags/v4_6_0/pom.xml 2010-10-19 01:55:32 UTC (rev 1631)
+++ tags/v4_6_0/pom.xml 2010-11-24 04:55:18 UTC (rev 1632)
@@ -8,7 +8,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>4.4.0-SNAPSHOT</version>
+ <version>4.6.0-SNAPSHOT</version>
<name>FindBugs Contrib plugin library</name>
<description>An auxiliary findbugs.sourceforge.net plugin for java bug detectors that fall outside the narrow scope of detectors to be packaged with the product itself.</description>
@@ -183,4 +183,4 @@
</plugin>
</plugins>
</build>
-</project>
\ No newline at end of file
+</project>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-10-19 01:55:39
|
Revision: 1631
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1631&view=rev
Author: dbrosius
Date: 2010-10-19 01:55:32 +0000 (Tue, 19 Oct 2010)
Log Message:
-----------
comment out CVAA for now
Modified Paths:
--------------
trunk/fb-contrib/etc/findbugs.xml
Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml 2010-10-16 05:07:52 UTC (rev 1630)
+++ trunk/fb-contrib/etc/findbugs.xml 2010-10-19 01:55:32 UTC (rev 1631)
@@ -193,9 +193,9 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.PoorlyDefinedParameter" speed="fast" reports="PDP_POORLY_DEFINED_PARAMETER" />
<Detector class="com.mebigfatguy.fbcontrib.detect.NonSymmetricEquals" speed="fast" reports="NSE_NON_SYMMETRIC_EQUALS" />
-<!-- -->
+<!--
<Detector class="com.mebigfatguy.fbcontrib.detect.ContraVariantArrayAssignment" speed="fast" hidden="true" reports="CVAA_CONTRAVARIANT_ARRAY_ASSIGNMENT,CVAA_CONTRAVARIANT_ELEMENT_ASSIGNMENT" />
-<!-- -->
+-->
<Detector class="com.mebigfatguy.fbcontrib.detect.NonFunctionalField" speed="fast" reports="NFF_NON_FUNCTIONAL_FIELD" />
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-10-16 05:07:59
|
Revision: 1630
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1630&view=rev
Author: dbrosius
Date: 2010-10-16 05:07:52 +0000 (Sat, 16 Oct 2010)
Log Message:
-----------
update version in pom
Modified Paths:
--------------
trunk/fb-contrib/pom.xml
Modified: trunk/fb-contrib/pom.xml
===================================================================
--- trunk/fb-contrib/pom.xml 2010-10-14 04:46:30 UTC (rev 1629)
+++ trunk/fb-contrib/pom.xml 2010-10-16 05:07:52 UTC (rev 1630)
@@ -8,7 +8,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
- <version>4.4.0-SNAPSHOT</version>
+ <version>4.6.0-SNAPSHOT</version>
<name>FindBugs Contrib plugin library</name>
<description>An auxiliary findbugs.sourceforge.net plugin for java bug detectors that fall outside the narrow scope of detectors to be packaged with the product itself.</description>
@@ -183,4 +183,4 @@
</plugin>
</plugins>
</build>
-</project>
\ No newline at end of file
+</project>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-10-14 04:46:37
|
Revision: 1629
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1629&view=rev
Author: dbrosius
Date: 2010-10-14 04:46:30 +0000 (Thu, 14 Oct 2010)
Log Message:
-----------
add test for transient trims in SPP
Modified Paths:
--------------
trunk/fb-contrib/etc/findbugs.xml
trunk/fb-contrib/etc/messages.xml
trunk/fb-contrib/samples/SPP_Sample.java
trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml 2010-10-14 04:45:37 UTC (rev 1628)
+++ trunk/fb-contrib/etc/findbugs.xml 2010-10-14 04:46:30 UTC (rev 1629)
@@ -132,7 +132,7 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousComparatorReturnValues" speed="fast" reports="SC_SUSPICIOUS_COMPARATOR_RETURN_VALUES" />
<Detector class="com.mebigfatguy.fbcontrib.detect.SillynessPotPourri" speed="fast"
- reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY,SPP_USE_ISEMPTY,SPP_USE_GETPROPERTY,SPP_USELESS_CASING,SPP_NON_ARRAY_PARM,SPP_EMPTY_CASING" />
+ reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY,SPP_USE_ISEMPTY,SPP_USE_GETPROPERTY,SPP_USELESS_CASING,SPP_NON_ARRAY_PARM,SPP_EMPTY_CASING,SPP_TEMPORARY_TRIM" />
<!--
<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope" speed="fast" reports="BAS_BLOATED_ASSIGNMENT_SCOPE" hidden="true" />
-->
@@ -193,9 +193,9 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.PoorlyDefinedParameter" speed="fast" reports="PDP_POORLY_DEFINED_PARAMETER" />
<Detector class="com.mebigfatguy.fbcontrib.detect.NonSymmetricEquals" speed="fast" reports="NSE_NON_SYMMETRIC_EQUALS" />
-<!--
+<!-- -->
<Detector class="com.mebigfatguy.fbcontrib.detect.ContraVariantArrayAssignment" speed="fast" hidden="true" reports="CVAA_CONTRAVARIANT_ARRAY_ASSIGNMENT,CVAA_CONTRAVARIANT_ELEMENT_ASSIGNMENT" />
- -->
+<!-- -->
<Detector class="com.mebigfatguy.fbcontrib.detect.NonFunctionalField" speed="fast" reports="NFF_NON_FUNCTIONAL_FIELD" />
@@ -315,6 +315,7 @@
<BugPattern abbrev="SPP" type="SPP_SERIALVER_SHOULD_BE_PRIVATE" category="STYLE" />
<BugPattern abbrev="SPP" type="SPP_NON_ARRAY_PARM" category="CORRECTNESS" />
<BugPattern abbrev="SPP" type="SPP_EMPTY_CASING" category="STYLE" />
+ <BugPattern abbrev="SPP" type="SPP_TEMPORARY_TRIM" category="STYLE" />
<BugPattern abbrev="BAS" type="BAS_BLOATED_ASSIGNMENT_SCOPE" category="PERFORMANCE" />
<BugPattern abbrev="SCII" type="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTATOR" category="STYLE" />
<BugPattern abbrev="DWI" type="DWI_DELETING_WHILE_ITERATING" category="CORRECTNESS" />
Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml 2010-10-14 04:45:37 UTC (rev 1628)
+++ trunk/fb-contrib/etc/messages.xml 2010-10-14 04:46:30 UTC (rev 1629)
@@ -2413,7 +2413,21 @@
]]>
</Details>
</BugPattern>
-
+
+ <BugPattern type="SPP_TEMPORARY_TRIM">
+ <ShortDescription>Method trims a String temporarily</ShortDescription>
+ <LongDescription>Method {1} trims a String temporarily</LongDescription>
+ <Details>
+ <![CDATA[
+ This method calls trim() on a String without assigning the new string to another variable.
+ It then calls length() or equals on this trimmed string. If trimming the string was important
+ for determining it's length of it's equality, it should be trimmed when you actually go to use it.
+ It would make more sense to first trim the String, store the trimmed value in a variable, and then
+ continue to test and use that trimmed string.
+ ]]>
+ </Details>
+ </BugPattern>
+
<BugPattern type="BAS_BLOATED_ASSIGNMENT_SCOPE">
<ShortDescription>Method assigns a variable in a larger scope then is needed</ShortDescription>
<LongDescription>Method {1} assigns a variable in a larger scope then is needed</LongDescription>
Modified: trunk/fb-contrib/samples/SPP_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SPP_Sample.java 2010-10-14 04:45:37 UTC (rev 1628)
+++ trunk/fb-contrib/samples/SPP_Sample.java 2010-10-14 04:46:30 UTC (rev 1629)
@@ -321,4 +321,15 @@
{
return (s.equalsIgnoreCase(""));
}
+
+ public void testTrim(String s)
+ {
+ if (s.trim().length() > 0)
+ System.out.println(s);
+
+ if (s.trim().equals("Booyah"))
+ {
+ System.out.println("Booyah->" + s);
+ }
+ }
}
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java 2010-10-14 04:45:37 UTC (rev 1628)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java 2010-10-14 04:46:30 UTC (rev 1629)
@@ -482,6 +482,28 @@
.addSourceLine(this));
}
}
+ } else if ("trim".equals(methodName)) {
+ userValue = "trim";
+ } else if ("length".equals(methodName)) {
+ if (stack.getStackDepth() > 0) {
+ OpcodeStack.Item item = stack.getStackItem(0);
+ if ("trim".equals(item.getUserValue())) {
+ bugReporter.reportBug(new BugInstance(this, "SPP_TEMPORARY_TRIM", NORMAL_PRIORITY)
+ .addClass(this)
+ .addMethod(this)
+ .addSourceLine(this));
+ }
+ }
+ } else if ("equals".equals(methodName)) {
+ if (stack.getStackDepth() > 1) {
+ OpcodeStack.Item item = stack.getStackItem(1);
+ if ("trim".equals(item.getUserValue())) {
+ bugReporter.reportBug(new BugInstance(this, "SPP_TEMPORARY_TRIM", NORMAL_PRIORITY)
+ .addClass(this)
+ .addMethod(this)
+ .addSourceLine(this));
+ }
+ }
}
} else if ("equals(Ljava/lang/Object;)Z".equals(methodName + getSigConstantOperand())) {
try {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-10-14 04:45:44
|
Revision: 1628
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1628&view=rev
Author: dbrosius
Date: 2010-10-14 04:45:37 +0000 (Thu, 14 Oct 2010)
Log Message:
-----------
start the 4.7.0 development
Modified Paths:
--------------
trunk/fb-contrib/build.xml
Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml 2010-09-28 00:12:54 UTC (rev 1627)
+++ trunk/fb-contrib/build.xml 2010-10-14 04:45:37 UTC (rev 1628)
@@ -20,7 +20,7 @@
<property name="javac.deprecation" value="on"/>
<property name="javac.debug" value="on"/>
- <property name="fb-contrib.version" value="4.6.0"/>
+ <property name="fb-contrib.version" value="4.7.0"/>
<target name="clean" description="removes all generated collateral">
<delete dir="${classes.dir}"/>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-28 00:13:00
|
Revision: 1627
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1627&view=rev
Author: dbrosius
Date: 2010-09-28 00:12:54 +0000 (Tue, 28 Sep 2010)
Log Message:
-----------
Version 4.6.0
Added Paths:
-----------
tags/v4_6_0/
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-27 23:24:54
|
Revision: 1626
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1626&view=rev
Author: dbrosius
Date: 2010-09-27 23:24:48 +0000 (Mon, 27 Sep 2010)
Log Message:
-----------
get ready for the 4.6.0 release
Modified Paths:
--------------
trunk/fb-contrib/htdocs/index.shtml
Modified: trunk/fb-contrib/htdocs/index.shtml
===================================================================
--- trunk/fb-contrib/htdocs/index.shtml 2010-09-27 23:21:10 UTC (rev 1625)
+++ trunk/fb-contrib/htdocs/index.shtml 2010-09-27 23:24:48 UTC (rev 1626)
@@ -73,14 +73,21 @@
</div>
<hr/>
- <img id="svn_image" src="flip2.gif" onClick="toggleBlock('svn', 'svn_image');" align="top"/>
+ <img id="svn_image" src="flip1.gif" onClick="toggleBlock('svn', 'svn_image');" align="top"/>
Detectors added in svn<br/>
- <div id="svn" style="display:block;">
+ <div id="svn" style="display:none;">
<ul>
<li><b>[CVAA] ContraVariant Array Assignment</b><br/>
Looks for contravariant array assignments. Since arrays are mutable data structures, their use
must be restricted to covariant or invariant usage.
<span style="color: #0000FF;">--contributed by Bhaskar Maddala - THANKS!</span></li>
+ </ul>
+ </div>
+ <hr/>
+ <img id="v4_6_0_image" src="flip2.gif" onClick="toggleBlock('v4_6_0', 'v4_6_0_image');" align="top"/>
+ Detectors added in v4.6.0<br/>
+ <div id="v4_6_0" style="display:block;">
+ <ul>
<li><b>[SNG] Suspicious Null Guard</b><br/>
Looks for code that checks to see if a field or local variable is not null
before entering a code block either an if, or while statement, and reassigns
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-27 23:21:16
|
Revision: 1625
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1625&view=rev
Author: dbrosius
Date: 2010-09-27 23:21:10 +0000 (Mon, 27 Sep 2010)
Log Message:
-----------
get ready for the 4.6.0 release
Modified Paths:
--------------
trunk/fb-contrib/.project
trunk/fb-contrib/build.xml
trunk/fb-contrib/etc/findbugs.xml
Modified: trunk/fb-contrib/.project
===================================================================
--- trunk/fb-contrib/.project 2010-09-26 06:08:19 UTC (rev 1624)
+++ trunk/fb-contrib/.project 2010-09-27 23:21:10 UTC (rev 1625)
@@ -3,6 +3,7 @@
<name>fb-contrib</name>
<comment></comment>
<projects>
+ <project>findbugs</project>
</projects>
<buildSpec>
<buildCommand>
@@ -32,4 +33,3 @@
<nature>edu.umd.cs.findbugs.plugin.eclipse.findbugsNature</nature>
</natures>
</projectDescription>
-
Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml 2010-09-26 06:08:19 UTC (rev 1624)
+++ trunk/fb-contrib/build.xml 2010-09-27 23:21:10 UTC (rev 1625)
@@ -20,7 +20,7 @@
<property name="javac.deprecation" value="on"/>
<property name="javac.debug" value="on"/>
- <property name="fb-contrib.version" value="4.5.0"/>
+ <property name="fb-contrib.version" value="4.6.0"/>
<target name="clean" description="removes all generated collateral">
<delete dir="${classes.dir}"/>
Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml 2010-09-26 06:08:19 UTC (rev 1624)
+++ trunk/fb-contrib/etc/findbugs.xml 2010-09-27 23:21:10 UTC (rev 1625)
@@ -17,7 +17,6 @@
<Detector class="com.mebigfatguy.fbcontrib.collect.CollectStatistics" speed="fast" reports="" hidden="true" />
-
<Detector class="com.mebigfatguy.fbcontrib.detect.InefficientStringBuffering" speed="fast" reports="ISB_INEFFICIENT_STRING_BUFFERING,ISB_EMPTY_STRING_APPENDING" />
<Detector class="com.mebigfatguy.fbcontrib.detect.SyncCollectionIterators" speed="slow" reports="SCI_SYNCHRONIZED_COLLECTION_ITERATORS" />
@@ -31,9 +30,9 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.UnrelatedCollectionContents" speed="fast" reports="UCC_UNRELATED_COLLECTION_CONTENTS" />
<Detector class="com.mebigfatguy.fbcontrib.detect.DeclaredRuntimeException" speed="fast" reports="DRE_DECLARED_RUNTIME_EXCEPTION" />
-
+<!--
<Detector class="com.mebigfatguy.fbcontrib.detect.ClassEnvy" speed="fast" reports="CE_CLASS_ENVY" disabled="true" />
-
+-->
<Detector class="com.mebigfatguy.fbcontrib.detect.LiteralStringComparison" speed="fast" reports="LSC_LITERAL_STRING_COMPARISON" />
<Detector class="com.mebigfatguy.fbcontrib.detect.PartiallyConstructedObjectAccess" speed="fast" reports="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS" />
@@ -74,8 +73,9 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.AbstractOverriddenMethod" speed="fast" reports="AOM_ABSTRACT_OVERRIDDEN_METHOD" />
<Detector class="com.mebigfatguy.fbcontrib.detect.CustomBuiltXML" speed="fast" reports="CBX_CUSTOM_BUILT_XML" />
-
- <!-- <Detector class="com.mebigfatguy.fbcontrib.detect.BloatedSynchronizedBlock" speed="fast" reports="BSB_BLOATED_SYNCHRONIZED_BLOCK" hidden="true" /> -->
+<!--
+ <Detector class="com.mebigfatguy.fbcontrib.detect.BloatedSynchronizedBlock" speed="fast" reports="BSB_BLOATED_SYNCHRONIZED_BLOCK" hidden="true" />
+-->
<Detector class="com.mebigfatguy.fbcontrib.detect.ConstantListIndex" speed="fast" reports="CLI_CONSTANT_LIST_INDEX" />
<Detector class="com.mebigfatguy.fbcontrib.detect.SloppyClassReflection" speed="fast" reports="SCR_SLOPPY_CLASS_REFLECTION" />
@@ -133,9 +133,9 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.SillynessPotPourri" speed="fast"
reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY,SPP_USE_ISEMPTY,SPP_USE_GETPROPERTY,SPP_USELESS_CASING,SPP_NON_ARRAY_PARM,SPP_EMPTY_CASING" />
-
+<!--
<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope" speed="fast" reports="BAS_BLOATED_ASSIGNMENT_SCOPE" hidden="true" />
-
+-->
<Detector class="com.mebigfatguy.fbcontrib.detect.SpoiledChildInterfaceImplementor" speed="fast" reports="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTOR" />
<Detector class="com.mebigfatguy.fbcontrib.detect.DeletingWhileIterating" speed="fast" reports="DWI_DELETING_WHILE_ITERATING,DWI_MODIFYING_WHILE_ITERATING" />
@@ -176,7 +176,9 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.UnnecessaryNewNullCheck" speed="fast" reports="UNNC_UNNECESSARY_NEW_NULL_CHECK" />
<Detector class="com.mebigfatguy.fbcontrib.detect.DeprecatedTypesafeEnumPattern" speed="fast" reports="DTEP_DEPRECATED_TYPESAFE_ENUM_PATTERN" />
- <!-- <Detector class="com.mebigfatguy.fbcontrib.detect.StutteredMethodArguments" speed="fast" reports="SMA_STUTTERED_METHOD_ARGUMENTS" hidden="true" /> -->
+<!--
+ <Detector class="com.mebigfatguy.fbcontrib.detect.StutteredMethodArguments" speed="fast" reports="SMA_STUTTERED_METHOD_ARGUMENTS" hidden="true" />
+-->
<Detector class="com.mebigfatguy.fbcontrib.detect.TristateBooleanPattern" speed="fast" reports="TBP_TRISTATE_BOOLEAN_PATTERN" />
@@ -191,9 +193,10 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.PoorlyDefinedParameter" speed="fast" reports="PDP_POORLY_DEFINED_PARAMETER" />
<Detector class="com.mebigfatguy.fbcontrib.detect.NonSymmetricEquals" speed="fast" reports="NSE_NON_SYMMETRIC_EQUALS" />
+<!--
+ <Detector class="com.mebigfatguy.fbcontrib.detect.ContraVariantArrayAssignment" speed="fast" hidden="true" reports="CVAA_CONTRAVARIANT_ARRAY_ASSIGNMENT,CVAA_CONTRAVARIANT_ELEMENT_ASSIGNMENT" />
+ -->
- <!-- <Detector class="com.mebigfatguy.fbcontrib.detect.ContraVariantArrayAssignment" speed="fast" hidden="true" reports="CVAA_CONTRAVARIANT_ARRAY_ASSIGNMENT,CVAA_CONTRAVARIANT_ELEMENT_ASSIGNMENT" /> -->
-
<Detector class="com.mebigfatguy.fbcontrib.detect.NonFunctionalField" speed="fast" reports="NFF_NON_FUNCTIONAL_FIELD" />
<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousNullGuard" speed="fast" reports="SNG_SUSPICIOUS_NULL_FIELD_GUARD,SNG_SUSPICIOUS_NULL_LOCAL_GUARD" />
@@ -216,6 +219,7 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.SideEffectConstructor" speed="fast" reports="SEC_SIDE_EFFECT_CONSTRUCTOR" />
<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousGetterSetterUse" speed="fast" reports="SGSU_SUSPICIOUS_GETTER_SETTER_USE" />
+
<!-- BugPattern -->
<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-26 06:08:27
|
Revision: 1624
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1624&view=rev
Author: dbrosius
Date: 2010-09-26 06:08:19 +0000 (Sun, 26 Sep 2010)
Log Message:
-----------
add etc as source
Modified Paths:
--------------
trunk/fb-contrib/.classpath
Modified: trunk/fb-contrib/.classpath
===================================================================
--- trunk/fb-contrib/.classpath 2010-09-26 06:01:11 UTC (rev 1623)
+++ trunk/fb-contrib/.classpath 2010-09-26 06:08:19 UTC (rev 1624)
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="src" path="samples"/>
+ <classpathentry excluding="**/*.*" kind="src" path="etc"/>
<classpathentry kind="src" path="src"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
<classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/4"/>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-26 06:01:17
|
Revision: 1623
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1623&view=rev
Author: dbrosius
Date: 2010-09-26 06:01:11 +0000 (Sun, 26 Sep 2010)
Log Message:
-----------
javadoc fix
Modified Paths:
--------------
trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousGetterSetterUse.java
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousGetterSetterUse.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousGetterSetterUse.java 2010-09-26 00:59:38 UTC (rev 1622)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousGetterSetterUse.java 2010-09-26 06:01:11 UTC (rev 1623)
@@ -51,7 +51,7 @@
* overrides the visitor to reset the state to SEEN_NOTHING, and clear the beanReference, propName
* and propType
*
- * @param code the context object of the currently parsed code block
+ * @param obj the context object of the currently parsed code block
*/
@Override
public void visitCode(Code obj) {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-26 00:59:44
|
Revision: 1622
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1622&view=rev
Author: dbrosius
Date: 2010-09-26 00:59:38 +0000 (Sun, 26 Sep 2010)
Log Message:
-----------
give credit to andrei loskutov for eclipse support
Modified Paths:
--------------
trunk/fb-contrib/htdocs/index.shtml
Modified: trunk/fb-contrib/htdocs/index.shtml
===================================================================
--- trunk/fb-contrib/htdocs/index.shtml 2010-09-26 00:57:09 UTC (rev 1621)
+++ trunk/fb-contrib/htdocs/index.shtml 2010-09-26 00:59:38 UTC (rev 1622)
@@ -101,6 +101,9 @@
bean's getter method for that property. This is usually a copy/paste typo.
</li>
</ul>
+ <ul>
+ <li><span style="color: #0000FF;">Eclipse plugin support by Andrei Loskutov - THANKS!</span></li>
+ </ul>
</div>
<hr/>
<img id="v4_4_0_image" src="flip1.gif" onClick="toggleBlock('v4_4_0', 'v4_4_0_image');" align="top"/>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-26 00:57:16
|
Revision: 1621
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1621&view=rev
Author: dbrosius
Date: 2010-09-26 00:57:09 +0000 (Sun, 26 Sep 2010)
Log Message:
-----------
Build.xml patch for Eclipse plugin - ID: 3074606: by Andrei Loskutov
Modified Paths:
--------------
trunk/fb-contrib/META-INF/MANIFEST.MF
trunk/fb-contrib/build.xml
Modified: trunk/fb-contrib/META-INF/MANIFEST.MF
===================================================================
--- trunk/fb-contrib/META-INF/MANIFEST.MF 2010-09-23 10:50:21 UTC (rev 1620)
+++ trunk/fb-contrib/META-INF/MANIFEST.MF 2010-09-26 00:57:09 UTC (rev 1621)
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: FB-Contrib Plug-in
-Bundle-SymbolicName: com.mebigfatguy.fbcontrib;singleton:=true
+Bundle-SymbolicName: fb-contrib;singleton:=true
Bundle-Version: 4.5.0.qualifier
Bundle-ClassPath: .
Bundle-Vendor: FB-Contrib Project
Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml 2010-09-23 10:50:21 UTC (rev 1620)
+++ trunk/fb-contrib/build.xml 2010-09-26 00:57:09 UTC (rev 1621)
@@ -4,9 +4,9 @@
-->
<project name="fb-contrib" default="install">
-
+
<property file="build.properties"/>
-
+
<property name="src.dir" value="${basedir}/src"/>
<property name="classes.dir" value="${basedir}/classes"/>
<property name="lib.dir" value="${basedir}/lib"/>
@@ -19,9 +19,9 @@
<property name="javac.target" value="1.5"/>
<property name="javac.deprecation" value="on"/>
<property name="javac.debug" value="on"/>
-
+
<property name="fb-contrib.version" value="4.5.0"/>
-
+
<target name="clean" description="removes all generated collateral">
<delete dir="${classes.dir}"/>
<delete dir="${javadoc.dir}"/>
@@ -35,7 +35,7 @@
</delete>
<delete dir="${basedir}/plugin"/>
</target>
-
+
<target name="-init" description="prepares repository for a build">
<mkdir dir="${classes.dir}"/>
<mkdir dir="${javadoc.dir}"/>
@@ -55,7 +55,7 @@
<mkdir dir="${classes.dir}/com/mebigfatguy/fbcontrib/detect"/>
<echo message="*.class" file="${classes.dir}/com/mebigfatguy/fbcontrib/detect/.cvsignore"/>
</target>
-
+
<target name="validate_xml" depends="-init" description="validates the xml files">
<xmlvalidate lenient="false" failonerror="yes">
<attribute name="http://apache.org/xml/features/validation/schema" value="true"/>
@@ -63,7 +63,7 @@
<fileset dir="${etc.dir}" includes="*.xml"/>
</xmlvalidate>
</target>
-
+
<target name="compile" depends="-init" description="compiles java files">
<javac srcdir="${src.dir}"
destdir="${classes.dir}"
@@ -74,7 +74,7 @@
<classpath refid="fb-contrib.classpath"/>
</javac>
</target>
-
+
<target name="compile_samples" depends="-init" description="compiles sample problem files">
<javac srcdir="${samples.dir}"
destdir="${samples.dir}"
@@ -96,8 +96,8 @@
<classpath refid="fb-contrib.classpath"/>
<classpath refid="fb-contrib.samples.classpath"/>
</javac>
- </target>
-
+ </target>
+
<target name="jar" depends="compile" description="produces the fb-contrib jar file">
<jar destfile="${basedir}/fb-contrib-${fb-contrib.version}.jar">
<fileset dir="etc">
@@ -110,6 +110,7 @@
<include name="**/*.class"/>
</fileset>
<fileset dir="${basedir}">
+ <include name="plugin.xml"/>
<include name="license.txt"/>
</fileset>
<manifest>
@@ -117,21 +118,23 @@
<attribute name="Main-Class" value="com.mebigfatguy.fbcontrib.FBContrib"/>
<attribute name="Bundle-ManifestVersion" value="2"/>
<attribute name="Bundle-Name" value="fb-contrib plugin"/>
- <attribute name="Bundle-SymbolicName" value="com.mebigfatguy.fbcontrib"/>
- <attribute name="Bundle-Version" value="${fb-contrib.version}"/>
- <attribute name="Import-Package" value="org.apache.bcel,org.apache.bcel.classfile,org.apache.bcel.generic,edu.umd.cs.findbugs,edu.umd.cs.findbugs.ba,edu.umd.cs.findbugs.visitclass"/>
- <attribute name="Export-Package" value="com.mebigfatguy.fbcontrib,com.mebigfatguy.fbcontrib.collect,com.mebigfatguy.fbcontrib.detect,com.mebigfatguy.fbcontrib.utils"/>
+ <attribute name="Bundle-SymbolicName" value="fb-contrib; singleton:=true"/>
+ <attribute name="Bundle-Version" value="${fb-contrib.version}"/>
+ <attribute name="Bundle-ClassPath" value="."/>
+ <attribute name="Bundle-Vendor" value="FB-Contrib Project"/>
+ <attribute name="Require-Bundle" value="edu.umd.cs.findbugs.plugin.eclipse"/>
+ <attribute name="Bundle-ActivationPolicy" value="lazy"/>
</manifest>
- </jar>
+ </jar>
</target>
-
+
<target name="html" depends="-init" description="generates dynamic html">
- <xslt basedir="${etc.dir}"
- destdir="${htdocs.dir}"
+ <xslt basedir="${etc.dir}"
+ destdir="${htdocs.dir}"
style="${etc.dir}/bugdescriptions.xsl"
in="${etc.dir}/messages.xml" out="${htdocs.dir}/bugdescriptions.html"/>
</target>
-
+
<target name="srczip" description="builds the source distribution zip file">
<zip destfile="${basedir}/fb-contrib-src-${fb-contrib.version}.zip" basedir="${basedir}">
<fileset dir="${src.dir}">
@@ -144,7 +147,7 @@
</fileset>
</zip>
</target>
-
+
<target name="javadoc" depends="-init" description="build the javadoc for the project">
<javadoc packagenames="com.mebigfatguy.*"
sourcepath="${src.dir}"
@@ -155,10 +158,10 @@
<bottom><![CDATA[<i>Copyright © 2005-2010 MeBigFatGuy.com. All Rights Reserved.</i>]]></bottom>
</javadoc>
</target>
-
+
<target name="build" depends="clean, -init, validate_xml, compile, compile_samples, jar" description="builds the plugin jar">
</target>
-
+
<target name="install" depends="build" description="installs the plugin into FindBugs">
<property environment="env"/>
<copy todir="${env.FINDBUGS_HOME}/plugin">
@@ -167,7 +170,7 @@
</fileset>
</copy>
</target>
-
+
<target name="release" depends="build, srczip, html, javadoc" description="prepares everything for a release"/>
</project>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-23 10:50:27
|
Revision: 1620
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1620&view=rev
Author: dbrosius
Date: 2010-09-23 10:50:21 +0000 (Thu, 23 Sep 2010)
Log Message:
-----------
spilleng
Modified Paths:
--------------
trunk/fb-contrib/etc/messages.xml
Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml 2010-09-22 06:31:36 UTC (rev 1619)
+++ trunk/fb-contrib/etc/messages.xml 2010-09-23 10:50:21 UTC (rev 1620)
@@ -2866,7 +2866,7 @@
<LongDescription>Method {1} uses the same HttpRequest parameter name but with different casing</LongDescription>
<Details>
<![CDATA[
- <p>This method fetches an HttpServletRequest parameter with a parmeter name that was used in other locations
+ <p>This method fetches an HttpServletRequest parameter with a parameter name that was used in other locations
but with a different casing. As HttpServletRequest parameters are case sensitive, this will be very confusing.
]]>
</Details>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-22 06:31:43
|
Revision: 1619
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1619&view=rev
Author: dbrosius
Date: 2010-09-22 06:31:36 +0000 (Wed, 22 Sep 2010)
Log Message:
-----------
Bug 3067921: Missing category for NRTL and SCII -- bad spilleng - thanks Andrei Loskutov
Modified Paths:
--------------
trunk/fb-contrib/etc/findbugs.xml
Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml 2010-09-22 06:20:35 UTC (rev 1618)
+++ trunk/fb-contrib/etc/findbugs.xml 2010-09-22 06:31:36 UTC (rev 1619)
@@ -100,7 +100,7 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.NonOwnedSynchronization" speed="fast" reports="NOS_NON_OWNED_SYNCHRONIZATION" />
- <Detector class="com.mebigfatguy.fbcontrib.detect.NonRecycleableTaglibs" speed="fast" reports="NRTL_NON_RECYCLEABLE_TAG_LIBS" />
+ <Detector class="com.mebigfatguy.fbcontrib.detect.NonRecycleableTaglibs" speed="fast" reports="NRTL_NON_RECYCLEABLE_TAG_LIB" />
<Detector class="com.mebigfatguy.fbcontrib.detect.Section508Compliance" speed="fast"
reports="S508C_NULL_LAYOUT,S508C_NO_SETLABELFOR,S508C_NO_SETSIZE,S508C_NON_ACCESSIBLE_JCOMPONENT,S508C_SET_COMP_COLOR,S508C_NON_TRANSLATABLE_STRING" />
@@ -136,7 +136,7 @@
<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope" speed="fast" reports="BAS_BLOATED_ASSIGNMENT_SCOPE" hidden="true" />
- <Detector class="com.mebigfatguy.fbcontrib.detect.SpoiledChildInterfaceImplementor" speed="fast" reports="SCI_SPOILED_CHILD_INTERFACE_IMPLEMENTOR" />
+ <Detector class="com.mebigfatguy.fbcontrib.detect.SpoiledChildInterfaceImplementor" speed="fast" reports="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTOR" />
<Detector class="com.mebigfatguy.fbcontrib.detect.DeletingWhileIterating" speed="fast" reports="DWI_DELETING_WHILE_ITERATING,DWI_MODIFYING_WHILE_ITERATING" />
@@ -266,8 +266,8 @@
<BugPattern abbrev="PMB" type="PMB_POSSIBLE_MEMORY_BLOAT" category="CORRECTNESS" />
<BugPattern abbrev="LSYC" type="LSYC_LOCAL_SYNCHRONIZED_COLLECTION" category="CORRECTNESS" />
<BugPattern abbrev="FCBL" type="FCBL_FIELD_COULD_BE_LOCAL" category="CORRECTNESS" />
+ <BugPattern abbrev="NRTL" type="NRTL_NON_RECYCLEABLE_TAG_LIB" category="CORRECTNESS"/>
<BugPattern abbrev="NOS" type="NOS_NON_OWNED_SYNCHRONIZATION" category="STYLE" />
- <BugPattern abbrev="NRTL" type="NRTL_NON_RECYCLEABLE_TAG_LIB" category="CORRECTNESS" />
<BugPattern abbrev="S508C" type="S508C_NULL_LAYOUT" category="CORRECTNESS" />
<BugPattern abbrev="S508C" type="S508C_NO_SETLABELFOR" category="CORRECTNESS" />
<BugPattern abbrev="S508C" type="S508C_NO_SETSIZE" category="CORRECTNESS" />
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-22 06:20:42
|
Revision: 1618
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1618&view=rev
Author: dbrosius
Date: 2010-09-22 06:20:35 +0000 (Wed, 22 Sep 2010)
Log Message:
-----------
fix bad patch command
Modified Paths:
--------------
trunk/fb-contrib/.classpath
trunk/fb-contrib/.project
Modified: trunk/fb-contrib/.classpath
===================================================================
--- trunk/fb-contrib/.classpath 2010-09-22 06:10:21 UTC (rev 1617)
+++ trunk/fb-contrib/.classpath 2010-09-22 06:20:35 UTC (rev 1618)
@@ -1,13 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
- <classpathentry kind="src" path="src"/>
- <classpathentry kind="src" path="etc"/>
- <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
- <classpathentry combineaccessrules="false" kind="src" path="/findbugs"/>
- <classpathentry kind="output" path="bin"/>
-</classpath>
-<?xml version="1.0" encoding="UTF-8"?>
-<classpath>
<classpathentry kind="src" path="samples"/>
<classpathentry kind="src" path="src"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
@@ -24,5 +16,6 @@
<classpathentry kind="lib" path="samples/lib/junit.jar"/>
<classpathentry kind="lib" path="samples/lib/log4j.jar"/>
<classpathentry kind="lib" path="samples/lib/servlet-api.jar"/>
+ <classpathentry combineaccessrules="false" kind="src" path="/findbugs"/>
<classpathentry kind="output" path="classes"/>
</classpath>
Modified: trunk/fb-contrib/.project
===================================================================
--- trunk/fb-contrib/.project 2010-09-22 06:10:21 UTC (rev 1617)
+++ trunk/fb-contrib/.project 2010-09-22 06:20:35 UTC (rev 1618)
@@ -32,26 +32,4 @@
<nature>edu.umd.cs.findbugs.plugin.eclipse.findbugsNature</nature>
</natures>
</projectDescription>
-<?xml version="1.0" encoding="UTF-8"?>
-<projectDescription>
- <name>fb-contrib</name>
- <comment></comment>
- <projects>
- </projects>
- <buildSpec>
- <buildCommand>
- <name>org.eclipse.wst.common.project.facet.core.builder</name>
- <arguments>
- </arguments>
- </buildCommand>
- <buildCommand>
- <name>org.eclipse.jdt.core.javabuilder</name>
- <arguments>
- </arguments>
- </buildCommand>
- </buildSpec>
- <natures>
- <nature>org.eclipse.jdt.core.javanature</nature>
- <nature>org.eclipse.wst.common.project.facet.core.nature</nature>
- </natures>
-</projectDescription>
+
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-22 06:10:27
|
Revision: 1617
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1617&view=rev
Author: dbrosius
Date: 2010-09-22 06:10:21 +0000 (Wed, 22 Sep 2010)
Log Message:
-----------
Patch 3071180: Convert fb-contrib to FindBugs Eclipse plugin - supplied by Andrei Loskutov - thanks
Modified Paths:
--------------
trunk/fb-contrib/build.properties
Added Paths:
-----------
trunk/fb-contrib/.classpath
trunk/fb-contrib/.project
trunk/fb-contrib/META-INF/
trunk/fb-contrib/META-INF/MANIFEST.MF
trunk/fb-contrib/plugin.xml
Added: trunk/fb-contrib/.classpath
===================================================================
--- trunk/fb-contrib/.classpath (rev 0)
+++ trunk/fb-contrib/.classpath 2010-09-22 06:10:21 UTC (rev 1617)
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+ <classpathentry kind="src" path="src"/>
+ <classpathentry kind="src" path="etc"/>
+ <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+ <classpathentry combineaccessrules="false" kind="src" path="/findbugs"/>
+ <classpathentry kind="output" path="bin"/>
+</classpath>
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+ <classpathentry kind="src" path="samples"/>
+ <classpathentry kind="src" path="src"/>
+ <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+ <classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/4"/>
+ <classpathentry kind="lib" path="lib/annotations.jar"/>
+ <classpathentry kind="lib" path="lib/asm-3.1.jar"/>
+ <classpathentry kind="lib" path="lib/asm-tree-3.1.jar"/>
+ <classpathentry kind="lib" path="lib/bcel.jar"/>
+ <classpathentry kind="lib" path="lib/dom4j-1.6.1.jar"/>
+ <classpathentry kind="lib" path="lib/findbugs-ant.jar"/>
+ <classpathentry kind="lib" path="lib/findbugs.jar" sourcepath="/findbugs"/>
+ <classpathentry kind="lib" path="lib/jsr305.jar"/>
+ <classpathentry kind="lib" path="samples/lib/jsp-api.jar"/>
+ <classpathentry kind="lib" path="samples/lib/junit.jar"/>
+ <classpathentry kind="lib" path="samples/lib/log4j.jar"/>
+ <classpathentry kind="lib" path="samples/lib/servlet-api.jar"/>
+ <classpathentry kind="output" path="classes"/>
+</classpath>
Property changes on: trunk/fb-contrib/.classpath
___________________________________________________________________
Added: svn:eol
+ native
Added: svn:mime-type
+ text/xml
Added: svn:eol-style
+ native
Added: trunk/fb-contrib/.project
===================================================================
--- trunk/fb-contrib/.project (rev 0)
+++ trunk/fb-contrib/.project 2010-09-22 06:10:21 UTC (rev 1617)
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+ <name>fb-contrib</name>
+ <comment></comment>
+ <projects>
+ </projects>
+ <buildSpec>
+ <buildCommand>
+ <name>org.eclipse.jdt.core.javabuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ <buildCommand>
+ <name>org.eclipse.pde.ManifestBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ <buildCommand>
+ <name>org.eclipse.pde.SchemaBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ <buildCommand>
+ <name>edu.umd.cs.findbugs.plugin.eclipse.findbugsBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ </buildSpec>
+ <natures>
+ <nature>org.eclipse.jdt.core.javanature</nature>
+ <nature>org.eclipse.pde.PluginNature</nature>
+ <nature>edu.umd.cs.findbugs.plugin.eclipse.findbugsNature</nature>
+ </natures>
+</projectDescription>
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+ <name>fb-contrib</name>
+ <comment></comment>
+ <projects>
+ </projects>
+ <buildSpec>
+ <buildCommand>
+ <name>org.eclipse.wst.common.project.facet.core.builder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ <buildCommand>
+ <name>org.eclipse.jdt.core.javabuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ </buildSpec>
+ <natures>
+ <nature>org.eclipse.jdt.core.javanature</nature>
+ <nature>org.eclipse.wst.common.project.facet.core.nature</nature>
+ </natures>
+</projectDescription>
Property changes on: trunk/fb-contrib/.project
___________________________________________________________________
Added: svn:eol
+ native
Added: svn:mime-type
+ text/xml
Added: svn:eol-style
+ native
Added: trunk/fb-contrib/META-INF/MANIFEST.MF
===================================================================
--- trunk/fb-contrib/META-INF/MANIFEST.MF (rev 0)
+++ trunk/fb-contrib/META-INF/MANIFEST.MF 2010-09-22 06:10:21 UTC (rev 1617)
@@ -0,0 +1,13 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: FB-Contrib Plug-in
+Bundle-SymbolicName: com.mebigfatguy.fbcontrib;singleton:=true
+Bundle-Version: 4.5.0.qualifier
+Bundle-ClassPath: .
+Bundle-Vendor: FB-Contrib Project
+Require-Bundle:
+ edu.umd.cs.findbugs.plugin.eclipse,
+ findbugs;resolution:=optional
+Bundle-RequiredExecutionEnvironment: J2SE-1.5
+Bundle-ActivationPolicy: lazy
+
Property changes on: trunk/fb-contrib/META-INF/MANIFEST.MF
___________________________________________________________________
Added: svn:eol
+ native
Added: svn:mime-type
+ text/plain
Added: svn:eol-style
+ native
Modified: trunk/fb-contrib/build.properties
===================================================================
--- trunk/fb-contrib/build.properties 2010-09-19 04:53:11 UTC (rev 1616)
+++ trunk/fb-contrib/build.properties 2010-09-22 06:10:21 UTC (rev 1617)
@@ -1 +1,8 @@
-jdk14.home=C:/j2sdk1.4.2_13
\ No newline at end of file
+jdk14.home=C:/j2sdk1.4.2_13
+bin.includes = plugin.xml,\
+ META-INF/,\
+ .
+jars.compile.order = .
+source.. = src/,\
+ etc/
+output.. = bin/
Added: trunk/fb-contrib/plugin.xml
===================================================================
--- trunk/fb-contrib/plugin.xml (rev 0)
+++ trunk/fb-contrib/plugin.xml 2010-09-22 06:10:21 UTC (rev 1617)
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<?eclipse version="3.4"?>
+<plugin>
+ <extension
+ point="edu.umd.cs.findbugs.plugin.eclipse.detectorPlugins">
+ <detectorPlugin
+ libraryPath=".">
+ </detectorPlugin>
+ </extension>
+
+</plugin>
Property changes on: trunk/fb-contrib/plugin.xml
___________________________________________________________________
Added: svn:eol
+ native
Added: svn:mime-type
+ text/xml
Added: svn:eol-style
+ native
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <dbr...@us...> - 2010-09-19 04:53:18
|
Revision: 1616
http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1616&view=rev
Author: dbrosius
Date: 2010-09-19 04:53:11 +0000 (Sun, 19 Sep 2010)
Log Message:
-----------
suppress fp's with self modification --> if (a != null) a = a.trim();
Modified Paths:
--------------
trunk/fb-contrib/samples/SNG_Sample.java
trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousNullGuard.java
Modified: trunk/fb-contrib/samples/SNG_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SNG_Sample.java 2010-09-19 03:37:29 UTC (rev 1615)
+++ trunk/fb-contrib/samples/SNG_Sample.java 2010-09-19 04:53:11 UTC (rev 1616)
@@ -36,4 +36,16 @@
s1 = null;
}
}
+
+ public void fpSelfAdjustingLocal(String s) {
+ if (s != null) {
+ s = s.trim();
+ }
+ }
+
+ public void fpSelfAdjustingField() {
+ if (f1 != null) {
+ f1 = f1.toString();
+ }
+ }
}
Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousNullGuard.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousNullGuard.java 2010-09-19 03:37:29 UTC (rev 1615)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousNullGuard.java 2010-09-19 04:53:11 UTC (rev 1616)
@@ -19,6 +19,7 @@
package com.mebigfatguy.fbcontrib.detect;
import java.util.HashMap;
+import java.util.Iterator;
import java.util.Map;
import org.apache.bcel.classfile.Code;
@@ -123,13 +124,25 @@
.addClass(this)
.addMethod(this)
.addSourceLine(this));
- nullGuards.remove(guard);
+ removeNullGuard(guard);
}
}
}
}
break;
+ case ALOAD:
+ case ALOAD_0:
+ case ALOAD_1:
+ case ALOAD_2:
+ case ALOAD_3: {
+ NullGuard guard = findNullGuardWithRegister(RegisterUtils.getALoadReg(this, seen));
+ if (guard != null) {
+ removeNullGuard(guard);
+ }
+ }
+ break;
+
case PUTFIELD: {
if (stack.getStackDepth() > 1) {
OpcodeStack.Item item = stack.getStackItem(0);
@@ -142,13 +155,26 @@
.addClass(this)
.addMethod(this)
.addSourceLine(this));
- nullGuards.remove(guard);
+ removeNullGuard(guard);
}
}
}
}
}
break;
+
+ case GETFIELD: {
+ if (stack.getStackDepth() > 0) {
+ XField xf = getXFieldOperand();
+ if (xf != null) {
+ NullGuard guard = findNullGuardWithField(xf);
+ if (guard != null) {
+ removeNullGuard(guard);
+ }
+ }
+ }
+ }
+ break;
case IFEQ:
case IFNE:
@@ -195,6 +221,17 @@
return null;
}
+ private void removeNullGuard(NullGuard guard) {
+ Iterator<NullGuard> it = nullGuards.values().iterator();
+ while (it.hasNext()) {
+ NullGuard potentialNG = it.next();
+ if (potentialNG.equals(guard)) {
+ it.remove();
+ break;
+ }
+ }
+ }
+
static class NullGuard {
int register;
XField field;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
