fb-contrib-commit Mailing List for fb-contrib (Page 47)

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Revision: 691
          http://svn.sourceforge.net/fb-contrib/?rev=691&view=rev
Author:   dbrosius
Date:     2006-11-18 21:18:32 -0800 (Sat, 18 Nov 2006)

Log Message:
-----------
add non Math.constants to SPP detector

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/samples/SPP_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================

--- trunk/fb-contrib/etc/findbugs.xml	2006-11-19 04:36:12 UTC (rev 690)
+++ trunk/fb-contrib/etc/findbugs.xml	2006-11-19 05:18:32 UTC (rev 691)
@@ -256,7 +256,7 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SillynessPotPourri"
 			speed="fast"
-			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR"/>
+			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT"/>
 			
    	<!-- BugPattern -->
 	
@@ -326,5 +326,6 @@
 	<BugPattern abbrev="SPP" type="SPP_NEGATIVE_BITSET_ITEM" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="SPP" type="SPP_INTERN_ON_CONSTANT" category="CORRECTNESS" experimental="true" />
 	<BugPattern abbrev="SPP" type="SPP_NO_CHAR_SB_CTOR" category="CORRECTNESS" experimental="true" />
+	<BugPattern abbrev="SPP" type="SPP_USE_MATH_CONSTANT" category="CORRECTNESS" experimental="true" />
 
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2006-11-19 04:36:12 UTC (rev 690)
+++ trunk/fb-contrib/etc/messages.xml	2006-11-19 05:18:32 UTC (rev 691)
@@ -1551,6 +1551,17 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SPP_USE_MATH_CONSTANT">
+		<ShortDescription>Method uses non standard math constant</ShortDescription>
+		<LongDescription>Method {1} uses non standard math constant</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method defines its own version of <b>PI</b> or <b>e</b> and the value is not as precise as the
+			one defined in the constants Math.PI or Math.E. Use these constants instead.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>

Modified: trunk/fb-contrib/samples/SPP_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SPP_Sample.java	2006-11-19 04:36:12 UTC (rev 690)
+++ trunk/fb-contrib/samples/SPP_Sample.java	2006-11-19 05:18:32 UTC (rev 691)
@@ -2,7 +2,9 @@
 
 public class SPP_Sample 
 {
-
+	private static final double pi = 3.14;
+	private static final double e = 2.72;
+	
 	public void testSPPBitSet(BitSet b)
 	{
 		b.set(-1);
@@ -19,4 +21,9 @@
 		sb.append("ictory");
 		return sb.toString();
 	}
+	
+	public double area(double radius)
+	{
+		return pi * radius * radius;
+	}
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2006-11-19 04:36:12 UTC (rev 690)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2006-11-19 05:18:32 UTC (rev 691)
@@ -19,6 +19,7 @@
 package com.mebigfatguy.fbcontrib.detect;
 
 import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.ConstantDouble;
 
 import edu.umd.cs.findbugs.BugInstance;
 import edu.umd.cs.findbugs.BugReporter;
@@ -72,7 +73,22 @@
 		try {
 			stack.mergeJumps(this);
 			
-			if (seen == INVOKEVIRTUAL) {
+			if (seen == LDC2_W) {
+				Object con = getConstantRefOperand();
+				if (con instanceof ConstantDouble) {
+					double d = ((ConstantDouble) con).getBytes();
+					double piDelta = Math.abs(d - Math.PI);
+					double eDelta = Math.abs(d - Math.E);
+					
+					if (((piDelta > 0.0) && (piDelta < 0.002))
+					||  ((eDelta > 0.0) && (eDelta < 0.002))) {
+						bugReporter.reportBug(new BugInstance(this, "SPP_USE_MATH_CONSTANT", NORMAL_PRIORITY)
+								   .addClass(this)
+								   .addMethod(this)
+								   .addSourceLine(this));
+					}
+				}
+			} else if (seen == INVOKEVIRTUAL) {
 				String className = getClassConstantOperand();
 				String methodName = getNameConstantOperand();
 				if ("java/util/BitSet".equals(className)) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




2005	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep (56)	Oct (60)	Nov (58)	Dec (89)
2006	Jan (66)	Feb (55)	Mar (85)	Apr (115)	May (35)	Jun (28)	Jul (3)	Aug (48)	Sep (37)	Oct (22)	Nov (14)	Dec (66)
2007	Jan (45)	Feb (63)	Mar (10)	Apr (1)	May (1)	Jun (12)	Jul	Aug	Sep (25)	Oct (21)	Nov (39)	Dec
2008	Jan (7)	Feb	Mar (26)	Apr (5)	May (2)	Jun (32)	Jul (9)	Aug (10)	Sep	Oct (3)	Nov (1)	Dec
2009	Jan (10)	Feb (31)	Mar (32)	Apr (35)	May (25)	Jun	Jul (31)	Aug (10)	Sep (95)	Oct (35)	Nov (10)	Dec (34)
2010	Jan (90)	Feb (4)	Mar (7)	Apr (20)	May (20)	Jun (13)	Jul (7)	Aug (18)	Sep (25)	Oct (4)	Nov (16)	Dec (2)
2011	Jan (1)	Feb	Mar (11)	Apr (3)	May (2)	Jun (26)	Jul (10)	Aug (2)	Sep	Oct (1)	Nov (1)	Dec (1)
2012	Jan (3)	Feb (4)	Mar	Apr	May	Jun	Jul (1)	Aug	Sep	Oct (14)	Nov (3)	Dec (4)
2013	Jan (3)	Feb (2)	Mar (1)	Apr (4)	May	Jun (1)	Jul (3)	Aug	Sep	Oct (4)	Nov (3)	Dec (3)
2014	Jan (4)	Feb (2)	Mar (4)	Apr (1)	May (2)	Jun	Jul (2)	Aug	Sep	Oct	Nov	Dec
2015	Jan	Feb	Mar	Apr	May (4)	Jun	Jul	Aug (3)	Sep	Oct	Nov (3)	Dec (3)
2016	Jan (2)	Feb	Mar	Apr (2)	May	Jun	Jul (1)	Aug (2)	Sep (4)	Oct (2)	Nov (7)	Dec
2017	Jan (1)	Feb	Mar (4)	Apr (5)	May (2)	Jun	Jul (2)	Aug	Sep (4)	Oct	Nov	Dec (3)
2018	Jan	Feb	Mar (2)	Apr	May (5)	Jun (2)	Jul (2)	Aug	Sep	Oct	Nov	Dec

fb-contrib-commit Mailing List for fb-contrib (Page 47)

fb-contrib-commit — Log for cvs commits of fb-contrib code