fb-contrib-commit Mailing List for fb-contrib (Page 35)

Brought to you by: dbrosius

fb-contrib-commit — Log for cvs commits of fb-contrib code

You can subscribe to this list here.

2005	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep (56)	Oct (60)	Nov (58)	Dec (89)
2006	Jan (66)	Feb (55)	Mar (85)	Apr (115)	May (35)	Jun (28)	Jul (3)	Aug (48)	Sep (37)	Oct (22)	Nov (14)	Dec (66)
2007	Jan (45)	Feb (63)	Mar (10)	Apr (1)	May (1)	Jun (12)	Jul	Aug	Sep (25)	Oct (21)	Nov (39)	Dec
2008	Jan (7)	Feb	Mar (26)	Apr (5)	May (2)	Jun (32)	Jul (9)	Aug (10)	Sep	Oct (3)	Nov (1)	Dec
2009	Jan (10)	Feb (31)	Mar (32)	Apr (35)	May (25)	Jun	Jul (31)	Aug (10)	Sep (95)	Oct (35)	Nov (10)	Dec (34)
2010	Jan (90)	Feb (4)	Mar (7)	Apr (20)	May (20)	Jun (13)	Jul (7)	Aug (18)	Sep (25)	Oct (4)	Nov (16)	Dec (2)
2011	Jan (1)	Feb	Mar (11)	Apr (3)	May (2)	Jun (26)	Jul (10)	Aug (2)	Sep	Oct (1)	Nov (1)	Dec (1)
2012	Jan (3)	Feb (4)	Mar	Apr	May	Jun	Jul (1)	Aug	Sep	Oct (14)	Nov (3)	Dec (4)
2013	Jan (3)	Feb (2)	Mar (1)	Apr (4)	May	Jun (1)	Jul (3)	Aug	Sep	Oct (4)	Nov (3)	Dec (3)
2014	Jan (4)	Feb (2)	Mar (4)	Apr (1)	May (2)	Jun	Jul (2)	Aug	Sep	Oct	Nov	Dec
2015	Jan	Feb	Mar	Apr	May (4)	Jun	Jul	Aug (3)	Sep	Oct	Nov (3)	Dec (3)
2016	Jan (2)	Feb	Mar	Apr (2)	May	Jun	Jul (1)	Aug (2)	Sep (4)	Oct (2)	Nov (7)	Dec
2017	Jan (1)	Feb	Mar (4)	Apr (5)	May (2)	Jun	Jul (2)	Aug	Sep (4)	Oct	Nov	Dec (3)
2018	Jan	Feb	Mar (2)	Apr	May (5)	Jun (2)	Jul (2)	Aug	Sep	Oct	Nov	Dec

Flat | Threaded

<< < 1 .. 33 34 35 36 37 .. 77 > >> (Page 35 of 77)

[Fb-contrib-commit] SF.net SVN: fb-contrib: [991] trunk/fb-contrib/samples/UAA_Sample.java

From: <dbr...@us...> - 2008-03-09 03:42:52

Revision: 991
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=991&view=rev
Author:   dbrosius
Date:     2008-03-08 19:42:54 -0800 (Sat, 08 Mar 2008)

Log Message:
-----------
add false positive as described by 1909543

Modified Paths:
--------------
    trunk/fb-contrib/samples/UAA_Sample.java

Modified: trunk/fb-contrib/samples/UAA_Sample.java
===================================================================
--- trunk/fb-contrib/samples/UAA_Sample.java	2008-03-09 03:35:10 UTC (rev 990)
+++ trunk/fb-contrib/samples/UAA_Sample.java	2008-03-09 03:42:54 UTC (rev 991)
@@ -65,4 +65,13 @@
 			}
 		}
 	}
+	
+	public void testAddWithCheck(List<String> src, List<String> dst)
+	{
+		for (String s : src)
+		{
+			if (dst.add(s))
+				System.out.println("Hmm");
+		}
+	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [990] trunk/fb-contrib

From: <dbr...@us...> - 2008-03-09 03:38:52

Revision: 990
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=990&view=rev
Author:   dbrosius
Date:     2008-03-08 19:35:10 -0800 (Sat, 08 Mar 2008)

Log Message:
-----------
update documentation to note that static methods also may return MRC issues, but at a LOW_PRIORITY

Modified Paths:
--------------
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2008-03-09 03:25:44 UTC (rev 989)
+++ trunk/fb-contrib/etc/messages.xml	2008-03-09 03:35:10 UTC (rev 990)
@@ -770,7 +770,7 @@
 	<Detector class="com.mebigfatguy.fbcontrib.detect.MethodReturnsConstant">
 		<Details>
 			<![CDATA[
-			<p>looks for private methods that only return one constant value. Since there is no
+			<p>looks for private or static methods that only return one constant value. Since there is no
 			chance for derived classes overriding this behavior, the return of a constant value 
 			seems dubious.</p>
 			<p>It is a fast detector</p>
@@ -2078,7 +2078,7 @@
 		<LongDescription>private method {1} only returns one constant value</LongDescription>
 		<Details>
 			<![CDATA[
-			<p>This private method only returns one constant value. As this method is private,
+			<p>This private or static method only returns one constant value. As this method is private or static,
 			it's behavior can't be overridden, and thus the return of a constant value seems dubious.
 			Either the method should be changed to return no value, or perhaps another return value
 			was expected to be returned in another code path in this method.</p>

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2008-03-09 03:25:44 UTC (rev 989)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2008-03-09 03:35:10 UTC (rev 990)
@@ -75,7 +75,7 @@
 			returnPC = -1;
 			super.visitCode(obj);
 			if (methodSuspect && (returnConstant != null)) {
-				BugInstance bi = new BugInstance(this, "MRC_METHOD_RETURNS_CONSTANT", NORMAL_PRIORITY)
+				BugInstance bi = new BugInstance(this, "MRC_METHOD_RETURNS_CONSTANT", ((aFlags & Constants.ACC_PRIVATE) != 0) ? NORMAL_PRIORITY : LOW_PRIORITY)
 									.addClass(this)
 									.addMethod(this);
 				if (returnPC >= 0)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [989] trunk/fb-contrib

From: <dbr...@us...> - 2008-03-09 03:25:38

Revision: 989
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=989&view=rev
Author:   dbrosius
Date:     2008-03-08 19:25:44 -0800 (Sat, 08 Mar 2008)

Log Message:
-----------
initial checkin of new SCA detector

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml

Added Paths:
-----------
    trunk/fb-contrib/samples/SCA_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2008-01-20 13:29:48 UTC (rev 988)
+++ trunk/fb-contrib/etc/findbugs.xml	2008-03-09 03:25:44 UTC (rev 989)
@@ -308,6 +308,10 @@
 			speed="fast"
 			reports="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT,JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE,JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" />
 			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousCloneAlgorithm"
+			speed="fast"
+			reports="SCA_SUSPICIOUS_CLONE_ALGORITHM" />
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -411,4 +415,5 @@
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT" category="STYLE" experimental="true" />
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE" category="STYLE" experimental="true" />
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" category="STYLE" experimental="true" />
+	<BugPattern abbrev="SCA" type="SCA_SUSPICIOUS_CLONE_ALGORITHM" category="CORRECTNESS" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2008-01-20 13:29:48 UTC (rev 988)
+++ trunk/fb-contrib/etc/messages.xml	2008-03-09 03:25:44 UTC (rev 989)
@@ -846,6 +846,15 @@
 			]]>
 		</Details>
 	</Detector>
+	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousCloneAlgorithm">
+		<Details>
+			<![CDATA[
+			<p>looks for implementation of clone where an assignment is made to a field of the
+			source object. It is likely that that store should have occurred on the cloned object, as
+			the clone operation is almost always considered read only.</p>]]>
+		</Details>
+	</Detector>
 				
 	
 	<!-- BugPattern -->	
@@ -2186,6 +2195,17 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SCA_SUSPICIOUS_CLONE_ALGORITHM">
+		<ShortDescription>clone method stores a new value to member field of source object</ShortDescription>
+		<LongDescription>clone method {1} stores a new value to member field of source object</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>The clone method stores a value to a member field of the source object. Normally, all 
+			changes are made to the cloned object, and given that cloning is almost always considered
+			a read-only operation, this seems incorrect.</p>]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -2257,4 +2277,5 @@
 	<BugCode abbrev="EXS">Exception Softening</BugCode>
 	<BugCode abbrev="CFS">Confusing Function Semantics</BugCode>
 	<BugCode abbrev="JAO">JUnit Assertion Oddities</BugCode>
+	<BugCode abbrev="SCA">Suspicious Clone Algorithm</BugCode>
 </MessageCollection>
\ No newline at end of file

Added: trunk/fb-contrib/samples/SCA_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SCA_Sample.java	                        (rev 0)
+++ trunk/fb-contrib/samples/SCA_Sample.java	2008-03-09 03:25:44 UTC (rev 989)
@@ -0,0 +1,16 @@
+import java.util.ArrayList;
+import java.util.List;
+
+
+public class SCA_Sample implements Cloneable 
+{
+	private List<String> names = new ArrayList<String>();
+	
+	public Object clone() throws CloneNotSupportedException {
+		SCA_Sample s = (SCA_Sample)super.clone();
+		names = new ArrayList<String>();
+		s.names.addAll(names);
+		names.add("New");
+		return s;
+	}
+}


Property changes on: trunk/fb-contrib/samples/SCA_Sample.java
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native

Added: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java	                        (rev 0)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java	2008-03-09 03:25:44 UTC (rev 989)
@@ -0,0 +1,179 @@
+/*
+ * fb-contrib - Auxiliary detectors for Java programs
+ * Copyright (C) 2005-2008 Dave Brosius
+ * 
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ * 
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+package com.mebigfatguy.fbcontrib.detect;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.bcel.Repository;
+import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.JavaClass;
+import org.apache.bcel.classfile.Method;
+import org.apache.bcel.generic.Type;
+
+import com.mebigfatguy.fbcontrib.utils.Integer14;
+
+import edu.umd.cs.findbugs.BugInstance;
+import edu.umd.cs.findbugs.BugReporter;
+import edu.umd.cs.findbugs.BytecodeScanningDetector;
+import edu.umd.cs.findbugs.OpcodeStack;
+import edu.umd.cs.findbugs.ba.ClassContext;
+
+/**
+ * looks for implementation of clone() where a store is made to a member
+ * of the source object.
+ */
+public class SuspiciousCloneAlgorithm extends BytecodeScanningDetector {
+	
+	private static JavaClass cloneableClass;
+	private static Map<String, Integer> changingMethods;
+	static {
+		try {
+			cloneableClass = Repository.lookupClass("java/lang/Cloneable");
+			changingMethods = new HashMap<String, Integer>();
+			changingMethods.put("add", Integer14.valueOf(NORMAL_PRIORITY));
+			changingMethods.put("addAll", Integer14.valueOf(NORMAL_PRIORITY));
+			changingMethods.put("put", Integer14.valueOf(NORMAL_PRIORITY));
+			changingMethods.put("putAll", Integer14.valueOf(NORMAL_PRIORITY));
+			changingMethods.put("insert", Integer14.valueOf(LOW_PRIORITY));
+			changingMethods.put("set", Integer14.valueOf(LOW_PRIORITY));
+			
+		} catch (ClassNotFoundException cnfe) {
+			cloneableClass = null;
+		}
+	}
+	
+	private BugReporter bugReporter;
+	private OpcodeStack stack;
+	
+	/**
+     * constructs a SCA detector given the reporter to report bugs on
+     * @param bugReporter the sync of bug reports
+	 */
+	public SuspiciousCloneAlgorithm(BugReporter bugReporter) {
+		this.bugReporter = bugReporter;
+	}
+	
+	/**
+	 * override the visitor to look for classes that implement Cloneable
+	 * 
+	 * @param classContext the context object of the class to be checked
+	 */
+	@Override
+	public void visitClassContext(ClassContext classContext) {
+		if (cloneableClass == null)
+			return;
+		
+		try {
+			JavaClass cls = classContext.getJavaClass();
+			if (cls.implementationOf(cloneableClass)) {
+				stack = new OpcodeStack();
+				super.visitClassContext(classContext);
+			}
+		} catch (ClassNotFoundException cnfe) {
+			bugReporter.reportMissingClass(cnfe);
+		} finally {
+			stack = null;
+		}
+	}
+	
+	/**
+	 * override the visitor to only continue for the clone method
+	 * 
+	 * @param obj the context object of the currently parsed method
+	 */
+	@Override
+	public void visitCode(Code obj) {
+		Method m = getMethod();
+		if (!m.isStatic() && "clone".equals(m.getName()) && "()Ljava/lang/Object;".equals(m.getSignature()))
+			super.visitCode(obj);
+	}
+	
+	/**
+	 * override the visitor to look for stores to member fields of the source object on a clone
+	 * 
+	 * @param seen the opcode of the currently parsed instruction
+	 */
+	@Override
+	public void sawOpcode(int seen) {
+		boolean srcField = false;
+		try {
+			stack.mergeJumps(this);
+			switch (seen) {
+				case ALOAD_0:
+					srcField = true;
+				break;
+				
+				case DUP:
+					if (stack.getStackDepth() > 0) {
+						OpcodeStack.Item item = stack.getStackItem(0);
+						if (item.getUserValue() != null)
+							srcField = true;
+					}
+				break;
+				
+				case GETFIELD:
+					if (stack.getStackDepth() > 0) {
+						OpcodeStack.Item item = stack.getStackItem(0);
+						if (item.getRegisterNumber() == 0) {
+							srcField = true;
+						}
+					}
+				break;
+				
+				case PUTFIELD:
+					if (stack.getStackDepth() >= 2) {
+						OpcodeStack.Item item = stack.getStackItem(1);
+						if ((item.getRegisterNumber() == 0) || (item.getUserValue() != null)) {
+							bugReporter.reportBug(new BugInstance(this, "SCA_SUSPICIOUS_CLONE_ALGORITHM", NORMAL_PRIORITY)
+									   .addClass(this)
+									   .addMethod(this)
+									   .addSourceLine(this));
+						}
+					}
+					
+				break;
+				
+				case INVOKEINTERFACE:
+				case INVOKEVIRTUAL:
+					String sig = getSigConstantOperand();
+					int numArgs = Type.getArgumentTypes(sig).length;
+					if (stack.getStackDepth() > numArgs) {
+						OpcodeStack.Item item = stack.getStackItem(numArgs);
+						if ((item.getRegisterNumber() == 0) || (item.getUserValue() != null)) {
+							String name = getNameConstantOperand();
+							Integer priority = changingMethods.get(name);
+							if (priority != null)
+								bugReporter.reportBug(new BugInstance(this, "SCA_SUSPICIOUS_CLONE_ALGORITHM", priority.intValue())
+								   .addClass(this)
+								   .addMethod(this)
+								   .addSourceLine(this));
+						}
+					}
+				break;
+			}
+		} finally {
+			stack.sawOpcode(this, seen);
+			if (srcField && stack.getStackDepth() > 0) {
+				OpcodeStack.Item item = stack.getStackItem(0);
+				item.setUserValue(Boolean.TRUE);
+			}
+		}
+	}
+}


Property changes on: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [988] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseAddAll.java

From: <dbr...@us...> - 2008-01-20 13:29:49

Revision: 988
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=988&view=rev
Author:   dbrosius
Date:     2008-01-20 05:29:48 -0800 (Sun, 20 Jan 2008)

Log Message:
-----------
type safety

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2008-01-18 17:09:52 UTC (rev 987)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2008-01-20 13:29:48 UTC (rev 988)
@@ -56,9 +56,9 @@
 	private BugReporter bugReporter;
 	private OpcodeStack stack;
 	/** register/field to alias register/field */
-	private Map<Comparable, Comparable> userValues;
+	private Map<Comparable<?>, Comparable<?>> userValues;
 	/** alias register to loop info  */
-	private Map<Comparable, LoopInfo> loops;
+	private Map<Comparable<?>, LoopInfo> loops;
 	private boolean isInstanceMethod;
 	
 	/**
@@ -101,8 +101,8 @@
 	public void visitCode(Code obj) {
 		try {
 			stack.resetForMethodEntry(this);
-			userValues = new HashMap<Comparable, Comparable>();
-			loops = new HashMap<Comparable, LoopInfo>();
+			userValues = new HashMap<Comparable<?>, Comparable<?>>();
+			loops = new HashMap<Comparable<?>, LoopInfo>();
 			isInstanceMethod = !getMethod().isStatic();
 			super.visitCode(obj);
 		} finally {
@@ -118,8 +118,8 @@
 	 */
 	@Override
 	public void sawOpcode(int seen) {
-		Comparable regOrField = null;
-		Comparable uValue;
+		Comparable<?> regOrField = null;
+		Comparable<?> uValue;
 		boolean sawAlias = false;
 		boolean sawLoad = false;
 		
@@ -164,7 +164,7 @@
 						int reg = isLocalCollection(colItem);
 						if (reg >= 0) {
 							regOrField = Integer14.valueOf(reg);
-							uValue = (Comparable)valueItem.getUserValue();
+							uValue = (Comparable<?>)valueItem.getUserValue();
 							if (uValue != null) {
 								LoopInfo loop = loops.get(uValue);
 								if ((loop != null) && loop.isInLoop(getPC(), false)) {
@@ -178,7 +178,7 @@
 							String field = isFieldCollection(colItem);
 							if (field != null) {
 								regOrField = field;
-								uValue = (Comparable)valueItem.getUserValue();
+								uValue = (Comparable<?>)valueItem.getUserValue();
 								if (uValue != null) {
 									LoopInfo loop = loops.get(uValue);
 									if ((loop != null) && loop.isInLoop(getPC(), false)) {
@@ -195,7 +195,7 @@
 			} else if (((seen == ISTORE) || ((seen >= ISTORE_0) && (seen <= ISTORE_3)))
 				   ||  ((seen == ASTORE) || ((seen >= ASTORE_0) && (seen <= ASTORE_3)))) {
 				if (stack.getStackDepth() > 0) {
-					uValue = (Comparable)stack.getStackItem(0).getUserValue();
+					uValue = (Comparable<?>)stack.getStackItem(0).getUserValue();
 					userValues.put(Integer14.valueOf(RegisterUtils.getStoreReg(this, seen)), uValue); 
 				}
 			} else if (((seen == ILOAD) || ((seen >= ILOAD_0) && (seen <= ILOAD_3)))
@@ -214,7 +214,7 @@
 							gotoPos += brOffset;
 							if (gotoPos < getPC()) {
 								OpcodeStack.Item itm = stack.getStackItem(0);
-								uValue = (Comparable)itm.getUserValue();
+								uValue = (Comparable<?>)itm.getUserValue();
 								if (uValue != null) {
 									loops.put(uValue, new LoopInfo(getPC(), getBranchTarget()));
 								}
@@ -235,7 +235,7 @@
 				if (stack.getStackDepth() > 1) {
 					OpcodeStack.Item item = stack.getStackItem(1);
 					if (item.getRegisterNumber() == 0) {
-						uValue = (Comparable)stack.getStackItem(0).getUserValue();
+						uValue = (Comparable<?>)stack.getStackItem(0).getUserValue();
 						userValues.put(getNameConstantOperand(), uValue);
 					}
 				}
@@ -254,7 +254,7 @@
 			} else if (seen == CHECKCAST) {
 				if (stack.getStackDepth() > 0) {
 					OpcodeStack.Item itm = stack.getStackItem(0);
-					uValue = (Comparable)itm.getUserValue();
+					uValue = (Comparable<?>)itm.getUserValue();
 					if (uValue != null) {
 						regOrField = uValue;
 						sawAlias = true;
@@ -298,7 +298,7 @@
 	 * @throws ClassNotFoundException if the items class cannot be found
 	 */
 	private int isLocalCollection(OpcodeStack.Item item) throws ClassNotFoundException {
-		Comparable aliasReg = (Comparable)item.getUserValue();
+		Comparable<?> aliasReg = (Comparable<?>)item.getUserValue();
 		if (aliasReg instanceof Integer)
 			return ((Integer)aliasReg).intValue();
 		
@@ -322,7 +322,7 @@
 	 * @throws ClassNotFoundException if the items class cannot be found
 	 */	
 	private String isFieldCollection(OpcodeStack.Item item) throws ClassNotFoundException {
-			Comparable aliasReg = (Comparable)item.getUserValue();
+			Comparable<?> aliasReg = (Comparable<?>)item.getUserValue();
 			if (aliasReg instanceof String)
 				return (String)aliasReg;
 			


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [987] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseEnumCollections.java

From: <dbr...@us...> - 2008-01-18 17:12:30

Revision: 987
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=987&view=rev
Author:   dbrosius
Date:     2008-01-18 09:09:52 -0800 (Fri, 18 Jan 2008)

Log Message:
-----------
guard against OpcodeStack having problems

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2008-01-17 22:48:05 UTC (rev 986)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2008-01-18 17:09:52 UTC (rev 987)
@@ -139,12 +139,14 @@
 				Integer reg = Integer14.valueOf(RegisterUtils.getALoadReg(this, seen));
 				sawEnumCollectionCreation = enumRegs.get(reg);
 			} else if (seen == PUTFIELD) {
-				String fieldName = getNameConstantOperand();
-				OpcodeStack.Item itm = stack.getStackItem(0);
-				if (itm.getUserValue() != null)
-					enumFields.put(fieldName, (Boolean)itm.getUserValue());
-				else
-					enumFields.remove(fieldName);
+				if (stack.getStackDepth() > 0) {
+					String fieldName = getNameConstantOperand();
+					OpcodeStack.Item itm = stack.getStackItem(0);
+					if (itm.getUserValue() != null)
+						enumFields.put(fieldName, (Boolean)itm.getUserValue());
+					else
+						enumFields.remove(fieldName);
+				}
 			} else if (seen == GETFIELD) {
 				String fieldName = getNameConstantOperand();
 				sawEnumCollectionCreation = enumFields.get(fieldName);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [986] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SillynessPotPourri.java

From: <dbr...@us...> - 2008-01-17 22:49:04

Revision: 986
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=986&view=rev
Author:   dbrosius
Date:     2008-01-17 14:48:05 -0800 (Thu, 17 Jan 2008)

Log Message:
-----------
guard against empty stack

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-01-11 06:22:19 UTC (rev 985)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-01-17 22:48:05 UTC (rev 986)
@@ -429,14 +429,16 @@
 								}
 							}
 						} else if ("(Ljava/lang/String;)V".equals(signature)) {
-                            OpcodeStack.Item item = stack.getStackItem(0);
-                            String con = (String)item.getConstant();
-                            if ("".equals(con)) {
-                                bugReporter.reportBug(new BugInstance(this, "SPP_STRINGBUFFER_WITH_EMPTY_STRING", NORMAL_PRIORITY)
-                                   .addClass(this)
-                                   .addMethod(this)
-                                   .addSourceLine(this));
-                            }                           
+							if (stack.getStackDepth() > 0) {
+	                            OpcodeStack.Item item = stack.getStackItem(0);
+	                            String con = (String)item.getConstant();
+	                            if ("".equals(con)) {
+	                                bugReporter.reportBug(new BugInstance(this, "SPP_STRINGBUFFER_WITH_EMPTY_STRING", NORMAL_PRIORITY)
+	                                   .addClass(this)
+	                                   .addMethod(this)
+	                                   .addSourceLine(this));
+	                            } 
+	                        }                          
                         }
 					}
 				} else if ("java/math/BigDecimal".equals(className)) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [985] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/JUnitAssertionOddities.java

From: <dbr...@us...> - 2008-01-11 06:22:19

Revision: 985
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=985&view=rev
Author:   dbrosius
Date:     2008-01-10 22:22:19 -0800 (Thu, 10 Jan 2008)

Log Message:
-----------
constant pool instance bytes are unsigned

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-01-10 05:47:58 UTC (rev 984)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-01-11 06:22:19 UTC (rev 985)
@@ -107,7 +107,7 @@
 						if (att instanceof Unknown) {
 							Unknown unAtt = (Unknown)att;
 							byte[] bytes = unAtt.getBytes();
-							int constantPoolIndex = bytes[3];
+							int constantPoolIndex = bytes[3] & 0x000000FF;
 							c = cp.getConstant(constantPoolIndex);
 							if (c instanceof ConstantUtf8) {
 								name = ((ConstantUtf8) c).getBytes();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [984] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib

From: <dbr...@us...> - 2008-01-10 05:48:01

Revision: 984
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=984&view=rev
Author:   dbrosius
Date:     2008-01-09 21:47:58 -0800 (Wed, 09 Jan 2008)

Log Message:
-----------
update to 2008

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -28,7 +28,7 @@
      * @param args standard command line args
      */
     public static void main(final String[] args) {
-		JOptionPane.showMessageDialog( null, "To use fb-contrib, copy this jar file into your local FindBugs plugin directory, and use FindBugs as usual.\n\nfb-contrib is a trademark of MeBigFatGuy.com\nFindBugs is a trademark of the University of Maryland", "fb-contrib: copyright 2005-2007", JOptionPane.INFORMATION_MESSAGE);
+		JOptionPane.showMessageDialog( null, "To use fb-contrib, copy this jar file into your local FindBugs plugin directory, and use FindBugs as usual.\n\nfb-contrib is a trademark of MeBigFatGuy.com\nFindBugs is a trademark of the University of Maryland", "fb-contrib: copyright 2005-2008", JOptionPane.INFORMATION_MESSAGE);
 		System.exit(0);
 	}
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java	2008-01-10 05:31:19 UTC (rev 983)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java	2008-01-10 05:47:58 UTC (rev 984)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2007 Dave Brosius
+ * Copyright (C) 2005-2008 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [983] trunk/fb-contrib/samples/NAB_Sample.java

From: <dbr...@us...> - 2008-01-10 05:31:17

Revision: 983
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=983&view=rev
Author:   dbrosius
Date:     2008-01-09 21:31:19 -0800 (Wed, 09 Jan 2008)

Log Message:
-----------
extra test

Modified Paths:
--------------
    trunk/fb-contrib/samples/NAB_Sample.java

Modified: trunk/fb-contrib/samples/NAB_Sample.java
===================================================================
--- trunk/fb-contrib/samples/NAB_Sample.java	2008-01-10 05:30:23 UTC (rev 982)
+++ trunk/fb-contrib/samples/NAB_Sample.java	2008-01-10 05:31:19 UTC (rev 983)
@@ -132,4 +132,9 @@
 		
 		return Boolean.valueOf(s.equals("true") && bb.booleanValue());
 	}
+	
+	public Boolean testBooleanReturns()
+	{
+		return true;
+	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [982] trunk/fb-contrib

From: <dbr...@us...> - 2008-01-10 05:30:18

Revision: 982
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=982&view=rev
Author:   dbrosius
Date:     2008-01-09 21:30:23 -0800 (Wed, 09 Jan 2008)

Log Message:
-----------
Initial checkin JAO detector

Modified Paths:
--------------
    trunk/fb-contrib/build.xml
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/samples/samples.fb

Added Paths:
-----------
    trunk/fb-contrib/samples/JAO_Sample.java
    trunk/fb-contrib/samples/lib/junit.jar
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java

Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml	2007-11-24 15:59:04 UTC (rev 981)
+++ trunk/fb-contrib/build.xml	2008-01-10 05:30:23 UTC (rev 982)
@@ -45,6 +45,7 @@
 		</path>
 		<path id="fb-contrib.samples.classpath">
 			<pathelement location="${sampleslib.dir}/jsp-api.jar"/>
+			<pathelement location="${sampleslib.dir}/junit.jar"/>
 		</path>
 		<mkdir dir="${classes.dir}/com"/>
 		<mkdir dir="${classes.dir}/com/mebigfatguy"/>

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2007-11-24 15:59:04 UTC (rev 981)
+++ trunk/fb-contrib/etc/findbugs.xml	2008-01-10 05:30:23 UTC (rev 982)
@@ -304,6 +304,10 @@
 			speed="fast"
 			reports="CFS_CONFUSING_FUNCTION_SEMANTICS" />
 			
+	<Detector class="com.mebigfatguy.fbcontrib.detect.JUnitAssertionOddities"
+			speed="fast"
+			reports="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT,JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE,JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" />
+			
    	<!-- BugPattern -->
 	
 	<BugPattern abbrev="ISB" type="ISB_INEFFICIENT_STRING_BUFFERING" category="PERFORMANCE" />
@@ -404,4 +408,7 @@
 	<BugPattern abbrev="EXS" type="EXS_EXCEPTION_SOFTENING_HAS_CHECKED" category="STYLE" />
 	<BugPattern abbrev="EXS" type="EXS_EXCEPTION_SOFTENING_NO_CHECKED" category="STYLE" />
 	<BugPattern abbrev="CFS" type="CFS_CONFUSING_FUNCTION_SEMANTICS" category="STYLE" experimental="true" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT" category="STYLE" experimental="true" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE" category="STYLE" experimental="true" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" category="STYLE" experimental="true" />
 </FindbugsPlugin>
\ No newline at end of file

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2007-11-24 15:59:04 UTC (rev 981)
+++ trunk/fb-contrib/etc/messages.xml	2008-01-10 05:30:23 UTC (rev 982)
@@ -831,6 +831,23 @@
 		</Details>
 	</Detector>
 	
+	<Detector class="com.mebigfatguy.fbcontrib.detect.JUnitAssertionOddities">
+		<Details>
+			<![CDATA[
+			<p>looks for junit test case methods that use assertions with odd parameters.
+			Including in this is:
+			<ul>
+				<li>Passing a constant as the second (actual) parameter</li>
+				<li>not using the three parameter version of asserts for doubles</li>
+				<li>Passing true or false as the first parameter instead of using assertTrue, or assertFalse</li>
+			</ul>
+			</p>
+			<p>It is a fast detector</p>
+			]]>
+		</Details>
+	</Detector>
+				
+	
 	<!-- BugPattern -->	
 	                
 	<BugPattern type="ISB_INEFFICIENT_STRING_BUFFERING">
@@ -2135,6 +2152,40 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT">
+		<ShortDescription>method passes constant to second (actual) assertion parameter</ShortDescription>
+		<LongDescription>method {1} passes constant to second (actual) assertion parameter</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method calls assert passing a constant value as the second of the two values. The assert
+			method assumes that the expected value is the first parameter, and so it appears that the order
+			of values has been swapped here.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
+	<BugPattern type="JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE">
+		<ShortDescription>method asserts that two doubles are exactly equal</ShortDescription>
+		<LongDescription>method {1} asserts that two doubles are exactly equal</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method calls assert with two doubles or Doubles. Due to the inprecision of doubles, you
+			should be using the assert method that takes a range parameter that gives a range of error.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
+	<BugPattern type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT">
+		<ShortDescription>method asserts that a value is true or false</ShortDescription>
+		<LongDescription>method {1} asserts that a value is true or false</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method asserts that a value is equal to true or false. It is simpler to just 
+			use assertTrue, or assertFalse, instead.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<!-- BugCode -->
 	
 	<BugCode abbrev="ISB">Inefficient String Buffering</BugCode>
@@ -2205,4 +2256,5 @@
 	<BugCode abbrev="MOM">Misleading Overload Model</BugCode>
 	<BugCode abbrev="EXS">Exception Softening</BugCode>
 	<BugCode abbrev="CFS">Confusing Function Semantics</BugCode>
+	<BugCode abbrev="JAO">JUnit Assertion Oddities</BugCode>
 </MessageCollection>
\ No newline at end of file

Added: trunk/fb-contrib/samples/JAO_Sample.java
===================================================================
--- trunk/fb-contrib/samples/JAO_Sample.java	                        (rev 0)
+++ trunk/fb-contrib/samples/JAO_Sample.java	2008-01-10 05:30:23 UTC (rev 982)
@@ -0,0 +1,27 @@
+import junit.framework.Assert;
+import junit.framework.TestCase;
+
+
+public class JAO_Sample extends TestCase 
+{
+	
+	public void testExactDoubles(double d1, double d2)
+	{
+		Assert.assertEquals(d1, d2);
+	}
+	
+	public void testTrue(boolean b)
+	{
+		Assert.assertEquals(true, b);
+	}
+	
+	public void testFalse(boolean b)
+	{
+		Assert.assertEquals("Wow this is bad", false, b);
+	}
+	
+	public void testWrongOrder(int i)
+	{
+		Assert.assertEquals(i, 10);
+	}
+}


Property changes on: trunk/fb-contrib/samples/JAO_Sample.java
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native

Added: trunk/fb-contrib/samples/lib/junit.jar
===================================================================
(Binary files differ)


Property changes on: trunk/fb-contrib/samples/lib/junit.jar
___________________________________________________________________
Name: svn:mime-type
   + application/octet-stream

Modified: trunk/fb-contrib/samples/samples.fb
===================================================================
--- trunk/fb-contrib/samples/samples.fb	2007-11-24 15:59:04 UTC (rev 981)
+++ trunk/fb-contrib/samples/samples.fb	2008-01-10 05:30:23 UTC (rev 982)
@@ -4,5 +4,6 @@
 .
 [Aux classpath entries]
 .\lib\jsp-api.jar
+.\lib\junit.jar
 [Options]
 relative_paths=true

Added: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	                        (rev 0)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-01-10 05:30:23 UTC (rev 982)
@@ -0,0 +1,181 @@
+/*
+ * fb-contrib - Auxiliary detectors for Java programs
+ * Copyright (C) 2005-2007 Dave Brosius
+ * 
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ * 
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+package com.mebigfatguy.fbcontrib.detect;
+
+import org.apache.bcel.Repository;
+import org.apache.bcel.classfile.Attribute;
+import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.Constant;
+import org.apache.bcel.classfile.ConstantPool;
+import org.apache.bcel.classfile.ConstantUtf8;
+import org.apache.bcel.classfile.JavaClass;
+import org.apache.bcel.classfile.Method;
+import org.apache.bcel.classfile.Unknown;
+import org.apache.bcel.generic.Type;
+
+import edu.umd.cs.findbugs.BugInstance;
+import edu.umd.cs.findbugs.BugReporter;
+import edu.umd.cs.findbugs.BytecodeScanningDetector;
+import edu.umd.cs.findbugs.OpcodeStack;
+import edu.umd.cs.findbugs.ba.ClassContext;
+
+/** looks for odd uses of the Assert class of the JUnit framework */
+public class JUnitAssertionOddities extends BytecodeScanningDetector 
+{
+	private static final String RUNTIME_VISIBLE_ANNOTATIONS = "RuntimeVisibleAnnotations";
+	private static final String TEST_ANNOTATION_SIGNATURE = "Lorg/junit/Test;";
+	private static final String OLD_ASSERT_CLASS = "junit/framework/Assert";
+	private static final String NEW_ASSERT_CLASS = "org/junit/Assert";
+	private static JavaClass testCaseClass;
+	private static JavaClass testAnnotationClass;
+	static {
+		try {
+			testCaseClass = Repository.lookupClass("junit.framework.TestCase");
+		} catch (ClassNotFoundException cnfe) {
+			testCaseClass = null;
+		}
+		try {
+			testAnnotationClass = Repository.lookupClass("org.junit.Test");
+		} catch (ClassNotFoundException cnfe) {
+			testAnnotationClass = null;
+		}
+	}
+	private BugReporter bugReporter;
+	private OpcodeStack stack;
+	private boolean isTestCaseDerived;
+	private boolean isAnnotationCapable;
+	
+	/**
+     * constructs a JOA detector given the reporter to report bugs on
+     * @param bugReporter the sync of bug reports
+	 */
+	public JUnitAssertionOddities(BugReporter bugReporter) {
+		this.bugReporter = bugReporter;
+	}
+	
+	/**
+	 * override the visitor to see if this class could be a test class
+	 * 
+	 * @param classContext the context object of the currently parsed class
+	 */
+	@Override
+	public void visitClassContext(ClassContext classContext) {
+		try {
+			JavaClass cls = classContext.getJavaClass();
+			isTestCaseDerived = ((testCaseClass != null) && cls.instanceOf(testCaseClass));
+			isAnnotationCapable = (cls.getMajor() >= 5) && (testAnnotationClass != null);
+			if (isTestCaseDerived || isAnnotationCapable) {
+				stack = new OpcodeStack();
+				super.visitClassContext(classContext);
+			}
+		} catch (ClassNotFoundException cnfe) {
+			bugReporter.reportMissingClass(cnfe);
+		} finally {
+			stack = null;
+		}
+	}
+	
+	@Override
+	public void visitCode(Code obj) {
+		Method m = getMethod();
+		boolean isTestMethod = isTestCaseDerived && m.getName().startsWith("test");
+		
+		if (!isTestMethod && isAnnotationCapable) {
+			Attribute[] atts = m.getAttributes();
+			for (Attribute att : atts) {
+				ConstantPool cp = att.getConstantPool();
+				Constant c = cp.getConstant(att.getNameIndex());
+				if (c instanceof ConstantUtf8) {
+					String name = ((ConstantUtf8) c).getBytes();
+					if (RUNTIME_VISIBLE_ANNOTATIONS.equals(name)) {
+						if (att instanceof Unknown) {
+							Unknown unAtt = (Unknown)att;
+							byte[] bytes = unAtt.getBytes();
+							int constantPoolIndex = bytes[3];
+							c = cp.getConstant(constantPoolIndex);
+							if (c instanceof ConstantUtf8) {
+								name = ((ConstantUtf8) c).getBytes();
+								if (TEST_ANNOTATION_SIGNATURE.equals(name)) {
+									isTestMethod = true;
+									break;
+								}
+							}
+						}
+					}
+				}
+			}
+		}
+		
+		if (isTestMethod) {
+			stack.resetForMethodEntry(this);
+			super.visitCode(obj);
+		}
+	}
+	
+	@Override
+	public void sawOpcode(int seen) {
+		try {
+			stack.mergeJumps(this);
+			
+			if (seen == INVOKESTATIC) {
+				String clsName = getClassConstantOperand();
+				if (OLD_ASSERT_CLASS.equals(clsName) || NEW_ASSERT_CLASS.equals(clsName)) {
+					String methodName = getNameConstantOperand();
+					if ("assertEquals".equals(methodName)) {
+						String signature = getSigConstantOperand();
+						Type[] argTypes = Type.getArgumentTypes(signature);
+						if (argTypes[0].equals(Type.STRING) && argTypes[1].equals(Type.STRING))
+							return;
+						
+						if (stack.getStackDepth() >= 2) {
+							OpcodeStack.Item item1 = stack.getStackItem(1);
+							Object cons1 = item1.getConstant();
+							if ((cons1 != null) && (argTypes[argTypes.length-1].equals(Type.BOOLEAN)) && (argTypes[argTypes.length-2].equals(Type.BOOLEAN))) {
+								bugReporter.reportBug(new BugInstance(this, "JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT", NORMAL_PRIORITY)
+								   .addClass(this)
+								   .addMethod(this)
+								   .addSourceLine(this));
+								return;
+							} 
+							OpcodeStack.Item item0 = stack.getStackItem(0);
+							if (item0.getConstant() != null) {
+								bugReporter.reportBug(new BugInstance(this, "JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT", NORMAL_PRIORITY)
+										   .addClass(this)
+										   .addMethod(this)
+										   .addSourceLine(this));
+								return;
+							}
+							if (argTypes[0].equals(Type.OBJECT) && argTypes[1].equals(Type.OBJECT)) {
+								if ("Ljava/lang/Double;".equals(item0.getSignature()) && "Ljava/lang/Double;".equals(item1.getSignature())) {
+									bugReporter.reportBug(new BugInstance(this, "JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE", NORMAL_PRIORITY)
+									   .addClass(this)
+									   .addMethod(this)
+									   .addSourceLine(this));
+									return;
+								}
+							}
+						}
+					}
+				}
+			}
+		} finally {
+			stack.sawOpcode(this, seen);
+		}
+	}
+}


Property changes on: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [981] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SillynessPotPourri.java

From: <dbr...@us...> - 2007-11-24 15:59:00

Revision: 981
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=981&view=rev
Author:   dbrosius
Date:     2007-11-24 07:59:04 -0800 (Sat, 24 Nov 2007)

Log Message:
-----------
USBR fixes

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2007-11-24 15:55:47 UTC (rev 980)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2007-11-24 15:59:04 UTC (rev 981)
@@ -475,7 +475,6 @@
 	
 	private int getshort(byte[] bytes, int offset)
 	{
-		short s = (short)((0x0000FFFF & (bytes[offset] << 8)) | (0x00FF & bytes[offset+1]));
-		return s;
+		return (short)((0x0000FFFF & (bytes[offset] << 8)) | (0x00FF & bytes[offset+1]));
 	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [980] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/NeedlessAutoboxing.java

From: <dbr...@us...> - 2007-11-24 15:55:42

Revision: 980
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=980&view=rev
Author:   dbrosius
Date:     2007-11-24 07:55:47 -0800 (Sat, 24 Nov 2007)

Log Message:
-----------
BAS fixes

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2007-11-24 01:30:06 UTC (rev 979)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2007-11-24 15:55:47 UTC (rev 980)
@@ -134,8 +134,8 @@
 						state = SEEN_ICONST;
 				} else if (seen == GETSTATIC) {
 					String clsName = getClassConstantOperand();
-					String fldName = getNameConstantOperand();
 					if ("java/lang/Boolean".equals(clsName)) {
+						String fldName = getNameConstantOperand();
 						if ("TRUE".equals(fldName) || "FALSE".equals(fldName))
 							state = SEEN_GETSTATIC;
 					}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [979] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib

From: <dbr...@us...> - 2007-11-24 01:30:18

Revision: 979
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=979&view=rev
Author:   dbrosius
Date:     2007-11-23 17:30:06 -0800 (Fri, 23 Nov 2007)

Log Message:
-----------
pad the stats. fix spelling of auxilary

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java	2007-11-24 01:22:26 UTC (rev 978)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java	2007-11-24 01:30:06 UTC (rev 979)
@@ -1,5 +1,5 @@
 /*
- * fb-contrib - Auxilliary detectors for Java programs
+ * fb-contrib - Auxiliary detectors for Java programs
  * Copyright (C) 2005-2007 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [978] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/FieldCouldBeLocal.java

From: <dbr...@us...> - 2007-11-24 01:22:26

Revision: 978
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=978&view=rev
Author:   dbrosius
Date:     2007-11-23 17:22:26 -0800 (Fri, 23 Nov 2007)

Log Message:
-----------
be precise about setup/teardown

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2007-11-23 07:59:00 UTC (rev 977)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2007-11-24 01:22:26 UTC (rev 978)
@@ -79,36 +79,37 @@
 	 */
 	@Override	
 	public void visitClassContext(ClassContext classContext) {
-        localizableFields = new HashMap<String, FieldInfo>();
-        visitedBlocks = new BitSet();
-		clsContext = classContext;
-		cfg = null;
-		cpg = null;
-		JavaClass cls = classContext.getJavaClass();
-		Field[] fields = cls.getFields();
-		for (Field f : fields) {
-			if ((!f.isStatic() && f.getName().indexOf('$') < 0) && f.isPrivate()) {
-				FieldAnnotation fa = new FieldAnnotation(cls.getClassName(), f.getName(), f.getSignature(), false);
-				localizableFields.put(f.getName(), new FieldInfo(fa));
+		try {
+	        localizableFields = new HashMap<String, FieldInfo>();
+	        visitedBlocks = new BitSet();
+			clsContext = classContext;
+			JavaClass cls = classContext.getJavaClass();
+			Field[] fields = cls.getFields();
+			for (Field f : fields) {
+				if ((!f.isStatic() && f.getName().indexOf('$') < 0) && f.isPrivate()) {
+					FieldAnnotation fa = new FieldAnnotation(cls.getClassName(), f.getName(), f.getSignature(), false);
+					localizableFields.put(f.getName(), new FieldInfo(fa));
+				}
 			}
-		}
-		
-		if (localizableFields.size() > 0) {
-			super.visitClassContext(classContext);
-			for (FieldInfo fi : localizableFields.values()) {
-				FieldAnnotation fa = fi.getFieldAnnotation();
-				SourceLineAnnotation sla = fi.getSrcLineAnnotation();
-				BugInstance bug = new BugInstance(this, "FCBL_FIELD_COULD_BE_LOCAL", NORMAL_PRIORITY)
-												.addClass(this)
-												.addField(fa);
-				if (sla != null)
-					bug.addSourceLine(sla);
-				bugReporter.reportBug(bug);
+			
+			if (localizableFields.size() > 0) {
+				super.visitClassContext(classContext);
+				for (FieldInfo fi : localizableFields.values()) {
+					FieldAnnotation fa = fi.getFieldAnnotation();
+					SourceLineAnnotation sla = fi.getSrcLineAnnotation();
+					BugInstance bug = new BugInstance(this, "FCBL_FIELD_COULD_BE_LOCAL", NORMAL_PRIORITY)
+													.addClass(this)
+													.addField(fa);
+					if (sla != null)
+						bug.addSourceLine(sla);
+					bugReporter.reportBug(bug);
+				}
 			}
+		} finally {
+	        localizableFields = null;
+	        visitedBlocks = null;
+	        clsContext = null;
 		}
-        localizableFields = null;
-        visitedBlocks = null;
-        clsContext = null;
 	}
 	
 	/**
@@ -138,6 +139,7 @@
 		}
         finally {
             cfg = null;
+            cpg = null;
         }
 	}
 	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [977] trunk/fb-contrib

From: <dbr...@us...> - 2007-11-23 07:58:58

Revision: 977
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=977&view=rev
Author:   dbrosius
Date:     2007-11-22 23:59:00 -0800 (Thu, 22 Nov 2007)

Log Message:
-----------
remove fps due to compiler generated boolean trinaries

Modified Paths:
--------------
    trunk/fb-contrib/samples/NAB_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java

Modified: trunk/fb-contrib/samples/NAB_Sample.java
===================================================================
--- trunk/fb-contrib/samples/NAB_Sample.java	2007-11-23 03:50:50 UTC (rev 976)
+++ trunk/fb-contrib/samples/NAB_Sample.java	2007-11-23 07:59:00 UTC (rev 977)
@@ -123,11 +123,13 @@
 		d = Double.valueOf(6.0).floatValue();
 	}
 	
-	public void testBooleanConsts()
+	public Boolean testBooleanConsts(String s)
 	{
 		boolean b = Boolean.FALSE;
 		b = Boolean.TRUE;
 		Boolean bb = false;
 		bb = true;
+		
+		return Boolean.valueOf(s.equals("true") && bb.booleanValue());
 	}
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2007-11-23 03:50:50 UTC (rev 976)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2007-11-23 07:59:00 UTC (rev 977)
@@ -40,8 +40,9 @@
 	private static final int SEEN_PARSE = 3;
 	private static final int SEEN_CTOR = 4;
 	private static final int SEEN_VALUEOFPRIMITIVE = 5;
-	private static final int SEEN_ICONST = 6;
-	private static final int SEEN_GETSTATIC = 7;
+	private static final int SEEN_GOTO = 6;
+	private static final int SEEN_ICONST = 7;
+	private static final int SEEN_GETSTATIC = 8;
 	
 	private static final Map<String, String[]> boxClasses = new HashMap<String, String[]>();
 	static {
@@ -88,6 +89,7 @@
 		
 		switch (state) {
 			case SEEN_NOTHING:
+			case SEEN_GOTO:
 				if (seen == INVOKEVIRTUAL) {
 					boxClass = getClassConstantOperand();
 					String[] boxSigs = boxClasses.get(boxClass);
@@ -128,7 +130,8 @@
 						}
 					}
 				} else if ((seen == ICONST_0) || (seen == ICONST_1)) {
-					state = SEEN_ICONST;
+					if (state == SEEN_NOTHING)
+						state = SEEN_ICONST;
 				} else if (seen == GETSTATIC) {
 					String clsName = getClassConstantOperand();
 					String fldName = getNameConstantOperand();
@@ -136,6 +139,8 @@
 						if ("TRUE".equals(fldName) || "FALSE".equals(fldName))
 							state = SEEN_GETSTATIC;
 					}
+				} else if (seen == GOTO) {
+					state = SEEN_GOTO;
 				}
 			break;
 			
@@ -237,6 +242,7 @@
 					}
 				}
 				state = SEEN_NOTHING;
+				sawOpcode(seen);
 			break;
 			
 			case SEEN_GETSTATIC:
@@ -251,8 +257,8 @@
 					}
 				}
 				state = SEEN_NOTHING;
+				sawOpcode(seen);
 			break;
-				
 		}		
 	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [976] trunk/fb-contrib

From: <dbr...@us...> - 2007-11-23 03:50:45

Revision: 976
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=976&view=rev
Author:   dbrosius
Date:     2007-11-22 19:50:50 -0800 (Thu, 22 Nov 2007)

Log Message:
-----------
add checks for Boolean constant boxing 

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/samples/NAB_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2007-11-23 00:52:32 UTC (rev 975)
+++ trunk/fb-contrib/etc/findbugs.xml	2007-11-23 03:50:50 UTC (rev 976)
@@ -115,7 +115,7 @@
     		
     <Detector class="com.mebigfatguy.fbcontrib.detect.NeedlessAutoboxing"
     		speed="fast"
-    		reports="NAB_NEEDLESS_AUTOBOXING_CTOR,NAB_NEEDLESS_BOXING_STRING_CTOR,NAB_NEEDLESS_AUTOBOXING_VALUEOF,NAB_NEEDLESS_BOXING_PARSE,NAB_NEEDLESS_BOXING_VALUEOF,NAB_NEEDLESS_BOX_TO_UNBOX,NAB_NEEDLESS_BOX_TO_CAST" />
+    		reports="NAB_NEEDLESS_AUTOBOXING_CTOR,NAB_NEEDLESS_BOXING_STRING_CTOR,NAB_NEEDLESS_AUTOBOXING_VALUEOF,NAB_NEEDLESS_BOXING_PARSE,NAB_NEEDLESS_BOXING_VALUEOF,NAB_NEEDLESS_BOX_TO_UNBOX,NAB_NEEDLESS_BOX_TO_CAST,NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION" />
 
     <Detector class="com.mebigfatguy.fbcontrib.detect.UnnecessaryStoreBeforeReturn"
     		speed="fast"
@@ -335,6 +335,7 @@
     <BugPattern abbrev="NAB" type="NAB_NEEDLESS_BOXING_VALUEOF" category="PERFORMANCE" />
     <BugPattern abbrev="NAB" type="NAB_NEEDLESS_BOX_TO_UNBOX" category="PERFORMANCE" />
     <BugPattern abbrev="NAB" type="NAB_NEEDLESS_BOX_TO_CAST" category="PERFORMANCE" />
+    <BugPattern abbrev="NAB" type="NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION" category="PERFORMANCE" />
     <BugPattern abbrev="USBR" type="USBR_UNNECESSARY_STORE_BEFORE_RETURN" category="STYLE" />
     <BugPattern abbrev="COM" type="COM_COPIED_OVERRIDDEN_METHOD" category="STYLE" />
     <BugPattern abbrev="ABC" type="ABC_ARRAY_BASED_COLLECTIONS" category="CORRECTNESS" />

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2007-11-23 00:52:32 UTC (rev 975)
+++ trunk/fb-contrib/etc/messages.xml	2007-11-23 03:50:50 UTC (rev 976)
@@ -1208,6 +1208,26 @@
 			]]>
 		</Details>
 	</BugPattern>
+	
+	<BugPattern type="NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION">
+		<ShortDescription>method needlessly boxes a boolean constant</ShortDescription>
+		<LongDescription>method {1} needlessly boxes a boolean constant</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method assigns a Boxed boolean constant to a primitive boolean variable, or assigns a primitive boolean
+			constant to a Boxed boolean variable. Use the correct constant for the variable desired. Use</p>
+			<pre>
+				boolean b = true;
+				boolean b = false;
+				
+				or
+				
+				Boolean b = Boolean.TRUE;
+				Boolean b = Boolean.FALSE;
+			</pre>
+			]]>
+		</Details>
+	</BugPattern>
 			
 	<BugPattern type="USBR_UNNECESSARY_STORE_BEFORE_RETURN">
 		<ShortDescription>method stores return result in local before immediately returning it</ShortDescription>

Modified: trunk/fb-contrib/samples/NAB_Sample.java
===================================================================
--- trunk/fb-contrib/samples/NAB_Sample.java	2007-11-23 00:52:32 UTC (rev 975)
+++ trunk/fb-contrib/samples/NAB_Sample.java	2007-11-23 03:50:50 UTC (rev 976)
@@ -122,4 +122,12 @@
 		d = new Double(6.0).floatValue();
 		d = Double.valueOf(6.0).floatValue();
 	}
+	
+	public void testBooleanConsts()
+	{
+		boolean b = Boolean.FALSE;
+		b = Boolean.TRUE;
+		Boolean bb = false;
+		bb = true;
+	}
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2007-11-23 00:52:32 UTC (rev 975)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2007-11-23 03:50:50 UTC (rev 976)
@@ -40,6 +40,8 @@
 	private static final int SEEN_PARSE = 3;
 	private static final int SEEN_CTOR = 4;
 	private static final int SEEN_VALUEOFPRIMITIVE = 5;
+	private static final int SEEN_ICONST = 6;
+	private static final int SEEN_GETSTATIC = 7;
 	
 	private static final Map<String, String[]> boxClasses = new HashMap<String, String[]>();
 	static {
@@ -125,6 +127,15 @@
 							state = SEEN_CTOR;
 						}
 					}
+				} else if ((seen == ICONST_0) || (seen == ICONST_1)) {
+					state = SEEN_ICONST;
+				} else if (seen == GETSTATIC) {
+					String clsName = getClassConstantOperand();
+					String fldName = getNameConstantOperand();
+					if ("java/lang/Boolean".equals(clsName)) {
+						if ("TRUE".equals(fldName) || "FALSE".equals(fldName))
+							state = SEEN_GETSTATIC;
+					}
 				}
 			break;
 			
@@ -213,6 +224,34 @@
 				}
 				state = SEEN_NOTHING;
 			break;
+			
+			case SEEN_ICONST:
+				if (seen == INVOKESTATIC) {
+					if (("java/lang/Boolean".equals(getClassConstantOperand())
+					&&  ("valueOf".equals(getNameConstantOperand())
+					&&  ("(Z)Ljava/lang/Boolean;".equals(getSigConstantOperand()))))) {
+						bugReporter.reportBug(new BugInstance(this, "NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION", NORMAL_PRIORITY)
+									.addClass(this)
+									.addMethod(this)
+									.addSourceLine(this));
+					}
+				}
+				state = SEEN_NOTHING;
+			break;
+			
+			case SEEN_GETSTATIC:
+				if (seen == INVOKEVIRTUAL) {
+					if (("java/lang/Boolean".equals(getClassConstantOperand())
+					&&  ("booleanValue".equals(getNameConstantOperand())
+					&&  ("()Z".equals(getSigConstantOperand()))))) {
+						bugReporter.reportBug(new BugInstance(this, "NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION", NORMAL_PRIORITY)
+									.addClass(this)
+									.addMethod(this)
+									.addSourceLine(this));
+					}
+				}
+				state = SEEN_NOTHING;
+			break;
 				
 		}		
 	}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [975] trunk/fb-contrib

From: <dbr...@us...> - 2007-11-23 00:52:27

Revision: 975
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=975&view=rev
Author:   dbrosius
Date:     2007-11-22 16:52:32 -0800 (Thu, 22 Nov 2007)

Log Message:
-----------
go back to 3.5.0 dev

Modified Paths:
--------------
    trunk/fb-contrib/build.xml
    trunk/fb-contrib/etc/findbugs.xml

Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml	2007-11-23 00:45:11 UTC (rev 974)
+++ trunk/fb-contrib/build.xml	2007-11-23 00:52:32 UTC (rev 975)
@@ -20,7 +20,7 @@
 	<property name="javac.deprecation" value="on"/>
 	<property name="javac.debug" value="on"/>
 	
-	<property name="fb-contrib.version" value="3.4.2"/>
+	<property name="fb-contrib.version" value="3.5.0"/>
 	
 	<target name="clean" description="removes all generated collateral">
 		<delete dir="${classes.dir}"/>

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2007-11-23 00:45:11 UTC (rev 974)
+++ trunk/fb-contrib/etc/findbugs.xml	2007-11-23 00:52:32 UTC (rev 975)
@@ -302,8 +302,7 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.ConfusingFunctionSemantics"
 			speed="fast"
-			reports="CFS_CONFUSING_FUNCTION_SEMANTICS" 
-			hidden="true" />
+			reports="CFS_CONFUSING_FUNCTION_SEMANTICS" />
 			
    	<!-- BugPattern -->
 	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [974] tags/v3_4_2/

From: <dbr...@us...> - 2007-11-23 00:45:10

Revision: 974
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=974&view=rev
Author:   dbrosius
Date:     2007-11-22 16:45:11 -0800 (Thu, 22 Nov 2007)

Log Message:
-----------
Tag version 3.4.2

Added Paths:
-----------
    tags/v3_4_2/

Copied: tags/v3_4_2 (from rev 973, trunk/fb-contrib)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [973] trunk/fb-contrib

From: <dbr...@us...> - 2007-11-23 00:42:00

Revision: 973
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=973&view=rev
Author:   dbrosius
Date:     2007-11-22 16:42:03 -0800 (Thu, 22 Nov 2007)

Log Message:
-----------
get ready for 3.4.2

Modified Paths:
--------------
    trunk/fb-contrib/build.xml
    trunk/fb-contrib/etc/findbugs.xml

Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml	2007-11-23 00:31:52 UTC (rev 972)
+++ trunk/fb-contrib/build.xml	2007-11-23 00:42:03 UTC (rev 973)
@@ -20,7 +20,7 @@
 	<property name="javac.deprecation" value="on"/>
 	<property name="javac.debug" value="on"/>
 	
-	<property name="fb-contrib.version" value="3.5.0"/>
+	<property name="fb-contrib.version" value="3.4.2"/>
 	
 	<target name="clean" description="removes all generated collateral">
 		<delete dir="${classes.dir}"/>
@@ -162,7 +162,7 @@
                  failOnError="true">
         	<class location="${basedir}/fb-contrib-${fb-contrib.version}.jar"/> 
        	</findbugs>
-       	<delete dir="${basedir}/plugin"/>
+       	<!--<delete dir="${basedir}/plugin"/>-->
 	</target>
 	
 	<target name="build" depends="clean, -init, validate_xml, compile, compile_samples, jar" description="builds the plugin jar">

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2007-11-23 00:31:52 UTC (rev 972)
+++ trunk/fb-contrib/etc/findbugs.xml	2007-11-23 00:42:03 UTC (rev 973)
@@ -302,7 +302,8 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.ConfusingFunctionSemantics"
 			speed="fast"
-			reports="CFS_CONFUSING_FUNCTION_SEMANTICS" />
+			reports="CFS_CONFUSING_FUNCTION_SEMANTICS" 
+			hidden="true" />
 			
    	<!-- BugPattern -->
 	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [972] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/MisleadingOverloadModel.java

From: <dbr...@us...> - 2007-11-23 00:31:48

Revision: 972
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=972&view=rev
Author:   dbrosius
Date:     2007-11-22 16:31:52 -0800 (Thu, 22 Nov 2007)

Log Message:
-----------
get rid of java5 dependency

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MisleadingOverloadModel.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MisleadingOverloadModel.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MisleadingOverloadModel.java	2007-11-22 06:23:23 UTC (rev 971)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MisleadingOverloadModel.java	2007-11-23 00:31:52 UTC (rev 972)
@@ -6,6 +6,8 @@
 import org.apache.bcel.classfile.JavaClass;
 import org.apache.bcel.classfile.Method;
 
+import com.mebigfatguy.fbcontrib.utils.Integer14;
+
 import edu.umd.cs.findbugs.BugInstance;
 import edu.umd.cs.findbugs.BugReporter;
 import edu.umd.cs.findbugs.Detector;
@@ -19,7 +21,10 @@
  */
 public class MisleadingOverloadModel  extends PreorderVisitor implements Detector
 {
-	private static enum MethodType { INSTANCE, STATIC, BOTH };
+	private static final Integer INSTANCE = Integer14.valueOf(0);
+	private static final Integer STATIC = Integer14.valueOf(1);
+	private static final Integer BOTH = Integer14.valueOf(2);
+	
 	private BugReporter bugReporter;
 	
 	/**
@@ -31,26 +36,26 @@
 	}
 	
 	public void visitClassContext(ClassContext classContext) {
-		Map<String, MethodType> declMethods = new HashMap<String, MethodType>();
+		Map<String, Integer> declMethods = new HashMap<String, Integer>();
 		JavaClass cls = classContext.getJavaClass();
 		String clsName = cls.getClassName();
 		Method[] methods = cls.getMethods();
 		for (Method m : methods) {
 			String methodName = m.getName();
 			boolean report;
-			MethodType newType;
+			Integer newType;
 			if (m.isStatic()) {
-				report = declMethods.get(methodName) == MethodType.INSTANCE;
+				report = declMethods.get(methodName) == INSTANCE;
 				if (report)
-					newType = MethodType.BOTH;
+					newType = BOTH;
 				else
-					newType = MethodType.STATIC;
+					newType = STATIC;
 			} else {
-				report = declMethods.get(m.getName()) == MethodType.STATIC;
+				report = declMethods.get(m.getName()) == STATIC;
 				if (report)
-					newType = MethodType.BOTH;
+					newType = BOTH;
 				else
-					newType = MethodType.INSTANCE;
+					newType = INSTANCE;
 			}
 			
 			declMethods.put(methodName, newType);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [971] trunk/fb-contrib

From: <dbr...@us...> - 2007-11-22 06:23:19

Revision: 971
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=971&view=rev
Author:   dbrosius
Date:     2007-11-21 22:23:23 -0800 (Wed, 21 Nov 2007)

Log Message:
-----------
look for .toString calls on stringbuffer/stringbuilder just to get the length.

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/samples/SPP_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2007-11-21 13:26:13 UTC (rev 970)
+++ trunk/fb-contrib/etc/findbugs.xml	2007-11-22 06:23:23 UTC (rev 971)
@@ -256,7 +256,7 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SillynessPotPourri"
 			speed="fast"
-			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST" />
+			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH" />
 		
 	<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope"
 			speed="fast"
@@ -388,6 +388,7 @@
 	<BugPattern abbrev="SPP" type="SPP_USE_CHARAT" category="PERFORMANCE" />
 	<BugPattern abbrev="SPP" type="SPP_USELESS_TRINARY" category="PERFORMANCE" />
 	<BugPattern abbrev="SPP" type="SPP_SUSPECT_STRING_TEST" category="CORRECTNESS" />
+	<BugPattern abbrev="SPP" type="SPP_USE_STRINGBUILDER_LENGTH" category="PERFORMANCE" />
 	<BugPattern abbrev="BAS" type="BAS_BLOATED_ASSIGNMENT_SCOPE" category="PERFORMANCE" />
 	<BugPattern abbrev="SCII" type="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTATOR" category="STYLE" />
 	<BugPattern abbrev="DWI" type="DWI_DELETING_WHILE_ITERATING" category="CORRECTNESS" />

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2007-11-21 13:26:13 UTC (rev 970)
+++ trunk/fb-contrib/etc/messages.xml	2007-11-22 06:23:23 UTC (rev 971)
@@ -1913,6 +1913,18 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SPP_USE_STRINGBUILDER_LENGTH">
+		<ShortDescription>Method converts StringBuffer or Builder to String just to get it's length</ShortDescription>
+		<LongDescription>Method {1} converts StringBuffer or Builder to String just to get it's length</LongDescription>
+		<Details>
+			<![CDATA[
+				<p>This method calls the toString method on a StringBuffer or StringBuilder only to call length() on the resulting
+				string. It is faster, and less memory intensive to just call the length method directly on the StringBuffer or StringBuilder
+				itself.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<BugPattern type="BAS_BLOATED_ASSIGNMENT_SCOPE">
 		<ShortDescription>Method assigns a variable in a larger scope then is needed</ShortDescription>
 		<LongDescription>Method {1} assigns a variable in a larger scope then is needed</LongDescription>

Modified: trunk/fb-contrib/samples/SPP_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SPP_Sample.java	2007-11-21 13:26:13 UTC (rev 970)
+++ trunk/fb-contrib/samples/SPP_Sample.java	2007-11-22 06:23:23 UTC (rev 971)
@@ -156,4 +156,12 @@
             System.out.println("Booya");
         }
     }
+    
+    public void sbToString(StringBuffer sb)
+    {
+    	if (sb.toString().length() == 0)
+    		System.out.println("Booya");
+    	else if (sb.toString().equals(""))
+    		System.out.println("Booya");
+    }
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2007-11-21 13:26:13 UTC (rev 970)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2007-11-22 06:23:23 UTC (rev 971)
@@ -26,10 +26,12 @@
 
 import org.apache.bcel.Repository;
 import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.Constant;
 import org.apache.bcel.classfile.ConstantDouble;
 import org.apache.bcel.classfile.ConstantMethodref;
 import org.apache.bcel.classfile.ConstantNameAndType;
 import org.apache.bcel.classfile.ConstantPool;
+import org.apache.bcel.classfile.ConstantString;
 import org.apache.bcel.classfile.JavaClass;
 import org.apache.bcel.classfile.LocalVariable;
 import org.apache.bcel.classfile.LocalVariableTable;
@@ -149,12 +151,72 @@
 				}
 			}
 			
-			
-			if (seen == IFEQ) {
+			if (seen == IFNE) {
+				byte[] bytes = getCode().getCode();
+				if (lastPCs[2] != -1) {
+					if ((getbyte(bytes, lastPCs[3]) == INVOKEVIRTUAL)
+					&&  (getbyte(bytes, lastPCs[2]) == INVOKEVIRTUAL)) {
+						ConstantPool pool = getConstantPool();
+						int toStringIndex = getshort(bytes, lastPCs[2]+1);
+						ConstantMethodref toStringMR = (ConstantMethodref)pool.getConstant(toStringIndex);
+						String toStringCls = toStringMR.getClass(pool);
+						if (toStringCls.startsWith("java.lang.StringBu")) {
+							int nandtIndex = toStringMR.getNameAndTypeIndex();
+							ConstantNameAndType cnt = (ConstantNameAndType)pool.getConstant(nandtIndex);
+							if ("toString".equals(cnt.getName(pool))) {
+								int lengthIndex = getshort(bytes, lastPCs[3]+1);
+								ConstantMethodref lengthMR = (ConstantMethodref)pool.getConstant(lengthIndex);
+								nandtIndex = lengthMR.getNameAndTypeIndex();
+								cnt = (ConstantNameAndType)pool.getConstant(nandtIndex);
+								if ("length".equals(cnt.getName(pool))) {
+									bugReporter.reportBug(new BugInstance(this, "SPP_USE_STRINGBUILDER_LENGTH", NORMAL_PRIORITY)
+												.addClass(this)
+												.addMethod(this)
+												.addSourceLine(this));
+								}
+							}
+						}
+					}
+				}
+			} else if (seen == IFEQ) {
 				if (stack.getStackDepth() > 0) {
 					OpcodeStack.Item itm = stack.getStackItem(0);
 					lastIfEqWasBoolean = "Z".equals(itm.getElementSignature());
 				}
+				
+				byte[] bytes = getCode().getCode();
+				if (lastPCs[1] != -1) {
+					if ((getbyte(bytes, lastPCs[3]) == INVOKEVIRTUAL)
+					&&  (getbyte(bytes, lastPCs[2]) == LDC)
+					&&  (getbyte(bytes, lastPCs[1]) == INVOKEVIRTUAL)) {
+						ConstantPool pool = getConstantPool();
+						int toStringIndex = getshort(bytes, lastPCs[1]+1);
+						ConstantMethodref toStringMR = (ConstantMethodref)pool.getConstant(toStringIndex);
+						String toStringCls = toStringMR.getClass(pool);
+						if (toStringCls.startsWith("java.lang.StringBu")) {
+							int consIndex = getbyte(bytes, lastPCs[2]+1);
+							Constant c = pool.getConstant(consIndex);
+							if (c instanceof ConstantString) {
+								if ("".equals(((ConstantString) c).getBytes(pool))) {
+									int nandtIndex = toStringMR.getNameAndTypeIndex();
+									ConstantNameAndType cnt = (ConstantNameAndType)pool.getConstant(nandtIndex);
+									if ("toString".equals(cnt.getName(pool))) {
+										int lengthIndex = getshort(bytes, lastPCs[3]+1);
+										ConstantMethodref lengthMR = (ConstantMethodref)pool.getConstant(lengthIndex);
+										nandtIndex = lengthMR.getNameAndTypeIndex();
+										cnt = (ConstantNameAndType)pool.getConstant(nandtIndex);
+										if ("equals".equals(cnt.getName(pool))) {
+											bugReporter.reportBug(new BugInstance(this, "SPP_USE_STRINGBUILDER_LENGTH", NORMAL_PRIORITY)
+														.addClass(this)
+														.addMethod(this)
+														.addSourceLine(this));
+										}
+									}
+								}
+							}
+						}
+					}
+				}
 			} else if ((seen == IRETURN) && lastIfEqWasBoolean) {
 				byte[] bytes = getCode().getCode();
 				if ((lastPCs[0] != -1)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [970] trunk/fb-contrib/samples/LSYC_Sample.java

From: <dbr...@us...> - 2007-11-21 13:26:12

Revision: 970
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=970&view=rev
Author:   dbrosius
Date:     2007-11-21 05:26:13 -0800 (Wed, 21 Nov 2007)

Log Message:
-----------
add test

Modified Paths:
--------------
    trunk/fb-contrib/samples/LSYC_Sample.java

Modified: trunk/fb-contrib/samples/LSYC_Sample.java
===================================================================
--- trunk/fb-contrib/samples/LSYC_Sample.java	2007-11-11 01:43:13 UTC (rev 969)
+++ trunk/fb-contrib/samples/LSYC_Sample.java	2007-11-21 13:26:13 UTC (rev 970)
@@ -42,4 +42,13 @@
 		return main;
 		
 	}
+	
+	public String printString()
+	{
+		StringBuffer buffer = new StringBuffer();
+		for(int i=0; i<50; i++)
+			buffer.append ("Findbugs ");
+		return buffer.toString ();
+	}
+
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [969] trunk/fb-contrib/samples/SMII_Sample.java

From: <dbr...@us...> - 2007-11-11 01:43:12

Revision: 969
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=969&view=rev
Author:   dbrosius
Date:     2007-11-10 17:43:13 -0800 (Sat, 10 Nov 2007)

Log Message:
-----------
new fp

Modified Paths:
--------------
    trunk/fb-contrib/samples/SMII_Sample.java

Modified: trunk/fb-contrib/samples/SMII_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SMII_Sample.java	2007-11-10 03:31:23 UTC (rev 968)
+++ trunk/fb-contrib/samples/SMII_Sample.java	2007-11-11 01:43:13 UTC (rev 969)
@@ -63,8 +63,14 @@
     public void testFPInstance(SMII_Sample sample)
     {
     	SMII_Sample.testInstanceAsFirstParm(sample, "");
-    	SMII_Sample.testInstanceAsFirstParm(sample, "");
+    	SMII_Sample.testInstanceAsFirstParm("");
     }
+    
+    public static SMII_Sample testInstanceAsFirstParm(String s1)
+    {
+    	return new SMII_Sample();
+    }
+    
     public static SMII_Sample testInstanceAsFirstParm(SMII_Sample sample, String s1)
     {
     	return sample;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [968] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/ConfusingFunctionSemantics.java

From: <dbr...@us...> - 2007-11-10 03:31:19

Revision: 968
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=968&view=rev
Author:   dbrosius
Date:     2007-11-09 19:31:23 -0800 (Fri, 09 Nov 2007)

Log Message:
-----------
better engrish

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-10 03:30:12 UTC (rev 967)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2007-11-10 03:31:23 UTC (rev 968)
@@ -39,7 +39,7 @@
 import edu.umd.cs.findbugs.ba.ClassContext;
 
 /** looks for methods that return a parameter after making what looks like
- * modifications to that parameter. This leads to confusing on the user of this
+ * modifications to that parameter. This leads to confusion for the user of this
  * method as it isn't obvious that the 'original' object is modified. If the
  * point of this method is to modify the parameter, it is probably better just
  * to have the method be a void method, to avoid confusion.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib: [967] trunk/fb-contrib/htdocs/index.html

From: <dbr...@us...> - 2007-11-10 03:30:08

Revision: 967
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=967&view=rev
Author:   dbrosius
Date:     2007-11-09 19:30:12 -0800 (Fri, 09 Nov 2007)

Log Message:
-----------
better engrish

Modified Paths:
--------------
    trunk/fb-contrib/htdocs/index.html

Modified: trunk/fb-contrib/htdocs/index.html
===================================================================
--- trunk/fb-contrib/htdocs/index.html	2007-11-10 03:26:09 UTC (rev 966)
+++ trunk/fb-contrib/htdocs/index.html	2007-11-10 03:30:12 UTC (rev 967)
@@ -54,7 +54,7 @@
 			<ul>
 				<li><b>[CFS] Confusing Function Semantics</b><br/>
 				Looks for methods that return a parameter after making what looks like
-				modifications to that parameter. This leads to confusing on the user of this
+				modifications to that parameter. This leads to confusion for the user of this
 				method as it isn't obvious that the 'original' object is modified. If the
 				point of this method is to modify the parameter, it is probably better just
 				to have the method be a void method, to avoid confusion.</li>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

Flat | Threaded

<< < 1 .. 33 34 35 36 37 .. 77 > >> (Page 35 of 77)