fb-contrib-commit Mailing List for fb-contrib (Page 31)

Brought to you by: dbrosius

fb-contrib-commit — Log for cvs commits of fb-contrib code

You can subscribe to this list here.

2005	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep (56)	Oct (60)	Nov (58)	Dec (89)
2006	Jan (66)	Feb (55)	Mar (85)	Apr (115)	May (35)	Jun (28)	Jul (3)	Aug (48)	Sep (37)	Oct (22)	Nov (14)	Dec (66)
2007	Jan (45)	Feb (63)	Mar (10)	Apr (1)	May (1)	Jun (12)	Jul	Aug	Sep (25)	Oct (21)	Nov (39)	Dec
2008	Jan (7)	Feb	Mar (26)	Apr (5)	May (2)	Jun (32)	Jul (9)	Aug (10)	Sep	Oct (3)	Nov (1)	Dec
2009	Jan (10)	Feb (31)	Mar (32)	Apr (35)	May (25)	Jun	Jul (31)	Aug (10)	Sep (95)	Oct (35)	Nov (10)	Dec (34)
2010	Jan (90)	Feb (4)	Mar (7)	Apr (20)	May (20)	Jun (13)	Jul (7)	Aug (18)	Sep (25)	Oct (4)	Nov (16)	Dec (2)
2011	Jan (1)	Feb	Mar (11)	Apr (3)	May (2)	Jun (26)	Jul (10)	Aug (2)	Sep	Oct (1)	Nov (1)	Dec (1)
2012	Jan (3)	Feb (4)	Mar	Apr	May	Jun	Jul (1)	Aug	Sep	Oct (14)	Nov (3)	Dec (4)
2013	Jan (3)	Feb (2)	Mar (1)	Apr (4)	May	Jun (1)	Jul (3)	Aug	Sep	Oct (4)	Nov (3)	Dec (3)
2014	Jan (4)	Feb (2)	Mar (4)	Apr (1)	May (2)	Jun	Jul (2)	Aug	Sep	Oct	Nov	Dec
2015	Jan	Feb	Mar	Apr	May (4)	Jun	Jul	Aug (3)	Sep	Oct	Nov (3)	Dec (3)
2016	Jan (2)	Feb	Mar	Apr (2)	May	Jun	Jul (1)	Aug (2)	Sep (4)	Oct (2)	Nov (7)	Dec
2017	Jan (1)	Feb	Mar (4)	Apr (5)	May (2)	Jun	Jul (2)	Aug	Sep (4)	Oct	Nov	Dec (3)
2018	Jan	Feb	Mar (2)	Apr	May (5)	Jun (2)	Jul (2)	Aug	Sep	Oct	Nov	Dec

Flat | Threaded

<< < 1 .. 29 30 31 32 33 .. 77 > >> (Page 31 of 77)

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1091] trunk/fb-contrib

From: <dbr...@us...> - 2009-02-14 16:52:02

Revision: 1091
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1091&view=rev
Author:   dbrosius
Date:     2009-02-14 16:51:59 +0000 (Sat, 14 Feb 2009)

Log Message:
-----------
go back to 3.7.0 dev

Modified Paths:
--------------
    trunk/fb-contrib/build.xml
    trunk/fb-contrib/etc/findbugs.xml

Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml	2009-02-14 16:37:21 UTC (rev 1090)
+++ trunk/fb-contrib/build.xml	2009-02-14 16:51:59 UTC (rev 1091)
@@ -20,7 +20,7 @@
 	<property name="javac.deprecation" value="on"/>
 	<property name="javac.debug" value="on"/>
 	
-	<property name="fb-contrib.version" value="3.6.2"/>
+	<property name="fb-contrib.version" value="3.7.0"/>
 	
 	<target name="clean" description="removes all generated collateral">
 		<delete dir="${classes.dir}"/>

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2009-02-14 16:37:21 UTC (rev 1090)
+++ trunk/fb-contrib/etc/findbugs.xml	2009-02-14 16:51:59 UTC (rev 1091)
@@ -318,13 +318,11 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousClusteredSessionSupport"
 			speed="fast"
-			reports="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" 
-			hidden="true" />
+			reports="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.LoggerOddities"
 			speed="fast"
-			reports="LO_SUSPECT_LOG_CLASS" 
-			hidden="true" />
+			reports="LO_SUSPECT_LOG_CLASS" />
 			
    	<!-- BugPattern -->
 	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1090] tags/v3_6_2/

From: <dbr...@us...> - 2009-02-14 16:37:24

Revision: 1090
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1090&view=rev
Author:   dbrosius
Date:     2009-02-14 16:37:21 +0000 (Sat, 14 Feb 2009)

Log Message:
-----------
tag 3.6.2

Added Paths:
-----------
    tags/v3_6_2/


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1089] trunk/fb-contrib

From: <dbr...@us...> - 2009-02-14 16:33:30

Revision: 1089
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1089&view=rev
Author:   dbrosius
Date:     2009-02-14 16:33:26 +0000 (Sat, 14 Feb 2009)

Log Message:
-----------
prepare for a 3.6.2 release

Modified Paths:
--------------
    trunk/fb-contrib/build.xml
    trunk/fb-contrib/etc/findbugs.xml

Modified: trunk/fb-contrib/build.xml
===================================================================
--- trunk/fb-contrib/build.xml	2009-02-14 16:30:31 UTC (rev 1088)
+++ trunk/fb-contrib/build.xml	2009-02-14 16:33:26 UTC (rev 1089)
@@ -20,7 +20,7 @@
 	<property name="javac.deprecation" value="on"/>
 	<property name="javac.debug" value="on"/>
 	
-	<property name="fb-contrib.version" value="3.7.0"/>
+	<property name="fb-contrib.version" value="3.6.2"/>
 	
 	<target name="clean" description="removes all generated collateral">
 		<delete dir="${classes.dir}"/>

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2009-02-14 16:30:31 UTC (rev 1088)
+++ trunk/fb-contrib/etc/findbugs.xml	2009-02-14 16:33:26 UTC (rev 1089)
@@ -318,11 +318,13 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousClusteredSessionSupport"
 			speed="fast"
-			reports="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" />
+			reports="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" 
+			hidden="true" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.LoggerOddities"
 			speed="fast"
-			reports="LO_SUSPECT_LOG_CLASS" />
+			reports="LO_SUSPECT_LOG_CLASS" 
+			hidden="true" />
 			
    	<!-- BugPattern -->
 	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1088] trunk/fb-contrib

From: <dbr...@us...> - 2009-02-14 16:30:34

Revision: 1088
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1088&view=rev
Author:   dbrosius
Date:     2009-02-14 16:30:31 +0000 (Sat, 14 Feb 2009)

Log Message:
-----------
add check for System.getProperties().getProperty("foo")

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/samples/SPP_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2009-02-14 05:08:05 UTC (rev 1087)
+++ trunk/fb-contrib/etc/findbugs.xml	2009-02-14 16:30:31 UTC (rev 1088)
@@ -256,7 +256,7 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SillynessPotPourri"
 			speed="fast"
-			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY,SPP_USE_ISEMPTY" />
+			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY,SPP_USE_ISEMPTY,SPP_USE_GETPROPERTY" />
 		
 	<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope"
 			speed="fast"
@@ -413,6 +413,7 @@
 	<BugPattern abbrev="SPP" type="SPP_INVALID_CALENDAR_COMPARE" category="CORRECTNESS"/>
 	<BugPattern abbrev="SPP" type="SPP_USE_CONTAINSKEY" category="STYLE"/>
 	<BugPattern abbrev="SPP" type="SPP_USE_ISEMPTY" category="STYLE"/>
+	<BugPattern abbrev="SPP" type="SPP_USE_GETPROPERTY" category="STYLE"/>
 	<BugPattern abbrev="BAS" type="BAS_BLOATED_ASSIGNMENT_SCOPE" category="PERFORMANCE" />
 	<BugPattern abbrev="SCII" type="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTATOR" category="STYLE" />
 	<BugPattern abbrev="DWI" type="DWI_DELETING_WHILE_ITERATING" category="CORRECTNESS" />

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2009-02-14 05:08:05 UTC (rev 1087)
+++ trunk/fb-contrib/etc/messages.xml	2009-02-14 16:30:31 UTC (rev 1088)
@@ -2037,6 +2037,21 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SPP_USE_GETPROPERTY">
+		<ShortDescription>Method calls getProperties just to get one property, use getProperty instead</ShortDescription>
+		<LongDescription>Method {1} calls getProperties just to get one property, use getProperty instead</LongDescription>
+		<Details>
+			<![CDATA[
+				<table>
+					<tr><td>This method uses</td></tr>
+					<tr><td>String prop = System.getProperties().getProperty("foo");</td></tr
+					<tr><td>instead of simply using</td></tr>
+					<tr><td>String prop = System.getProperty("foo");</td></tr>
+				</table>
+			]]>	
+		</Details>				
+	</BugPattern>
+	
 	<BugPattern type="BAS_BLOATED_ASSIGNMENT_SCOPE">
 		<ShortDescription>Method assigns a variable in a larger scope then is needed</ShortDescription>
 		<LongDescription>Method {1} assigns a variable in a larger scope then is needed</LongDescription>

Modified: trunk/fb-contrib/samples/SPP_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SPP_Sample.java	2009-02-14 05:08:05 UTC (rev 1087)
+++ trunk/fb-contrib/samples/SPP_Sample.java	2009-02-14 16:30:31 UTC (rev 1088)
@@ -2,6 +2,7 @@
 import java.util.BitSet;
 import java.util.Calendar;
 import java.util.Date;
+import java.util.GregorianCalendar;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.Map;
@@ -202,4 +203,17 @@
     	if (s.size() == 0)
     		System.out.println("empty");
     }
+    
+    public boolean testDerivedGregorianCalendar()
+    {
+    	Calendar c = new GregorianCalendar() {};
+    	Calendar s = new GregorianCalendar();
+    	
+    	return s.after(c);
+    }
+    
+    public void testGetProperties()
+    {
+    	String lf = System.getProperties().getProperty("line.separator");
+    }
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-02-14 05:08:05 UTC (rev 1087)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-02-14 16:30:31 UTC (rev 1088)
@@ -358,6 +358,13 @@
 									.addSourceLine(this));
 					}
 				}
+			} else if (seen == INVOKESTATIC) {
+				String className = getClassConstantOperand();
+				String methodName = getNameConstantOperand();
+				if ("java/lang/System".equals(className)) {
+	            	if ("getProperties".equals(methodName))
+	            		userValue = "getProperties";
+				}
 			} else if (seen == INVOKEVIRTUAL) {
 				String className = getClassConstantOperand();
 				String methodName = getNameConstantOperand();
@@ -457,6 +464,18 @@
                 			
                 		}
                 	}
+                } else if ("java/util/Properties".equals(className)) {
+                	if (("get".equals(methodName) || "getProperty".equals(methodName))) {
+                		if (stack.getStackDepth() > 1) {
+                			OpcodeStack.Item item = stack.getStackItem(1);
+                			if ("getProperties".equals(item.getUserValue())) {
+                				bugReporter.reportBug(new BugInstance(this, "SPP_USE_GETPROPERTY", NORMAL_PRIORITY)
+                				           .addClass(this)
+                				           .addMethod(this)
+                				           .addSourceLine(this));
+                			}
+                		}
+                	}
                 }
 			} else if (seen == INVOKESPECIAL) {
 				String className = getClassConstantOperand();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1087] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/LostExceptionStackTrace.java

From: <dbr...@us...> - 2009-02-14 05:08:10

Revision: 1087
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1087&view=rev
Author:   dbrosius
Date:     2009-02-14 05:08:05 +0000 (Sat, 14 Feb 2009)

Log Message:
-----------
fix for [ 2494245 ] LEST False Positive

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2009-01-26 07:32:48 UTC (rev 1086)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2009-02-14 05:08:05 UTC (rev 1087)
@@ -35,6 +35,7 @@
 import org.apache.bcel.classfile.LocalVariable;
 import org.apache.bcel.classfile.LocalVariableTable;
 import org.apache.bcel.classfile.Method;
+import org.apache.bcel.generic.Type;
 
 import com.mebigfatguy.fbcontrib.utils.Integer14;
 import com.mebigfatguy.fbcontrib.utils.RegisterUtils;
@@ -61,7 +62,7 @@
 		}
 	}
 	
-	private BugReporter bugReporter;
+	private final BugReporter bugReporter;
 	private OpcodeStack stack;
 	private CodeException[] exceptions;
 	private Set<CatchInfo> catchInfos;
@@ -173,7 +174,6 @@
                     }
 				} else if (pc == ex.getHandlerPC()) {
                     removePreviousHandlers(pc);
-                    
                 }
 			}
 			
@@ -189,16 +189,20 @@
 						it.remove();
 						break;
 					} else if ((pc > catchInfo.getStart()) && (pc <= catchInfo.getFinish())) {
-						if ((seen == INVOKESPECIAL) && ("<init>".equals(getNameConstantOperand()))) {
-							String className = getClassConstantOperand();
-							JavaClass exClass = Repository.lookupClass(className);
-							if (exClass.instanceOf(throwableClass)) {
-								String sig = getSigConstantOperand();
-								if ((sig.indexOf("Exception") >= 0)
-								||  (sig.indexOf("Throwable") >= 0)) {
-									markAsValid = true;
-									break;
+						if (seen == INVOKESPECIAL) {
+							if ("<init>".equals(getNameConstantOperand())) {
+								String className = getClassConstantOperand();
+								JavaClass exClass = Repository.lookupClass(className);
+								if (exClass.instanceOf(throwableClass)) {
+									String sig = getSigConstantOperand();
+									if ((sig.indexOf("Exception") >= 0)
+									||  (sig.indexOf("Throwable") >= 0)) {
+										markAsValid = true;
+										break;
+									}
 								}
+							} else if (isPossibleExBuilder(catchInfo.getRegister())) {
+								markAsValid = true;
 							}
 						} else if (seen == INVOKEVIRTUAL) {
                             if ("initCause".equals(getNameConstantOperand())) {
@@ -215,7 +219,12 @@
     							}
                             } else if ("getTargetException".equals(getNameConstantOperand()) && "java/lang/reflect/InvocationTargetException".equals(getClassConstantOperand())) {
                                 markAsValid = true;
-                            }
+							} else if (isPossibleExBuilder(catchInfo.getRegister())) {
+								markAsValid = true;
+							}
+						} else if (seen == INVOKEINTERFACE) {
+							if (isPossibleExBuilder(catchInfo.getRegister()))
+								markAsValid = true;
 						} else if (seen == ATHROW) {
 							if (stack.getStackDepth() > 0) {
 								OpcodeStack.Item itm = stack.getStackItem(0);
@@ -264,6 +273,33 @@
 		}
 	}
 	
+	/** returns whether the method called might be a method that builds an exception using
+	 * the original exception. It does so by looking to see if the method returns an exception,
+	 * and if one of the parameters is the original exception
+	 * @param exReg the register of the original exception caught
+	 * @return whether this method call could be an exception builder method
+	 */
+	public boolean isPossibleExBuilder(int exReg) throws ClassNotFoundException {
+		String sig = getSigConstantOperand();
+		Type returnType = Type.getReturnType(sig);
+		String returnSig = returnType.getSignature();
+		if (returnSig.startsWith("L")) {
+			returnSig = returnSig.substring(1, returnSig.length() - 1);
+			JavaClass retCls = Repository.lookupClass(returnSig);
+			if (retCls.instanceOf(throwableClass)) {
+				int numParms = Type.getArgumentTypes(sig).length;
+				if (stack.getStackDepth() >= numParms) {
+					for (int p = 0; p < numParms; p++) {
+						OpcodeStack.Item item = stack.getStackItem(p);
+						if (item.getRegisterNumber() == exReg)
+							return true;
+					}
+				}
+			}
+		}
+		return false;
+	}
+	
     /** returns whether the class in question was compiled with a jdk less than 1.4
      * 
      * @param exClass the class to check
@@ -329,7 +365,7 @@
 	}
 	
 	private static class CatchInfo {
-		private int catchStart;
+		private final int catchStart;
 		private int catchFinish;
 		private int exReg;
 		


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1086] trunk/fb-contrib/samples/COM_Sample.java

From: <dbr...@us...> - 2009-01-26 07:32:52

Revision: 1086
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1086&view=rev
Author:   dbrosius
Date:     2009-01-26 07:32:48 +0000 (Mon, 26 Jan 2009)

Log Message:
-----------
add reported test case, even if not duplicatable

Modified Paths:
--------------
    trunk/fb-contrib/samples/COM_Sample.java

Modified: trunk/fb-contrib/samples/COM_Sample.java
===================================================================
--- trunk/fb-contrib/samples/COM_Sample.java	2009-01-26 07:23:26 UTC (rev 1085)
+++ trunk/fb-contrib/samples/COM_Sample.java	2009-01-26 07:32:48 UTC (rev 1086)
@@ -44,5 +44,21 @@
 		{
 			return String.valueOf(i);
 		}
-	}
+	}	
 }
+
+interface Inf
+{
+	void m1();
+	void m2();
+}
+
+abstract class c1 implements Inf
+{
+	public void m1() {}
+}
+
+abstract class c2 extends c1
+{
+	public void m2() {}
+}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1085] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UseEnumCollections.java

From: <dbr...@us...> - 2009-01-26 07:23:32

Revision: 1085
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1085&view=rev
Author:   dbrosius
Date:     2009-01-26 07:23:26 +0000 (Mon, 26 Jan 2009)

Log Message:
-----------
fix [ 2308417 ] FalsePositive UEC_USE_ENUM_COLLECTIONS

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2009-01-20 05:25:09 UTC (rev 1084)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2009-01-26 07:23:26 UTC (rev 1085)
@@ -52,7 +52,7 @@
 		nonEnumCollections.add("Ljava/util/IdentityHashMap;");
 		nonEnumCollections.add("Ljava/util/WeakHashMap;");
 	}
-	private BugReporter bugReporter;
+	private final BugReporter bugReporter;
 	private OpcodeStack stack;
 	private Set<String> checkedFields;
 	private Map<Integer, Boolean> enumRegs;
@@ -188,6 +188,7 @@
 	
 	/**
 	 * returns whether the item at the stackPos location on the stack
+	 * is an enum, and doesn't implement any interfaces
 	 * 
 	 * @param stackPos the position on the opstack to check
 	 * 
@@ -197,9 +198,19 @@
 	private boolean isEnum(int stackPos) throws ClassNotFoundException {
 		if (stack.getStackDepth() > stackPos) {
 			OpcodeStack.Item item = stack.getStackItem(stackPos);
-			if (item.getSignature().charAt(0) == 'L')
-				return (item.getJavaClass().isEnum());	
+			if (item.getSignature().charAt(0) != 'L')
+				return false;
+			
+			JavaClass cls =  item.getJavaClass();
+			if (!cls.isEnum())
+				return false;
+			
+			//If the cls implements any interface, it's possible the collection
+			//is based on that interface, so ignore
+			if (cls.getInterfaces().length == 0)
+				return true;
 		}
+		
 		return false;
 	}
 	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1084] trunk/fb-contrib/samples/LEST_Sample.java

From: <dbr...@us...> - 2009-01-20 05:25:12

Revision: 1084
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1084&view=rev
Author:   dbrosius
Date:     2009-01-20 05:25:09 +0000 (Tue, 20 Jan 2009)

Log Message:
-----------
add test for 2494245

Modified Paths:
--------------
    trunk/fb-contrib/samples/LEST_Sample.java

Modified: trunk/fb-contrib/samples/LEST_Sample.java
===================================================================
--- trunk/fb-contrib/samples/LEST_Sample.java	2009-01-20 03:52:10 UTC (rev 1083)
+++ trunk/fb-contrib/samples/LEST_Sample.java	2009-01-20 05:25:09 UTC (rev 1084)
@@ -72,4 +72,21 @@
 		}
 		throw new RuntimeException("ok");
 	}
+	
+	public void testLestFP4(String s) throws Exception
+	{
+		double d;
+		try
+		{
+			d = Double.parseDouble(s);
+		}
+		catch (NumberFormatException nfe)
+		{
+			throw wrap(nfe);
+		}
+	}
+	
+	private Exception wrap(Exception e) {
+		return new Exception(e);
+	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1083] trunk/fb-contrib/samples/USBR_Sample.java

From: <dbr...@us...> - 2009-01-20 03:52:13

Revision: 1083
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1083&view=rev
Author:   dbrosius
Date:     2009-01-20 03:52:10 +0000 (Tue, 20 Jan 2009)

Log Message:
-----------
Fix bug  2520040 - don't report store and returns on catch variables

Modified Paths:
--------------
    trunk/fb-contrib/samples/USBR_Sample.java

Modified: trunk/fb-contrib/samples/USBR_Sample.java
===================================================================
--- trunk/fb-contrib/samples/USBR_Sample.java	2009-01-20 03:48:54 UTC (rev 1082)
+++ trunk/fb-contrib/samples/USBR_Sample.java	2009-01-20 03:52:10 UTC (rev 1083)
@@ -7,7 +7,7 @@
 		int sum = 0;
 		for (String s : tokens)
 		{
-			sum += Integer.valueOf(s);
+			sum += Integer.parseInt(s);
 		}
 		
 		int ave = sum / tokens.length;
@@ -28,4 +28,17 @@
 		}
 		return i;
 	}
+	
+	public Exception fpReturnException(String num)
+	{
+		try
+		{
+			int i = Integer.parseInt(num);
+			return null;
+		}
+		catch (Exception e)
+		{
+			return e;
+		}
+	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1082] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/UnnecessaryStoreBeforeReturn.java

From: <dbr...@us...> - 2009-01-20 03:49:00

Revision: 1082
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1082&view=rev
Author:   dbrosius
Date:     2009-01-20 03:48:54 +0000 (Tue, 20 Jan 2009)

Log Message:
-----------
Fix bug  2520040 - don't report store and returns on catch variables

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java	2009-01-20 03:16:37 UTC (rev 1081)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java	2009-01-20 03:48:54 UTC (rev 1082)
@@ -22,6 +22,7 @@
 import java.util.Set;
 
 import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.CodeException;
 import org.apache.bcel.classfile.Method;
 import org.apache.bcel.generic.Type;
 
@@ -63,8 +64,9 @@
 		branchInstructions.add(Integer14.valueOf(IFNONNULL));
 	}
 	
-	private BugReporter bugReporter;
+	private final BugReporter bugReporter;
 	private Set<Integer> branchTargets;
+	private Set<Integer> catchTargets;
 	private int state;
 	private int storeReg;
 	
@@ -85,9 +87,11 @@
 	public void visitClassContext(ClassContext classContext) {
 		try {
 			branchTargets = new HashSet<Integer>();
+			catchTargets = new HashSet<Integer>();
 			super.visitClassContext(classContext);
 		} finally {
 			branchTargets = null;
+			catchTargets = null;
 		}
 	}
 	/**
@@ -103,6 +107,13 @@
 		if (!t.equals(Type.VOID)) {
 			state = SEEN_NOTHING;
 			branchTargets.clear();
+			CodeException[] ces = obj.getExceptionTable();
+			catchTargets.clear();
+			for (CodeException ce : ces) {
+				if (ce.getCatchType() != 0) {
+					catchTargets.add(Integer14.valueOf(ce.getHandlerPC()));
+				}
+			}
 			super.visitCode(obj);
 		}
 	}
@@ -117,8 +128,10 @@
 	public void sawOpcode(int seen) {
         switch (state) {
 			case SEEN_NOTHING:
-				if (lookForStore(seen))
-					state = SEEN_STORE;
+				if (!catchTargets.contains(Integer14.valueOf(getPC()))) {
+					if (lookForStore(seen))
+						state = SEEN_STORE;
+				}
 			break;
 			
 			case SEEN_STORE:


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1081] trunk/fb-contrib/samples/UEC_Sample.java

From: <dbr...@us...> - 2009-01-20 03:16:43

Revision: 1081
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1081&view=rev
Author:   dbrosius
Date:     2009-01-20 03:16:37 +0000 (Tue, 20 Jan 2009)

Log Message:
-----------
add test case to represent bug 2308417

Modified Paths:
--------------
    trunk/fb-contrib/samples/UEC_Sample.java

Modified: trunk/fb-contrib/samples/UEC_Sample.java
===================================================================
--- trunk/fb-contrib/samples/UEC_Sample.java	2009-01-18 07:25:34 UTC (rev 1080)
+++ trunk/fb-contrib/samples/UEC_Sample.java	2009-01-20 03:16:37 UTC (rev 1081)
@@ -11,9 +11,13 @@
 	public enum Suite { Spades, Hearts, Clubs, Diamonds };
 	public enum FalsePositive { A, B, C };
 	
-	private Set<Suite> wildSuites = new HashSet<Suite>();
-	private EnumSet<Suite> eWildSuites = EnumSet.noneOf(Suite.class);
+	private final Set<Suite> wildSuites = new HashSet<Suite>();
+	private final EnumSet<Suite> eWildSuites = EnumSet.noneOf(Suite.class);
 	
+	private interface EnumStub {}
+	
+	public enum EnumWithInf implements EnumStub { A, B, C };
+	
 	public UEC_Sample()
 	{
 		wildSuites.add(Suite.Spades);
@@ -60,4 +64,12 @@
 		
 		suites.add(Suite.Clubs);
 	}
+	
+	public void fpEnumsWithInf()
+	{
+		Set<EnumStub> es = new HashSet<EnumStub>();
+		es.add(EnumWithInf.A);
+		es.add(EnumWithInf.B);
+		es.add(EnumWithInf.C);
+	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1080] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SillynessPotPourri.java

From: <dbr...@us...> - 2009-01-18 07:25:42

Revision: 1080
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1080&view=rev
Author:   dbrosius
Date:     2009-01-18 07:25:34 +0000 (Sun, 18 Jan 2009)

Log Message:
-----------
Calendar is a class, use instanceOf

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-01-18 07:20:48 UTC (rev 1079)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-01-18 07:25:34 UTC (rev 1080)
@@ -445,7 +445,7 @@
                 		if (!"Ljava/lang/Object;".equals(itemSig) && !"Ljava/util/Calendar;".equals(itemSig) && !"Ljava/util/GregorianCalendar;".equals(itemSig)) {
                 			try {
                 				JavaClass cls = Repository.lookupClass(itemSig.substring(1, itemSig.length() - 1));
-                				if (!cls.implementationOf(calendarClass)) {
+                				if (!cls.instanceOf(calendarClass)) {
                 					bugReporter.reportBug(new BugInstance(this, "SPP_INVALID_CALENDAR_COMPARE", NORMAL_PRIORITY)
 			                					.addClass(this)
 			                					.addMethod(this)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1079] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SillynessPotPourri.java

From: <dbr...@us...> - 2009-01-18 07:20:59

Revision: 1079
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1079&view=rev
Author:   dbrosius
Date:     2009-01-18 07:20:48 +0000 (Sun, 18 Jan 2009)

Log Message:
-----------
oops use slashes

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-01-18 07:11:31 UTC (rev 1078)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-01-18 07:20:48 UTC (rev 1079)
@@ -65,7 +65,7 @@
 	private static JavaClass calendarClass;
 	static {
 		try {
-			calendarClass = Repository.lookupClass("java/util.Calendar");
+			calendarClass = Repository.lookupClass("java/util/Calendar");
 		} catch (ClassNotFoundException cnfe) {
 			calendarClass = null;
 		}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1078] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SillynessPotPourri.java

From: <dbr...@us...> - 2009-01-18 07:11:37

Revision: 1078
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1078&view=rev
Author:   dbrosius
Date:     2009-01-18 07:11:31 +0000 (Sun, 18 Jan 2009)

Log Message:
-----------
don't report classes that implement calendar, other than GregorianCalendar - as odd as that is

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-01-02 02:10:49 UTC (rev 1077)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-01-18 07:11:31 UTC (rev 1078)
@@ -62,6 +62,15 @@
 		collectionInterfaces.add("java/util/SortedMap");
 	}
 	
+	private static JavaClass calendarClass;
+	static {
+		try {
+			calendarClass = Repository.lookupClass("java/util.Calendar");
+		} catch (ClassNotFoundException cnfe) {
+			calendarClass = null;
+		}
+	}
+	
 	private final BugReporter bugReporter;
 	private OpcodeStack stack;
 	private int lastPCs[];
@@ -434,10 +443,18 @@
                 		String itemSig = item.getSignature();
                 		//Rule out java.lang.Object as mergeJumps can throw away type info (BUG)
                 		if (!"Ljava/lang/Object;".equals(itemSig) && !"Ljava/util/Calendar;".equals(itemSig) && !"Ljava/util/GregorianCalendar;".equals(itemSig)) {
-                			bugReporter.reportBug(new BugInstance(this, "SPP_INVALID_CALENDAR_COMPARE", NORMAL_PRIORITY)
-                					.addClass(this)
-                					.addMethod(this)
-                					.addSourceLine(this));
+                			try {
+                				JavaClass cls = Repository.lookupClass(itemSig.substring(1, itemSig.length() - 1));
+                				if (!cls.implementationOf(calendarClass)) {
+                					bugReporter.reportBug(new BugInstance(this, "SPP_INVALID_CALENDAR_COMPARE", NORMAL_PRIORITY)
+			                					.addClass(this)
+			                					.addMethod(this)
+			                					.addSourceLine(this));
+                				}	
+                			} catch (ClassNotFoundException cnfe) {
+                				bugReporter.reportMissingClass(cnfe);
+                			}
+                			
                 		}
                 	}
                 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1077] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib

From: <dbr...@us...> - 2009-01-02 02:10:56

Revision: 1077
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1077&view=rev
Author:   dbrosius
Date:     2009-01-02 02:10:49 +0000 (Fri, 02 Jan 2009)

Log Message:
-----------
update copyright to 2009

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousClusteredSessionSupport.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/CodeByteUtils.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/RegisterUtils.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/SignatureUtils.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/VersionTransition.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/FBContrib.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/CollectStatistics.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/collect/Statistics.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbnormalFinallyBlockReturn.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractClassEmptyMethods.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/AbstractOverriddenMethod.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayBasedCollections.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ArrayWrappedCallByReference.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedAssignmentScope.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/BloatedSynchronizedBlock.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ClassEnvy.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingAutoboxedOverloading.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConfusingFunctionSemantics.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ConstantListIndex.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CopiedOverriddenMethod.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CustomBuiltXML.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/CyclomaticComplexity.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DateComparison.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeclaredRuntimeException.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DubiousListCollection.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ExceptionSoftening.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FieldCouldBeLocal.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FinalParameters.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/FloatingPointLoops.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InefficientStringBuffering.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/InheritanceTypeChecking.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JDBCVendorReliance.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ListIndexedIterating.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LiteralStringComparison.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LocalSynchronizedCollection.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LostExceptionStackTrace.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ManualArrayCopy.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/MethodReturnsConstant.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessAutoboxing.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessCustomSerialization.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessInstanceRetrieval.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NeedlessMemberCollectionSynchronization.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonCollectionMethodUse.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonOwnedSynchronization.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/NonRecycleableTaglibs.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OrphanedDOMNode.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/OverlyConcreteParameter.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/ParallelLists.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PartiallyConstructedObjectAccess.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleIncompleteSerialization.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossibleMemoryBloat.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/PossiblyRedundantMethodCalls.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SQLInLoop.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/Section508Compliance.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SloppyClassReflection.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SluggishGui.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpoiledChildInterfaceImplementor.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SpuriousThreadStates.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticArrayCreatedInMethod.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/StaticMethodInstanceInvocation.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousCloneAlgorithm.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousClusteredSessionSupport.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousClusteredSessionSupport.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousClusteredSessionSupport.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousComparatorReturnValues.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousJDKVersionUse.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SuspiciousWaitOnConcurrentObject.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SyncCollectionIterators.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/TailRecursion.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnnecessaryStoreBeforeReturn.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedCollectionContents.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UnrelatedReturnValues.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseAddAll.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseCharacterParameterizedMethod.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseEnumCollections.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseSplit.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/UseToArray.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/WeakExceptionMessaging.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/CodeByteUtils.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/CodeByteUtils.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/CodeByteUtils.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/Integer14.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Java programs
- * Copyright (C) 2005-2008 Dave Brosius
+ * Copyright (C) 2005-2009 Dave Brosius
  * 
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java	2008-11-03 07:14:49 UTC (rev 1076)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/utils/MapEntry.java	2009-01-02 02:10:49 UTC (rev 1077)
@@ -1,6 +1,6 @@
 /*
  * fb-contrib - Auxiliary detectors for Jav...
 
[truncated message content]

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1076] trunk/fb-contrib

From: <dbr...@us...> - 2008-11-03 07:14:52

Revision: 1076
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1076&view=rev
Author:   dbrosius
Date:     2008-11-03 07:14:49 +0000 (Mon, 03 Nov 2008)

Log Message:
-----------
embellish JAO with tests for Assert.assertNotNull(i) or Assert.assertNotNull(d == 4.3)

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/samples/JAO_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2008-10-30 15:55:38 UTC (rev 1075)
+++ trunk/fb-contrib/etc/findbugs.xml	2008-11-03 07:14:49 UTC (rev 1076)
@@ -306,7 +306,7 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.JUnitAssertionOddities"
 			speed="fast"
-			reports="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT,JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE,JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" />
+			reports="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT,JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE,JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT,JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL" />
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SuspiciousCloneAlgorithm"
 			speed="fast"
@@ -430,6 +430,7 @@
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_ACTUAL_CONSTANT" category="STYLE" />
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_INEXACT_DOUBLE" category="STYLE" />
 	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODDITIES_BOOLEAN_ASSERT" category="STYLE" />
+	<BugPattern abbrev="JAO" type="JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL" category="CORRECTNESS" />
 	<BugPattern abbrev="SCA" type="SCA_SUSPICIOUS_CLONE_ALGORITHM" category="CORRECTNESS" />
 	<BugPattern abbrev="WEM" type="WEM_WEAK_EXCEPTION_MESSAGING" category="STYLE" />
 	<BugPattern abbrev="SCSS" type="SCSS_SUSPICIOUS_CLUSTERED_SESSION_SUPPORT" category="CORRECTNESS" experimental="true" />

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2008-10-30 15:55:38 UTC (rev 1075)
+++ trunk/fb-contrib/etc/messages.xml	2008-11-03 07:14:49 UTC (rev 1076)
@@ -2261,6 +2261,18 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL">
+		<ShortDescription>method asserts that an auto-boxed value is not null</ShortDescription>
+		<LongDescription>method {1} asserts that an auto-boxed value is not null</LongDescription>
+		<Details>
+			<![CDATA[
+			<p>This method asserts that a primitive value that was autoboxed into a boxed primitive was not 
+			null. This will never happen, as primitives are never null, and thus the autoboxed value isn't 
+			either.</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<BugPattern type="SCA_SUSPICIOUS_CLONE_ALGORITHM">
 		<ShortDescription>clone method stores a new value to member field of source object</ShortDescription>
 		<LongDescription>clone method {1} stores a new value to member field of source object</LongDescription>

Modified: trunk/fb-contrib/samples/JAO_Sample.java
===================================================================
--- trunk/fb-contrib/samples/JAO_Sample.java	2008-10-30 15:55:38 UTC (rev 1075)
+++ trunk/fb-contrib/samples/JAO_Sample.java	2008-11-03 07:14:49 UTC (rev 1076)
@@ -24,4 +24,10 @@
 	{
 		Assert.assertEquals(i, 10);
 	}
+	
+	public void testAutoBoxNotNull(int i)
+	{
+		Assert.assertNotNull(i);
+		Assert.assertNotNull(i == 3);
+	}
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-10-30 15:55:38 UTC (rev 1075)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/JUnitAssertionOddities.java	2008-11-03 07:14:49 UTC (rev 1076)
@@ -130,6 +130,8 @@
 	
 	@Override
 	public void sawOpcode(int seen) {
+		String userValue = null;
+		
 		try {
 			stack.mergeJumps(this);
 			
@@ -171,11 +173,32 @@
 								}
 							}
 						}
+					} else if ("assertNotNull".equals(methodName)) {
+						if (stack.getStackDepth() > 0) {
+							if ("valueOf".equals(stack.getStackItem(0).getUserValue())) {
+								bugReporter.reportBug(new BugInstance(this, "JAO_JUNIT_ASSERTION_ODITIES_IMPOSSIBLE_NULL", NORMAL_PRIORITY)
+										   .addClass(this)
+										   .addMethod(this)
+										   .addSourceLine(this));
+							}
+						}
 					}
+				} else {
+					String methodName = getNameConstantOperand();
+					String sig = getSigConstantOperand();
+					if (clsName.startsWith("java/lang/")
+					&&  "valueOf".equals(methodName)
+					&&  (sig.indexOf(")Ljava/lang/") >= 0)) {
+						userValue = "valueOf";
+					}
 				}
 			}
 		} finally {
 			stack.sawOpcode(this, seen);
+			if ((userValue != null) && (stack.getStackDepth() > 0)) {
+				OpcodeStack.Item item = stack.getStackItem(0);
+				item.setUserValue(userValue);
+			}
 		}
 	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1075] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/DeletingWhileIterating.java

From: <dbr...@us...> - 2008-10-30 15:55:52

Revision: 1075
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1075&view=rev
Author:   dbrosius
Date:     2008-10-30 15:55:38 +0000 (Thu, 30 Oct 2008)

Log Message:
-----------
don't report on CopyOnWriteArrayList and CopyOnWriteArraySet

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java	2008-10-22 19:50:46 UTC (rev 1074)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/DeletingWhileIterating.java	2008-10-30 15:55:38 UTC (rev 1075)
@@ -56,6 +56,7 @@
 {	
 	private static JavaClass collectionClass;
 	private static JavaClass iteratorClass;
+	private static Set<JavaClass> exceptionClasses;
 	private static final Set<String> collectionMethods;
 	static {
 		try {
@@ -66,6 +67,13 @@
 			iteratorClass = null;
 		}
 		
+		try {
+			exceptionClasses = new HashSet<JavaClass>();
+			exceptionClasses.add(Repository.lookupClass("java.util.concurrent.CopyOnWriteArrayList"));
+			exceptionClasses.add(Repository.lookupClass("java.util.concurrent.CopyOnWriteArraySet"));
+		} catch (ClassNotFoundException cnfe) {
+		}
+		
 		collectionMethods = new HashSet<String>();
 		collectionMethods.add("entrySet()Ljava/lang/Set;");
 		collectionMethods.add("keySet()Ljava/lang/Set;");
@@ -309,7 +317,7 @@
 	private boolean isCollection(String className) {
 		try {
 			JavaClass cls = Repository.lookupClass(className);
-			return cls.implementationOf(collectionClass);
+			return cls.implementationOf(collectionClass) && !exceptionClasses.contains(cls);
 		} catch (ClassNotFoundException cnfe) {
 			bugReporter.reportMissingClass(cnfe);
 			return false;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1074] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/SillynessPotPourri.java

From: <dbr...@us...> - 2008-10-22 19:50:54

Revision: 1074
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1074&view=rev
Author:   dbrosius
Date:     2008-10-22 19:50:46 +0000 (Wed, 22 Oct 2008)

Log Message:
-----------
guard against bad stack

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-10-05 03:19:29 UTC (rev 1073)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-10-22 19:50:46 UTC (rev 1074)
@@ -526,8 +526,7 @@
 			
 		} finally {
 			stack.sawOpcode(this, seen);
-			if (userValue != null)
-			{
+			if ((userValue != null) && stack.getStackDepth() > 0) {
 				OpcodeStack.Item item = stack.getStackItem(0);
 				item.setUserValue(userValue);
 			}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1073] trunk/fb-contrib

From: <dbr...@us...> - 2008-10-05 04:24:39

Revision: 1073
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1073&view=rev
Author:   dbrosius
Date:     2008-10-05 03:19:29 +0000 (Sun, 05 Oct 2008)

Log Message:
-----------
add test SPP_USE_ISEMPTY

Modified Paths:
--------------
    trunk/fb-contrib/etc/findbugs.xml
    trunk/fb-contrib/etc/messages.xml
    trunk/fb-contrib/htdocs/index.html
    trunk/fb-contrib/samples/SPP_Sample.java
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java

Modified: trunk/fb-contrib/etc/findbugs.xml
===================================================================
--- trunk/fb-contrib/etc/findbugs.xml	2008-08-09 03:34:47 UTC (rev 1072)
+++ trunk/fb-contrib/etc/findbugs.xml	2008-10-05 03:19:29 UTC (rev 1073)
@@ -256,7 +256,7 @@
 			
 	<Detector class="com.mebigfatguy.fbcontrib.detect.SillynessPotPourri"
 			speed="fast"
-			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY" />
+			reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TRINARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY,SPP_USE_ISEMPTY" />
 		
 	<Detector class="com.mebigfatguy.fbcontrib.detect.BloatedAssignmentScope"
 			speed="fast"
@@ -412,6 +412,7 @@
 	<BugPattern abbrev="SPP" type="SPP_USE_STRINGBUILDER_LENGTH" category="PERFORMANCE" />
 	<BugPattern abbrev="SPP" type="SPP_INVALID_CALENDAR_COMPARE" category="CORRECTNESS"/>
 	<BugPattern abbrev="SPP" type="SPP_USE_CONTAINSKEY" category="STYLE"/>
+	<BugPattern abbrev="SPP" type="SPP_USE_ISEMPTY" category="STYLE"/>
 	<BugPattern abbrev="BAS" type="BAS_BLOATED_ASSIGNMENT_SCOPE" category="PERFORMANCE" />
 	<BugPattern abbrev="SCII" type="SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTATOR" category="STYLE" />
 	<BugPattern abbrev="DWI" type="DWI_DELETING_WHILE_ITERATING" category="CORRECTNESS" />

Modified: trunk/fb-contrib/etc/messages.xml
===================================================================
--- trunk/fb-contrib/etc/messages.xml	2008-08-09 03:34:47 UTC (rev 1072)
+++ trunk/fb-contrib/etc/messages.xml	2008-10-05 03:19:29 UTC (rev 1073)
@@ -2026,6 +2026,17 @@
 		</Details>
 	</BugPattern>
 	
+	<BugPattern type="SPP_USE_ISEMPTY">
+		<ShortDescription>Method checks the size of a collection against zero rather than using isEmpty()</ShortDescription>
+		<LongDescription>Method {1} checks the size of a collection against zero rather than using isEmpty()</LongDescription>
+		<Details>
+			<![CDATA[
+				<p>This method calls the size() method on a collection and compares the result to zero to see if the collection
+				is empty. For better code clarity, it is better to just use col.isEmpty() or !col.isEmpty()</p>
+			]]>
+		</Details>
+	</BugPattern>
+	
 	<BugPattern type="BAS_BLOATED_ASSIGNMENT_SCOPE">
 		<ShortDescription>Method assigns a variable in a larger scope then is needed</ShortDescription>
 		<LongDescription>Method {1} assigns a variable in a larger scope then is needed</LongDescription>

Modified: trunk/fb-contrib/htdocs/index.html
===================================================================
--- trunk/fb-contrib/htdocs/index.html	2008-08-09 03:34:47 UTC (rev 1072)
+++ trunk/fb-contrib/htdocs/index.html	2008-10-05 03:19:29 UTC (rev 1073)
@@ -48,9 +48,9 @@
 		<a href="bugdescriptions.html">Bug Descriptions</a>
 
 		<hr/>
-		<img id="svn_image" src="flip1.gif" onClick="toggleBlock('svn', 'svn_image');" align="top"/>
+		<img id="svn_image" src="flip2.gif" onClick="toggleBlock('svn', 'svn_image');" align="top"/>
 		Detectors added in svn<br/>
-		<div id="svn" style="display:none;">
+		<div id="svn" style="display:block;">
 			<ul>
 				<li><b>[LO] Logger Oddities</b><br/>
 				Looks for uses of log4j or slf4j where the class specified when creating the logger
@@ -62,9 +62,9 @@
 			</ul>
 		</div>
 		<hr/>
-		<img id="v3_6_0_image" src="flip2.gif" onClick="toggleBlock('v3_6_0', 'v3_6_0_image');" align="top"/>
+		<img id="v3_6_0_image" src="flip1.gif" onClick="toggleBlock('v3_6_0', 'v3_6_0_image');" align="top"/>
 		Detectors added in v3.6.0<br/>
-		<div id="v3_6_0" style="display:block;">
+		<div id="v3_6_0" style="display:none;">
 			<ul>
 				<li><b>[CFS] Confusing Function Semantics</b><br/>
 				Looks for methods that return a parameter after making what looks like

Modified: trunk/fb-contrib/samples/SPP_Sample.java
===================================================================
--- trunk/fb-contrib/samples/SPP_Sample.java	2008-08-09 03:34:47 UTC (rev 1072)
+++ trunk/fb-contrib/samples/SPP_Sample.java	2008-10-05 03:19:29 UTC (rev 1073)
@@ -196,4 +196,10 @@
     	if (m.keySet().contains("Foo"))
     		System.out.println("Yup");
     }
+    
+    public void testCollectionSizeEqualsZero(Set<String> s)
+    {
+    	if (s.size() == 0)
+    		System.out.println("empty");
+    }
 }

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-08-09 03:34:47 UTC (rev 1072)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/SillynessPotPourri.java	2008-10-05 03:19:29 UTC (rev 1073)
@@ -52,6 +52,16 @@
  */
 public class SillynessPotPourri extends BytecodeScanningDetector 
 {
+	private static final Set<String> collectionInterfaces = new HashSet<String>();
+	static {
+		collectionInterfaces.add("java/util/Collection");
+		collectionInterfaces.add("java/util/List");
+		collectionInterfaces.add("java/util/Set");
+		collectionInterfaces.add("java/util/SortedSet");
+		collectionInterfaces.add("java/util/Map");
+		collectionInterfaces.add("java/util/SortedMap");
+	}
+	
 	private final BugReporter bugReporter;
 	private OpcodeStack stack;
 	private int lastPCs[];
@@ -155,6 +165,18 @@
 				}
 			}
 			
+			if ((seen == IFEQ) || (seen == IFNE)) {
+				if (stack.getStackDepth() == 1) {
+					OpcodeStack.Item item = stack.getStackItem(0);
+					if ("size".equals(item.getUserValue())) {
+						bugReporter.reportBug(new BugInstance(this, "SPP_USE_ISEMPTY", NORMAL_PRIORITY)
+								   .addClass(this)
+								   .addMethod(this)
+								   .addSourceLine(this));
+					}
+				}
+			}
+			
 			if (seen == IFNE) {
 				byte[] bytes = getCode().getCode();
 				if (lastPCs[2] != -1) {
@@ -493,6 +515,13 @@
 						}
 					}
 				}
+				
+				if (collectionInterfaces.contains(className)) {
+					String method = getNameConstantOperand();
+					if ("size".equals(method)) {
+						userValue = "size";
+					}
+				}
 			}
 			
 		} finally {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1072] trunk/fb-contrib/htdocs/index.html

From: <dbr...@us...> - 2008-08-09 03:34:38

Revision: 1072
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1072&view=rev
Author:   dbrosius
Date:     2008-08-09 03:34:47 +0000 (Sat, 09 Aug 2008)

Log Message:
-----------
document LO

Modified Paths:
--------------
    trunk/fb-contrib/htdocs/index.html

Modified: trunk/fb-contrib/htdocs/index.html
===================================================================
--- trunk/fb-contrib/htdocs/index.html	2008-08-08 18:13:27 UTC (rev 1071)
+++ trunk/fb-contrib/htdocs/index.html	2008-08-09 03:34:47 UTC (rev 1072)
@@ -52,6 +52,9 @@
 		Detectors added in svn<br/>
 		<div id="svn" style="display:none;">
 			<ul>
+				<li><b>[LO] Logger Oddities</b><br/>
+				Looks for uses of log4j or slf4j where the class specified when creating the logger
+				is not the same as the class in which this logger is used.</li>
 				<li><b>[SCSS] Suspicious Clustered Session Support</b><br/>
 				Looks for methods that access objects in http sessions, that are complex objects,
 				modifies those objects, but does not call setAttribute to signify a change so that


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1071] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/LoggerOddities.java

From: <dbr...@us...> - 2008-08-08 18:13:23

Revision: 1071
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1071&view=rev
Author:   dbrosius
Date:     2008-08-08 18:13:27 +0000 (Fri, 08 Aug 2008)

Log Message:
-----------
constant strings, replace . with /

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 18:08:43 UTC (rev 1070)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 18:13:27 UTC (rev 1071)
@@ -100,8 +100,7 @@
                     ConstantPool pool = getConstantPool();
                     ldcClassName = ((ConstantUtf8)pool.getConstant(((ConstantClass) c).getNameIndex())).getBytes();
                 }
-            }
-            else if (seen == INVOKESTATIC) {
+            } else if (seen == INVOKESTATIC) {
                 String clsName = getClassConstantOperand();
                 String mthName = getNameConstantOperand();
                 
@@ -120,6 +119,8 @@
                     	if (stack.getStackDepth() > 0) {
 	                        OpcodeStack.Item item = stack.getStackItem(0);
 	                        loggingClassName = (String)item.getConstant();
+	                        if (loggingClassName != null)
+	                        	loggingClassName = loggingClassName.replace('.', '/');
 	                    }
                     }                	
                 } else if ("org/apache/log4j/Logger".equals(clsName)
@@ -135,11 +136,15 @@
                     	if (stack.getStackDepth() > 0) {
 	                        OpcodeStack.Item item = stack.getStackItem(0);
 	                        loggingClassName = (String)item.getConstant();
+	                        if (loggingClassName != null)
+	                        	loggingClassName = loggingClassName.replace('.', '/');
 	                    }
                     } else if ("(Ljava/lang/String;Lorg/apache/log4j/spi/LoggerFactory;)Lorg/apache/log4j/Logger;".equals(signature)) {
                     	if (stack.getStackDepth() > 1) {
 	                        OpcodeStack.Item item = stack.getStackItem(1);
 	                        loggingClassName = (String)item.getConstant();
+	                        if (loggingClassName != null)
+	                        	loggingClassName = loggingClassName.replace('.', '/');
 	                    }
                     }
                 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1070] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/LoggerOddities.java

From: <dbr...@us...> - 2008-08-08 18:08:37

Revision: 1070
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1070&view=rev
Author:   dbrosius
Date:     2008-08-08 18:08:43 +0000 (Fri, 08 Aug 2008)

Log Message:
-----------
add LDC_W

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 17:58:09 UTC (rev 1069)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 18:08:43 UTC (rev 1070)
@@ -94,7 +94,7 @@
     public void sawOpcode(int seen) {
         String ldcClassName = null;
         try {
-            if (seen == LDC) {
+            if ((seen == LDC) || (seen == LDC_W)) {
                 Constant c = getConstantRefOperand();
                 if (c instanceof ConstantClass) {
                     ConstantPool pool = getConstantPool();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1069] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/LoggerOddities.java

From: <dbr...@us...> - 2008-08-08 17:58:02

Revision: 1069
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1069&view=rev
Author:   dbrosius
Date:     2008-08-08 17:58:09 +0000 (Fri, 08 Aug 2008)

Log Message:
-----------
remove unused

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 15:56:24 UTC (rev 1068)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 17:58:09 UTC (rev 1069)
@@ -146,7 +146,6 @@
 
                 if (loggingClassName != null) {
                     if (stack.getStackDepth() > 0) {
-                        OpcodeStack.Item item = stack.getStackItem(0);
                         if ((loggingClassName != null) && !loggingClassName.equals(clsName)) {
                             bugReporter.reportBug(new BugInstance(this, "LO_SUSPECT_LOG_CLASS", clsName.contains("$") ? LOW_PRIORITY : NORMAL_PRIORITY)
                                         .addClass(this)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1068] trunk/fb-contrib/src/com/mebigfatguy/ fbcontrib/detect/LoggerOddities.java

From: <dbr...@us...> - 2008-08-08 15:56:18

Revision: 1068
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1068&view=rev
Author:   dbrosius
Date:     2008-08-08 15:56:24 +0000 (Fri, 08 Aug 2008)

Log Message:
-----------
add checks for slf4j

Modified Paths:
--------------
    trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java

Modified: trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java
===================================================================
--- trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 15:50:35 UTC (rev 1067)
+++ trunk/fb-contrib/src/com/mebigfatguy/fbcontrib/detect/LoggerOddities.java	2008-08-08 15:56:24 UTC (rev 1068)
@@ -104,11 +104,28 @@
             else if (seen == INVOKESTATIC) {
                 String clsName = getClassConstantOperand();
                 String mthName = getNameConstantOperand();
-                if ("org/apache/log4j/Logger".equals(clsName)
+                
+                String loggingClassName = null;
+
+                if ("org/slf4j/LoggerFactory".equals(clsName)
                 &&  "getLogger".equals(mthName)) {
                     String signature = getSigConstantOperand();
-                    String loggingClassName = null;
                     
+                    if ("(Ljava/lang/Class;)Lorg/slf4j/Logger;".equals(signature)) {
+                    	if (stack.getStackDepth() > 0) {
+	                        OpcodeStack.Item item = stack.getStackItem(0);
+	                        loggingClassName = (String)item.getUserValue();
+	                    }
+                    } else if ("(Ljava/lang/String;)Lorg/slf4j/Logger;".equals(signature)) {
+                    	if (stack.getStackDepth() > 0) {
+	                        OpcodeStack.Item item = stack.getStackItem(0);
+	                        loggingClassName = (String)item.getConstant();
+	                    }
+                    }                	
+                } else if ("org/apache/log4j/Logger".equals(clsName)
+                       &&  "getLogger".equals(mthName)) {
+                    String signature = getSigConstantOperand();
+                    
                     if ("(Ljava/lang/Class;)Lorg/apache/log4j/Logger;".equals(signature)) {
                     	if (stack.getStackDepth() > 0) {
 	                        OpcodeStack.Item item = stack.getStackItem(0);
@@ -125,19 +142,19 @@
 	                        loggingClassName = (String)item.getConstant();
 	                    }
                     }
-                    
-                    if (loggingClassName != null) {
-	                    if (stack.getStackDepth() > 0) {
-	                        OpcodeStack.Item item = stack.getStackItem(0);
-	                        if ((loggingClassName != null) && !loggingClassName.equals(clsName)) {
-	                            bugReporter.reportBug(new BugInstance(this, "LO_SUSPECT_LOG_CLASS", clsName.contains("$") ? LOW_PRIORITY : NORMAL_PRIORITY)
-	                                        .addClass(this)
-	                                        .addMethod(this)
-	                                        .addSourceLine(this));
-	                        }
-	                    }
-	                }
                 }
+
+                if (loggingClassName != null) {
+                    if (stack.getStackDepth() > 0) {
+                        OpcodeStack.Item item = stack.getStackItem(0);
+                        if ((loggingClassName != null) && !loggingClassName.equals(clsName)) {
+                            bugReporter.reportBug(new BugInstance(this, "LO_SUSPECT_LOG_CLASS", clsName.contains("$") ? LOW_PRIORITY : NORMAL_PRIORITY)
+                                        .addClass(this)
+                                        .addMethod(this)
+                                        .addSourceLine(this));
+                        }
+                    }
+                }
             }
         } finally {
             stack.sawOpcode(this, seen);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Fb-contrib-commit] SF.net SVN: fb-contrib:[1067] trunk/fb-contrib/samples/lib/log4j.jar

From: <dbr...@us...> - 2008-08-08 15:50:27

Revision: 1067
          http://fb-contrib.svn.sourceforge.net/fb-contrib/?rev=1067&view=rev
Author:   dbrosius
Date:     2008-08-08 15:50:35 +0000 (Fri, 08 Aug 2008)

Log Message:
-----------
lib for test

Added Paths:
-----------
    trunk/fb-contrib/samples/lib/log4j.jar


Property changes on: trunk/fb-contrib/samples/lib/log4j.jar
___________________________________________________________________
Added: svn:mime-type
   + application/octet-stream


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

Flat | Threaded

<< < 1 .. 29 30 31 32 33 .. 77 > >> (Page 31 of 77)