#70 SPP_SERIALVER_SHOULD_BE_PRIVATE not referenced.

[Robin McKenzie-Boone]

Hi,
This is a great add-on to FindBugs!
I was wondering about one thing however. Why is SPP_SERIALVER_SHOULD_BE_PRIVATE not in findbugs.xml in the "Detector" for SillynesPotPourri?

This is what I see in 6.2.3:

<detector class="" speed="fast" reports="SPP_NEGATIVE_BITSET_ITEM,SPP_INTERN_ON_CONSTANT,SPP_NO_CHAR_SB_CTOR,SPP_USE_MATH_CONSTANT,SPP_STUTTERED_ASSIGNMENT,SPP_USE_ISNAN,SPP_USE_BIGDECIMAL_STRING_CTOR,SPP_STRINGBUFFER_WITH_EMPTY_STRING,SPP_EQUALS_ON_ENUM,SPP_INVALID_BOOLEAN_NULL_CHECK,SPP_USE_CHARAT,SPP_USELESS_TERNARY,SPP_SUSPECT_STRING_TEST,SPP_USE_STRINGBUILDER_LENGTH,SPP_INVALID_CALENDAR_COMPARE,SPP_USE_CONTAINSKEY,SPP_USE_ISEMPTY,SPP_USE_GETPROPERTY,SPP_USELESS_CASING,SPP_NON_ARRAY_PARM,SPP_EMPTY_CASING,SPP_TEMPORARY_TRIM,SPP_STRINGBUILDER_IS_MUTABLE,SPP_USE_GET0,SPP_DOUBLE_APPENDED_LITERALS,SPP_NULL_BEFORE_INSTANCEOF,SPP_NON_USEFUL_TOSTRING,SPP_TOSTRING_ON_STRING,SPP_EQUALS_ON_STRING_BUILDER,SPP_CONVERSION_OF_STRING_LITERAL,SPP_STATIC_FORMAT_STRING"></detector>

I also don't see it with any other Detector.

It is reporting. It found the bug in this:
public class Spp implements Serializable {

static final long serialVersionUID = 586036307614995610L;

}

But it does not show up in the FindBugs Eclipse plugin "Detector configuration" tab description text.

[Dave Brosius]

Why is SPP_SERIALVER_SHOULD_BE_PRIVATE not in findbugs.xml

Knuckleheaded stupidity, most likely.

Thanks for the report.. will fix.

BTW, The project is actively developed at github now, so issues will be seen over there quicker (most likely).

[Dave Brosius]

commit 38956fc283a8cd6974c2ad5c2588520564da2282
Author: Dave Brosius
Date: Tue Sep 29 19:55:01 2015 -0400

SF Issue [bugs:70] SPP_SERIALVER_SHOULD_BE_PRIVATE not referenced.