Re: [Fault-injection-developer] fi_core.c

[Rusty L. <ru...@li...>]

On Mon, 2003-02-10 at 15:50, Mark Haverkamp wrote:
> While playing with the fi code to try and figure out how it works I ran
> across this in fi_core.c.  I noticed that if I attached a trigger to a
> code segment, the opcode in the trigger didn't display anything when I
> cat'ed the file.  The attached code changes  print_cs_list to return the
> value from sprintf instead of unconditional zero. Also
> trigger_operand_read's seemed to have a typo in the sprintf.
> 
> 
> -- 
> Mark Haverkamp <ma...@os...>
> ----
> 

Thanks, applied.

    --rustyl

> ===== drivers/fi/fi_core.c 1.46 vs edited =====
> --- 1.46/drivers/fi/fi_core.c	Thu Jan 23 17:10:33 2003
> +++ edited/drivers/fi/fi_core.c	Mon Feb 10 15:00:40 2003
> @@ -504,7 +504,7 @@
>  		i += sprintf(page+i, "code segment name: %s\n", 
>  			     pos->kobj.name);
>  	}
> -	return 0;
> +	return i;
>  }
>  
>  static ssize_t trigger_opcode_read(struct trigger * p, char * page)
> @@ -530,7 +530,7 @@
>  	if (list_empty(&p->cs_list)) {
>  		return sprintf(page,"%i\n",p->operand);
>  	} else {
> -		return sprintf(page,"(no used)\n");
> +		return sprintf(page,"(not used)\n");
>  	}
>  }
>