RE: [Fault-injection-developer] [RFC] [PATCH] code segment patch

[Zhuang, L. <lou...@in...>]

You are very welcome to contribute efforts here. ;-)	
> Hello.
> 
> I read your patch which added the caller of Code Segment.
> I have a little comment.
> 
> In your patch, pf_page_fault() injects a fault value 
> at set_ins_reg_val() or set_ins_imm_val() 
> after calling the Code Segment by fi_execute_trigger().
> However, fi_execute_trigger() injects another fault value itself. 
if there is a code segment attached with trigger, fi_execute_trigger will
return immediately after call into the code segment.

> 
> I think that fault inject code should be out of 
> fi_execute_trigger() and
> fi_execute_trigger() should call just the Code Segment.
You are right! But much time simply operations such as SET, AND etc. are
enough. It is why there are some shortcuts in fi_execute_trigger. Could you
show me a better way?

  - Louis