Re: [Fault-injection-developer] [RFC] [PATCH] code segment patch

[<y-...@jp...>]

Hello.

I read your patch which added the caller of Code Segment.
I have a little comment.

In your patch, pf_page_fault() injects a fault value 
at set_ins_reg_val() or set_ins_imm_val() 
after calling the Code Segment by fi_execute_trigger().
However, fi_execute_trigger() injects another fault value itself. 

I think that fault inject code should be out of fi_execute_trigger() and
fi_execute_trigger() should call just the Code Segment.

Thanks.

----------------
Yasunori Goto