RE: [Fault-injection-developer] RE: [PATCH]Rewrite of fi_core.c u sing sysfs

[Wang, S. <sta...@in...>]

Please see my comment :)

> -----Original Message-----
> From: Lynch, Rusty [mailto:rus...@in...]
> Sent: 2002=E5=B9=B412=E6=9C=8817=E6=97=A5 1:22
> To: Zhuang, Louis; 'Rusty Lynch';=20
> fau...@so...
> Subject: RE: [Fault-injection-developer] RE: [PATCH]Rewrite=20
> of fi_core.c u sing sysfs
>=20
>=20
> > Louis said:
> > I've some concerns, so fight me. :)
> > * Sysfs is wonderful but backporting to kernel 2.4. Should we=20
> > never plan to
> > use FITH in 2.4?
>=20
> I think that by the time fith is ready for a stable kernel,
> the kernel will be 2.6 which will contain sysfs.  If for=20
> some reason somebody has an interest in backporting fi to
> 2.4, then they will have to backport sysfs.
>=20
> Everyday more and more components are moving in this
> direction so I am confident somebody will backport sysfs.
>=20
> > * fi_core should include not only sysfs code, but also some=20
> > general logic
> > code. These logic functions are common among several=20
> > interceptors. So I'd
> > like to move 'execute_trigger' code move trigger back to=20
> > fith_core.c and add
> > 'corrupt' callback in 'struct trigger'=20
>=20
> I agree that the core is the proper location for putting
> common (i.e. 'core') functionality that is exported for=20
> other code to use.
>=20
> This doesn't explain why you want execute_trigger inside
> the core.  I would argue that each interceptor does not
> want to execute a trigger in exactly the same way. =20
As you see, execute_trigger handles an intercepted event,
and look up the wp table to decide how to injection fault. It
will be need by all the other interceptor, IO/PCI config etc.=20
Why not we move it into fi_core.c and share it among all
interceptors.

-Stan

>=20
> Could you further explain your position?
>=20
> 	-rusty
>=20
>=20
> -------------------------------------------------------
> This sf.net email is sponsored by:
> With Great Power, Comes Great Responsibility=20
> Learn to use your power at OSDN's High Performance Computing Channel
> http://hpc.devchannel.org/
> _______________________________________________
> Fault-injection-developer mailing list
> Fau...@li...
> =
https://lists.sourceforge.net/lists/listinfo/fault-injection-developer
>=20