RE: [Fault-injection-developer] RE: [PATCH]Rewrite of fi_core.c u sing sysfs

[Lynch, R. <rus...@in...>]

> Louis said:
> I've some concerns, so fight me. :)
> * Sysfs is wonderful but backporting to kernel 2.4. Should we 
> never plan to
> use FITH in 2.4?

I think that by the time fith is ready for a stable kernel,
the kernel will be 2.6 which will contain sysfs.  If for 
some reason somebody has an interest in backporting fi to
2.4, then they will have to backport sysfs.

Everyday more and more components are moving in this
direction so I am confident somebody will backport sysfs.

> * fi_core should include not only sysfs code, but also some 
> general logic
> code. These logic functions are common among several 
> interceptors. So I'd
> like to move 'execute_trigger' code move trigger back to 
> fith_core.c and add
> 'corrupt' callback in 'struct trigger' 

I agree that the core is the proper location for putting
common (i.e. 'core') functionality that is exported for 
other code to use.

This doesn't explain why you want execute_trigger inside
the core.  I would argue that each interceptor does not
want to execute a trigger in exactly the same way.  

Could you further explain your position?

	-rusty