RE: [Fault-injection-developer] Couple of issues downloading and building the FITH source code

[Wang, F. <fra...@in...>]

Good comments from Rob!

-----Original Message-----
From: Rob Rhoads [mailto:err...@li...]
Sent: 2002?10?22? 10:59
To: Zhuang, Louis
Cc: fau...@li...; Perez-Gonzalez, Inaky;
Wang, Frank
Subject: RE: [Fault-injection-developer] Couple of issues downloading and
building the FITH source code


Louis, not that I want to hammer you some more (better me though, than
someone on the LKML -- I learned the hard way *ouch!*) but ...

When you respond to someone's e-mail with in-line comments, you need to
clearly mark your response or the original text w/ something. So the
reader can distinguish what you are saying and what the original poster
said.

Needless to say, I had a very difficult time distinguishing my comments
from yours in your response below.

-RobR

On Mon, 2002-10-21 at 19:37, Zhuang, Louis wrote:
> OK, got the source, and I'm now going through the build steps and
> reading the documentation. In short, its way too TLT specific for a
> general announcement on the LKML.
> 
> I haven't attempted to build it yet, but this is what I see so far that
> needs to be fixed before the project is announced (in any form) to the
> LKML:
> 
> 1. Remove all mention & dependencies on TLT, carrierlinux, etc. from
> everything. The README file is full of TLT & carrierlinux 'isms. If this
> is going to be posted on LKML, the instructions and code had better work
> on a stock kernel by applying relevant kernel patches.
> 
> If you rely on the TLT or CGLE kernel no one on the LKML, outside of
> OSDL developers, will take a second look at it.
> 
> The instructions need to be written so anyone can take a stock kernel
> apply the relevant patches and make it work. For example, dprobes is
> required, but the instruction don't clearly state that you need to apply
> the patch to the stock kernel sources.
> We'll fix these issues. thx
> 
> 
> 2. You need to break-out the required kernel patches from the user-space
> components. Separate source tarballs & separate instructions, might be
> one way to do it. Right now it's confusing from reading the README what
> exactly you need to do in order to get going. At the very least you need
> to build a new kernel with the right patches applied, and then make the
> user-space components.
> Good point! Fixing... :)
> 
> 
> 3. A lot of the info that's in the README should be in the INSTALL file.
> The INSTALL file has good info, but is pretty much generic to running
> ./configure.
> INSTALL file is generated by 'automake' automatically. We'd like put all
> information in README. If you think it is an issue, we'll change some
> installation-relative information into INSTALL.
> 
> 
> 4. To get the best exposure on the LKML, it would be better to also
> provide instructions on how to make it work on the 2.5 kernel. I would
> think that would be just a matter of getting the patches working on the
> 2.5 kernel. This could be any area where we ask for community help in
> making it work on 2.5. This shouldn't stop us from announcing, but after
> listening to Greg K-H yesterday and my past experience this is the
> conclusion I come to.
> We all have little experience in 2.5, but we'll try to merge our things
into
> 2.5. Maybe we need some help from other kernel guys :) 
> 
> 
> More comments to follow...stay tuned...
> 
> -RobR
> 
> 

-- 
Rob Rhoads                     mailto:err...@li...
Telecom Software Platforms     office: 503-677-5498
Intel Communications Group

<disclaimer value="pointless">
This email message solely contains my own personal views, 
and not necessarily those of my employer.
</disclaimer>