Menu

#2 detz/dety columns are wrong

None
wont-fix
nobody
None
5
2017-04-12
2007-10-29
Anonymous
No

The detz/dety columns output from peaksearch.py are incorrect. They should sometimes be in the form:

(dim1 - fc + 1)

and sometimes just

(fc)

Problem is in labelimage.py

The unresolved question is how to decide on which of the 8 possible flips to apply.

0: User specifies it (allows an override)
1: Image header - edf keyword
2: Image format - might define an orientation
3: Guess based on ;
- dimensions to match ID11 camera
- some hint in header

Suggest moving the problem to fabio? So that ImageD11 and fabian will then be consistent at least. eg propose adding a:

fabio.fabioimage.fs2yz member function

args are (fast, slow) -> returns (dety, detz)

Discussion

  • Jonathan Wright

    Jonathan Wright - 2017-04-12
    • status: open --> wont-fix
    • Group: -->
     
  • Jonathan Wright

    Jonathan Wright - 2017-04-12

    They are still wrong. But after ten years, I move it to wontfix.