#235 Some files missing in 2.8.8 release ZIP (source)

[MuldeR]

Hello.

I see you published FAAD v2.8.8. Thanks for that!

Don't want to be nitpicky, but some files for Win32 still seem to be missing from the ZIP:

2>------ Build started: Project: faad, Configuration: Release Win32 ------
1>aacinfo.c
2>main.c
1>c1 : fatal error C1083: Cannot open source file: '../../common/faad/aacinfo.c': No such file or directory
1>filestream.c
1>c1 : fatal error C1083: Cannot open source file: '../../common/faad/filestream.c': No such file or directory
1>Generating Code...
1>Done building project "aacinfo.vcxproj" -- FAILED.
2>..\..\frontend\main.c(51): fatal error C1083: Cannot open include file: 'getopt.h': No such file or directory
2>Done building project "faad.vcxproj" -- FAILED.
========== Build: 0 succeeded, 2 failed, 2 up-to-date, 0 skipped ==========

Missing files (at least) are:
common/faad/aacinfo.c
common/faad/filestream.c
* getopt.h

BTW: Is the release ZIP not created via git archive --output=foo.zip master ???

Best Regards,
MuldeR

[Krzysztof Nikiel]

common/faad/aacinfo.c
common/faad/filestream.c

Are these files really used anywhere, probably can be removed from the project.

getopt.h, this one is really missing, will fix it soon.

BTW: Is the release ZIP not created via git archive --output=foo.zip master ???

It has to be created with autotools (make dist)

[MuldeR]

Yes, these files are used in the "aacinfo" project.

[Krzysztof Nikiel]

To me it looks like some outdated and not very useful tool, i'd love to remove it.

[MuldeR]

Personally, I don't use it, so I would be okay with that decision. But I'm not sure about others.

In any case, if the sources are removed, that MSVC project (aacinfo) should be removed too.