Menu

#200 does not compile without limbp4v2

None
closed-fixed
nobody
None
5
2015-06-09
2015-05-11
No

Hi there,

currently, frontend/main.c fails to compile if the source has been ./configure'd with "--without-mp4v2" (as e.g. in Debian):

main.c: In function ‘main’:
main.c:1075:17: error: ‘total_samples’ undeclared (first use in this function)
if (total_samples < infile->samples)
^

Indeed, there was a mistake in this commit:
http://faac.cvs.sourceforge.net/viewvc/faac/faac/frontend/main.c?r1=1.83&r2=1.84

The total_samples variable is only defined "#ifdef HAVE_LIBMP4V2", but is used here regardless of this macro being defined or not.

Discussion

  • Krzysztof Nikiel

    Hi,

    It looks like total_samples is utilized to read the correct number of samples.
    I think the attached patch would fix it.

     
  • Fabian Greffrath

    Looks good, thank you!

     
  • Fabian Greffrath

    Forgot about this?

     
    • Krzysztof Nikiel

      Apparently I totally forgot it, thank you.

       
  • Krzysztof Nikiel

    • status: open --> closed-fixed
    • Group: -->
     

Log in to post a comment.