#186 faad2 crashes on large ID3v2 tags

[Mike Crowe]

faad2 skips ID3v2 tags on ADTS AAC files. Unfortunately it does so using advance_buffer which causes fill_buffer to misbehave if the ID3v2 tag was larger than the buffer size.

The attached patch fixes advance_buffer to loop around only advancing by the size of the buffer which works around the problem.

[Mike Crowe]

Here's a better patch with the asserts removed so it actually compiles.

[Mike Crowe]

Improved patch

[Fabian Greffrath]

Hello,

is there any reason why this patch hasn't been accepted yet?

• Fabian

[Krzysztof Nikiel]

Just committed it, can be closed.