#174 No support for libmp4v2 r479 (latest upstream release)

closed-accepted
nobody
None
5
2012-03-01
2012-01-20
No

From this list:

http://code.google.com/p/mp4v2/downloads/list

The r479 is recommended download. The attached patch adds support for it.

This is from:

http://bugs.gentoo.org/397575

And the patch is written by "Jaakko Perttilä", not me

Discussion

  • Samuli Suominen

    Samuli Suominen - 2012-01-20

    Patch to support latest libmp4v2 "snapshot" release

     
  • Fabian Greffrath

    However, that patch still does not allow to build against libmp4v2-r479, because the check for the "MP4MetadataDelete" still fails. It has been removed from this release of libmp4v2.

     
  • Samuli Suominen

    Samuli Suominen - 2012-02-06

    fabian_deb, indeed, you seem to be correct... the patch is incomplete

     
  • Fabian Greffrath

    I have extended Jaakko's patch with some code contributed by Sebastien NOEL to port the FAAC frontend to the new iTMF Generic and Tags API. Details about the origin of the code can be found in the patch header.

    I have tested this patch and it builds without mp4v2, with internal libmp4v2, with external libmp4v2 1.9.1 and with external libmp4v2 1.9.1-r479. I have not yet tested if the resulting faac actually works, though. ;)

    Since I cannot add the patch to this tracker, please find it here:
    http://anonscm.debian.org/gitweb/?p=pkg-multimedia/faac.git;a=blob;f=debian/patches/external-libmp4v2_r479.patch;hb=HEAD

     
  • Fabian Greffrath

    I should add that this patch is supposed to get applied on top of faac-1.28-external-libmp4v2.patch as found in Gentoo or current faac upstream CVS, which already has that one applied.

     
  • Krzysztof Nikiel

    Seems to compile OK, just commited it.

     
  • Samuli Suominen

    Samuli Suominen - 2012-02-23

    It worked for me too. I've pushed it to Gentoo's repository as faac-1.28-r3. Thanks guys!

    Can this ticket now be closed?

     
  • Krzysztof Nikiel

    I think project admin can do such things.

     
  • Krzysztof Nikiel

    • status: open --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks