#24 changing roles with etcAuthSource

[Deepak Giridharagopal]

I don't know if this is the same bug as with Patch
#626934, but that particular patch entry didn't have
and comments or attached files.

The offending code (from etcAuthSource.py):

232: if roles and self.default_role:

233: roles=roles.append(self.default_role)

234: elif self.default_role:

235: roles=[self.default_role,]

236: else:

237: roles=[]

Line 233 is the problem. 'roles.append' will always
return None, it should just be used in-place.
Currently, if you have any roles manually defined for a
user, then line 233 will just set 'roles' to 'None'.
Zope expects a sequence, not 'None'.

I've attached a small patch.

[Deepak Giridharagopal]