Menu

#29 Prevent gumps from being coerced offscreen.

None
closed-rejected
nobody
None
5
2019-07-29
2005-01-09
No

Added limit checks on the mouse movement to prevent
the user from being able to move a gump off screen.

Discussion

  • Pioneer Dragon

    Pioneer Dragon - 2005-01-09

    drag.cc

     
  • Willem Jan Palenstijn

    Logged In: YES
    user_id=23042

    Under what conditions can you drag a gump offscreen?

     
  • Pioneer Dragon

    Pioneer Dragon - 2005-01-15

    Logged In: YES
    user_id=1181234

    Try it.
    Take a gump and drag it so part of it is offscreen. Then grab
    what is left of the gump and continue to drag it so more is
    offscreen. Continue this process, and eventually you can
    make the gump disappear. I did it with the backpack gump
    on the left edge of the window. Now I do admit its not easy
    to make the gump dissapear. However, it is possible to make
    it dissapear.

     
  • Willem Jan Palenstijn

    Logged In: YES
    user_id=23042

    Hm, and your patch makes sure there's always one extra pixel
    onscreen on the left and top edges? Why isn't that also
    necessary on the right and border edges? (Or is that an
    off-by-one?)

     
  • Jeff Freedman

    Jeff Freedman - 2005-03-19

    Logged In: YES
    user_id=10931

    I'm afraid I don't like having the mouse position played with
    while dragging. A better solution might be to adjust the gump
    position after it's dropped. I'll try to check what happens in the
    original.

    Another idea would be to let the user drag it off the screen.
    But when restoring that gump when it's reopened, make sure
    it's visible again at that point.

     
  • Pioneer Dragon

    Pioneer Dragon - 2005-03-19

    Logged In: YES
    user_id=1181234

    I think that is a good idea. I'll look into that idea too... I think
    this patch was to be tied in with the other patch 1099146 that
    saves the gump positions. Actually if the other patch is not
    applied then this one really isn't needed. Maybe I should
    combine the 2 patches.

     
  • Dominik Reichardt

    • status: open --> closed-rejected
    • Group: -->
     
  • Dominik Reichardt

    Closing this now as the save partygump has been implemented and this never got traction.