Menu

#2020 Cantra shape #299 can't open doors

Regression
closed-duplicate
None
5
2024-04-09
2017-05-04
No

https://github.com/exult/exult/commit/e07d31f27d95d70499b93a4050471a7cb2e2fd30 caused Cantra to be unable to open doors.
Test case: move her into a house and set time to 5:55 pm and wait (at 6pm he should chnage her schedule and leave the house by door.

The problem is that the value is determined for actual NPCs with higher intelligence not by their ingame intelligence but the monster information intelligence of the shape. In case of Cantra (#299) and shape #652 and probably others, the monster information intelligence is set below 6. So they are not sentient.

Discussion

  • Dominik Reichardt

    • summary: Cantra (all NPCs with intelligence <10) can't open doors --> Cantra shape #299 can't open doors
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,2 +1,4 @@
     https://github.com/exult/exult/commit/e07d31f27d95d70499b93a4050471a7cb2e2fd30 caused Cantra to be unable to open doors.
     Test case: move her into a house and set time to 5:55 pm and wait (at 6pm he should chnage her schedule and leave the house by door.
    +
    +Seems to affect all NPCs with her shape (#299).
    
     
  • Dominik Reichardt

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
     https://github.com/exult/exult/commit/e07d31f27d95d70499b93a4050471a7cb2e2fd30 caused Cantra to be unable to open doors.
     Test case: move her into a house and set time to 5:55 pm and wait (at 6pm he should chnage her schedule and leave the house by door.
    
    -Seems to affect all NPCs with her shape (#299).
    +The problem is that the value is determined for actual NPCs with higher intelligence not by their ingame intelligence but the monster information intelligence of the shape. In case of Cantra (#299) and shape #652 and probably others, the monster information intelligence is set below 6. So they are not sentient.
    
     
  • Marzo Sette Torres Junior

    Can you compare with the original?

     
  • Dominik Reichardt

    now that you mention it, Cantra is not able to open doors in the original (at 21:00 she eventually goes to sleep on the floor if the room she's in has no bed)
    Now I'm not sure anymore if we should change that.
    A proposal would be a partly reversion and change of the previous code to

    if (get_info().get_shape_class() == Shape_info::human &&
                get_effective_prop(Actor::intelligence) >= 6)
            return true;
    

    So it would need to be a human NPCV but with a real intelligence of at least 6. Ths would prevent Ale the parrot from slipping out.
    Or leave it like the original...

     
  • Dominik Reichardt

    Probably better to keep it like the original, to prevent fringe problems occuring.
    Lydia (NPC #72, shape #652) is another case. Interesting to watch her at 9pm in the original. She is supposed to eat at the Inn but as she can't leave the room she sits down at her desk and yells for the barkeeper :)

     
  • Knight Captain

    Knight Captain - 2017-05-05

    This would seem to be a oversight on the part of the Origin developers. Dominik's suggested solution to check the NPC's Intelligence makes sense to me, since temporary spawned humans would still use the shape's Intelligence, but Cantra, Lydia, and Skinless Yelinda would work as expected.

    In the case of my mod, I want to allow transformed clan members to be able to open/close doors as part of the storyline (they remember how to use doors). Thus I would not be able to do this only for clan members but globally across all bears, leopards, and wolves. That's not ideal. So if this is not a bug, per se, please consider it as a feature request.

     
  • Marzo Sette Torres Junior

    You can just edit the monster data to give these shapes a higher average intelligence. The down side of the proposed intelligence check is that it allows some random chickens to open doors (and which was what caused the original bug report to be filed).

     
  • Dominik Reichardt

    It probably IS an oversight but we might be on the safer side not to fix the original bug. It just might be one of those cases that prevents an odd bug further down the line.
    A pure in game intelligence check really shoudn't be done - coupled with human shape, perhaps.

     
  • Knight Captain

    Knight Captain - 2017-05-06

    Okay. So if I'm following:
    A) To allow Cantra, Lydia and Frigidazzi, Frigidazzi's Messenger (Goblin Woman), and the Skinless Woman to open doors, for each shape raise the Monster tab's Intelligence to 6 or above.
    B) Would A be allowed in SI Fixes?
    C) To allow some totem clan animals (Caladin as a Bear, etc) to open doors, I would need to also raise the bear's Monster tab's Intelligence to 6 or above. There is no way currently in the engine to do this per-NPC so all bears would be able to do this. So I should adjust my mod's story a bit, I think. Edit: Or use different shapes for those NPCs, as suggested.

     

    Last edit: Knight Captain 2017-05-06
  • Dominik Reichardt

    A:yes
    B: why is there a need for this?
    C: My recommendation is to duplicate the clan animals, increase the intel of the dupes and then use those for your transformed Npcs

     
  • Knight Captain

    Knight Captain - 2017-05-06

    B) To allow Lydia and the Goblin Messenger to open doors. I believe Cantra too has schedules that would need it. We can probably skip it if I'm the only one who noticed it.

    Should the documentation be updated before we close this bug out?

     
  • Dominik Reichardt

    • status: open --> closed-duplicate
     
  • Dominik Reichardt

    tracked in our new issue tracker https://github.com/exult/exult/issues/490 as an SI Fixes request