Menu

#1891 SI: Zulith's body *should* contain important scroll

Regression
closed
None
9
2017-02-24
2014-11-10
No

After Mad Iolo killed everyone, Zulith's body should hold a scroll explaining that Yelinda knows where the Serpent Armor is.
Instead he (and several other bodies there) hold a lot of desk items that shouldn't be there.

This doesn't break the plot since Yelinda tells of the Armor anyway.

Attaching both Exult and original savegame

2 Attachments

Discussion

  • Dominik Reichardt

    This is a regression, in the release 1.2 this is still working.

    Edit: Actually it works with current SVN if you start a new game, teleport to the wall of light, let the scene play out, teleport to fane and look at Zulith's body.
    Will have to go through my savageness to see whether I can pinpoint when it went wrong.

     

    Last edit: Dominik Reichardt 2014-11-11
  • Dominik Reichardt

    The problem is the desk schedule.
    For some reason it seems that in SI desk times end up on the NPCs and when the Wall of Light scene usecode wants to place the scroll in Zulith's inventory there is no slot left and it went poof.
    Tested by teleporting to Zulith before confronting Batlin, emptied Zulith's slot (pickpocket cheat) and then teleported back to confront Batlin.
    The Scroll is then correctly placed in Zulith's inventory.

    I'm gonna attach the savage, right before going up to Batlin. (exult124si.sav)

     
  • Dominik Reichardt

    I'm temporarily assigning this to Jeff.
    The underlying problem is that the Desk schedule doesn't seem to clean up after itself.
    Quick test with Gargan in Trinsic:
    he has no items but with the desk schedule he holds the desk items during the schedule as he picks them up and puts them down between the two tables.
    After the schedule finishes he is left with desk items in his inventory :(

     
  • Dominik Reichardt

    • assigned_to: Jeff Freedman
    • Group: Unimplemented --> Regression
     
  • Dominik Reichardt

    made it to only create one item and not more. This fixes this problem somewhat but probably needs to be redone differently.

     
  • Jeff Freedman

    Jeff Freedman - 2014-12-13

    I think I've fixed this by having the schedule clean up any items still on the NPC when it's finished. Do you have a savegame before Zulith dies so I can test this?

     
  • Dominik Reichardt

    I'll see about testing this with my savegame before the Batlin/wall of light scene after which all scedules get changed.
    A quick test is Shmed of Trinsic in BG or one of the ghosts in the explosives mint in SI.
    Thanks for looking into this!

     
  • Dominik Reichardt

    I'm currently testing, the problem is only that in my savegames he already is burdened by the many desk items he produced already. So the only option is to test from the beginning again.
    I did that and it seems to clean up properly, even when then teleporting to the beginning of the wall of light scene.
    So thanks again for fixing this.

    One quirk I noticed is with Zuliths desk schedule (teleport to his house at 982,1734 between 6am and 6pm) is that his desk is on the first store but he constantly wanders down to the other table on the ground floor.

     
  • Knight Captain

    Knight Captain - 2017-02-24

    The scroll is placed on Zulith before he dies via prepKillEveryone object#(0x7D8):
    UI_add_cont_items(ZULITH, 1, SHAPE_SCROLL, 7, 0, 0);

     
  • Dominik Reichardt

    • status: open --> closed
     
  • Dominik Reichardt

    it has been fixed by Jeff back then. the usecode couldn't place the scroll as the desk items took all available slots.