EDIT: It's working. There is one quirk (that I think is acceptable).
When "Smart Highlighting" item color is changed in Notepad++ Configurator, it overrides the setting in your plugin, but not the other way around. However, when the setting is set in your plugin, it is persistent between tab changes, and even between sessions (close / reopen Notepad++). So I think it's good as is.
But the issue still remains, when the user changes the "Smart Highlighting" color setting in Notepad++ Style Configurator, it affects your plugin, and the setting in your plugin is overridden.
I'm not sure what should be expected at this point. This setting in your app is clearly linked to "Smart Highlighting" in Style Configurator. I noticed you removed the border/vertical line settings in v1.3 which are now controlled by Notepad++ settings. So maybe it is time to consider removing this setting also? Since it is also controlled by Notepad++?
Thanks for this plugin :-) ... I've used it for quite some time. I have no preference either way on this issue.
EDIT : Using Noteapd++ v8.4.7 64-bit
Last edit: TheArkive 2023-01-19
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
So maybe it is time to consider removing this setting also?
Yes, I think this would be the best. Thinking about this setting now, I'm not sure why I included it at all. ;-)
I keep this issue open as a reminder since I have only limited spare time to work on the plugin, thus your proposed change will be applied at a later point in time.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Should have been fixed with v1.3 release. Please test and come back to report your results.
Ok will do.
EDIT: It's working. There is one quirk (that I think is acceptable).
When "Smart Highlighting" item color is changed in Notepad++ Configurator, it overrides the setting in your plugin, but not the other way around. However, when the setting is set in your plugin, it is persistent between tab changes, and even between sessions (close / reopen Notepad++). So I think it's good as is.
But the issue still remains, when the user changes the "Smart Highlighting" color setting in Notepad++ Style Configurator, it affects your plugin, and the setting in your plugin is overridden.
I'm not sure what should be expected at this point. This setting in your app is clearly linked to "Smart Highlighting" in Style Configurator. I noticed you removed the border/vertical line settings in v1.3 which are now controlled by Notepad++ settings. So maybe it is time to consider removing this setting also? Since it is also controlled by Notepad++?
Thanks for this plugin :-) ... I've used it for quite some time. I have no preference either way on this issue.
EDIT : Using Noteapd++ v8.4.7 64-bit
Last edit: TheArkive 2023-01-19
Thank you for testing.
Yes, I think this would be the best. Thinking about this setting now, I'm not sure why I included it at all. ;-)
I keep this issue open as a reminder since I have only limited spare time to work on the plugin, thus your proposed change will be applied at a later point in time.
Setting has been removed in release v1.3.1