#5 bad POSIX shell test usage

[Mike Frysinger]

the configure.ac file does things like:

[if test x$enableval == xyes && test "$GCC" = "yes";

the == opterator is not in POSIX. it has to be = to avoid errors with many shells. usually only bash recognizes ==.

[Robi]

Thanks for the note.

At first sight, I can not recognize "==" in the config.ac.
But, I will examine this accurate the next days.
And I'll also try this with other shells.
Using a different shell than bash? Such an idea I had never before during my previous testings. Lets see what happens :-)

Robi

[Mike Frysinger]

the snippet i posted was straight out of the configure.ac file in the current git:
https://sourceforge.net/p/ext4magic/code/ci/master/tree/configure.ac
it came in from the last commit in the repo:
https://sourceforge.net/p/ext4magic/code/ci/99a57963c71afa255f50635dd4f7d4ff0b0324aa/

you can see what POSIX says about the test program:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
it does not support ==. the other common shell you probably have access to is dash. you can see it doesn't work there:

$ dash -c 'test 1 == 2'
dash: 1: test: 1: unexpected operator

[Robi]

Okay, it's not in the latest release 0.3.2, but in GIT.
I'll check what I later accepted here for a patch. Looks like adopted and accepted from a maintainer.

thank you

Robi