Re: [ext2resize] [PATCH] disable fallback to offline resizing in ext2online

[Andreas D. <ad...@cl...>]

On Jun 10, 2006  08:55 +0200, Petter Reinholdtsen wrote:
> I've checked all the patches in the debian package, and only two
> remains now.  The previous one for big endian support, and this one to
> disable offline resizing fallback in ext2online.
> 
> Should this be commited?  It disable a large chunk of code.  If it is
> commited, it might be better to remove the unused code completely?

I agree with this change, and all of the corresponding code should just
be removed outright.  It was useful for resizing ext2 filesystems, but
that patch is dead, and if it is ever revived it can use the same ioctl
mechanism as ext3 without difficulty.

> #! /bin/sh /usr/share/dpatch/dpatch-run
> ## 70_nofallback
> ##
> ## DP: Based on patch found in the suse and redhat version, where the
> ## DP: ext2online fallback to offline resizing is disabled.
> 
> --- ext2resize-1.1.19.orig/src/ext2online.c
> +++ ext2resize-1.1.19/src/ext2online.c
> @@ -507,7 +507,13 @@
>  	 */
>  	if (ext2_ioctl(fs, EXT2_IOC_GROUP_EXTEND, &size))
>  		fs->flags |= FL_IOCTL;
> -	else if (errno != ENOTTY)
> +	else /* if (errno != ENOTTY) */
> +	  /*
> +	   * Disable fallback to offline resizing.  This change was
> +	   * found in the Fedora/RedHat package, and was explained
> +	   * with "resize2fs is incompatible with online resize, and
> +	   * can result in corrupt filesystems."  Use resize2fs instead.
> +	   */
>  		return 0;

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.