[ext2resize] [PATCH] disable fallback to offline resizing in ext2online

[Petter R. <pe...@hu...>]

I've checked all the patches in the debian package, and only two
remains now.  The previous one for big endian support, and this one to
disable offline resizing fallback in ext2online.

Should this be commited?  It disable a large chunk of code.  If it is
commited, it might be better to remove the unused code completely?

#! /bin/sh /usr/share/dpatch/dpatch-run
## 70_nofallback
##
## DP: Based on patch found in the suse and redhat version, where the
## DP: ext2online fallback to offline resizing is disabled.

--- ext2resize-1.1.19.orig/src/ext2online.c
+++ ext2resize-1.1.19/src/ext2online.c
@@ -507,7 +507,13 @@
 	 */
 	if (ext2_ioctl(fs, EXT2_IOC_GROUP_EXTEND, &size))
 		fs->flags |= FL_IOCTL;
-	else if (errno != ENOTTY)
+	else /* if (errno != ENOTTY) */
+	  /*
+	   * Disable fallback to offline resizing.  This change was
+	   * found in the Fedora/RedHat package, and was explained
+	   * with "resize2fs is incompatible with online resize, and
+	   * can result in corrupt filesystems."  Use resize2fs instead.
+	   */
 		return 0;
 
 	ra = fs->newblocks - size;