Re: [ext2resize] [PATCH] Endless loop in ext2_move_blocks()?

[Petter R. <pe...@hu...>]

[Andreas Dilger]
> Actually, loop should be from num-1 to 0 (i.e. copy 'num' blocks in
> reverse order), and your change would make this from num to 1.  The
> change is correct, just your description is slightly wrong...

Right.  Sorry about the confusion introduced.

> This seems fine.

Great.  I hope a new version can be released soon, to fix the problems
with the current package.  The broken ext2prepare is the most
important problem for me as the Debian maintainer, but I would love to
have more of the Debian and RedHat patches included in the official
version.

> That really depends on how many such errors there are, and how easy
> or hard it is to fix them.  I don't disagree in principle, but it
> would be bad to miss important warnings in a flood of unimportant
> ones.

In my experience, it is not very hard to write correct programs which
compiles without warnings, and all the new warnings showing up
normally indicate some problem.

Friendly,
-- 
Petter Reinholdtsen