[ext2resize] Re: [patch] ext2fs_allocate_group_table cleanup

[Andreas D. <ad...@us...>]

On Mar 17, 2006  10:45 +0800, Coywolf Qi Hunt wrote:
> Cleanup the fake 'if' statement because of (a % b) <= (b - 1).
> Conceptually, this fix classifies that with stride, BM < IT impossible.
> It is for ext2resize bug fix.
> 
> Signed-off-by: Coywolf Qi Hunt <qi...@fc...>
> ---
> 
> diff -r 8991ece34224 lib/ext2fs/alloc_tables.c
> --- a/lib/ext2fs/alloc_tables.c	Fri Mar 10 21:39:40 2006 -0500
> +++ b/lib/ext2fs/alloc_tables.c	Fri Mar 17 10:30:33 2006 +0800
> @@ -51,8 +51,6 @@ errcode_t ext2fs_allocate_group_table(ex
>  		start_blk = group_blk + fs->inode_blocks_per_group;
>  		start_blk += ((fs->stride * group) %
>  			      (last_blk - start_blk));
> -		if (start_blk > last_blk)
> -			start_blk = group_blk;
>  	} else
>  		start_blk = group_blk;

Hi,
could you please explain a bit more about this?  My thought would be that
you are correct in saying that this is a "fake 'if' statement", because
we know the start_blk will always be less than last_blk in any case.

I'm a bit confused about how it relates to a bug in ext2resize however.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.