[ext2resize] Re: [Ext2-devel] current status of online resizing

[Andreas D. <ad...@cl...>]

On Aug 24, 2005  13:40 -0300, Glauber de Oliveira Costa wrote:
> besides that, there is also the locking issue, that is not gone away. In
> a fast look into the code, I realized that ext3_group_extend is only
> called by either fs/super.c or fs/ext3/ioctl.c. Since the problem arises
> from a mount call (as do_remount_sb already holds the lock), and
> changing that would be a little vfs-intrusive, I think that the best
> solution is to remove the lock code from ext3_group_extend, and get
> it before its call in ioctl. This way, the whole ext3_group_extend
> would be called with the super block lock held.

This is pretty reasonable.  I've had to do similar things in the past
as the VFS locking changes.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.