Re: [ext2resize] ext2resize latest 2.4 kernel

[Andreas D. <ad...@cl...>]

On Sep 27, 2004  09:55 +1000, Andrew Jackson wrote:
> Has anyone had any luck applying the online-ext2 patch to 2.4.27 ?
>=20
> Looks like it broke somewhere around 2.4.21.
>=20
> Hunk #7 succeeded at 1726 (offset 26 lines).
> 1 out of 7 hunks FAILED -- saving rejects to file fs/ext3/super.c.rej
> patching file include/linux/ext3_fs.h
> Hunk #2 succeeded at 460 (offset 1 line).
>=20
> this is the reject file....
>=20
> ***************
> *** 1660,1666 ****
>=20
>         es =3D sbi->s_es;
>=20
> -       if ((*flags & MS_RDONLY) !=3D (sb->s_flags & MS_RDONLY)) {
>                 if (sbi->s_mount_opt & EXT3_MOUNT_ABORT)
>                         return -EROFS;
>=20
> --- 1684,1691 ----
>=20
>         es =3D sbi->s_es;
>=20
> +       if ((*flags & MS_RDONLY) !=3D (sb->s_flags & MS_RDONLY) ||
> +           n_blocks_count > le32_to_cpu(es->s_blocks_count)) {
>                 if (sbi->s_mount_opt & EXT3_MOUNT_ABORT)
>                         return -EROFS;
>=20
>=20
> Strange that in the first chunk it removes the if statement with the
> starting curly bracket, but the matching curly bracket is not removed.

Well, the second chunk is replacing that curly brace...  Looks like the
only change is that there is now a "ext3_init_journal_params(...)" call
and it adds a line with just a <tab> that breaks the patch context.  Fix
is to just use editor to delete first (-) line from ext3_remount() and
replace it with second (+) lines.

PS - you don't need the online patch to do offline filesystem resizing,
     and since your kernel doesn't already have this patch and you need
     to reboot to get it, you may as well do an offline resize the first
     time...

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/             http://members.shaw.ca/golinux/