ext2resize-devel

[ext2resize] ext2prepare corrupts ext3 file systems

[Petter R. <pe...@hu...>]

When using ext2prepare to make sure a ext3 file system is online
resizable, e2fsck find errors in the file system after the conversion.
Anyone know what is going on here?

This problem is reported in debian, <URL:http://bugs.debian.org/348778>.

The following commands demonstrate the problem (assuming LVM volume
gorup intern_vg and more than 150 MiB free space on the volume group):

  lvcreate -L150 -ntest_lv intern_vg
  mke2fs -j /dev/intern_vg/test_lv
  ext2prepare /dev/intern_vg/test_lv 500m
  e2fsck -y -f /dev/intern_vg/test_lv

This is the output from e2fsck:

# e2fsck -y -f /dev/vg_system/lv_test
e2fsck 1.37 (21-Mar-2005)
Resize inode not valid.  Recreate? yes

Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
Block bitmap differences:  -3 +4389 -8195 -24579 -40963 -57347 -73731
Fix? yes

Free blocks count wrong for group #0 (3803, counted=3804).
Fix? yes

Free blocks count wrong for group #1 (7931, counted=7932).
Fix? yes

Free blocks count wrong for group #3 (7931, counted=7932).
Fix? yes

Free blocks count wrong for group #5 (7931, counted=7932).
Fix? yes

Free blocks count wrong for group #7 (7931, counted=7932).
Fix? yes

Free blocks count wrong for group #9 (7931, counted=7932).
Fix? yes

Free blocks count wrong (146599, counted=146605).
Fix? yes


/dev/vg_system/lv_test: ***** FILE SYSTEM WAS MODIFIED *****
/dev/vg_system/lv_test: 11/38912 files (0.0% non-contiguous), 9043/155648 blocks
#

Friendly,
-- 
Petter Reinholdtsen

Re: [ext2resize] ext2prepare corrupts ext3 file systems

[Andreas D. <ad...@cl...>]

On May 21, 2006  08:58 +0200, Petter Reinholdtsen wrote:
> When using ext2prepare to make sure a ext3 file system is online
> resizable, e2fsck find errors in the file system after the conversion.
> Anyone know what is going on here?

That's because ext2prepare was never updated to support the "new" ext3
resize inode format.  There was actually a patch posted on ext2-devel
which may fix this from Takashi Sato, but I haven't had time to look
at it yet:

[Ext2-devel] [RFC][17/21]ext2resize fix resize_inode format

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

Re: [ext2resize] ext2prepare corrupts ext3 file systems

[Petter R. <pe...@hu...>]

[Andreas Dilger]
> That's because ext2prepare was never updated to support the "new"
> ext3 resize inode format.  There was actually a patch posted on
> ext2-devel which may fix this from Takashi Sato, but I haven't had
> time to look at it yet:

Aha.  Thank you for the tip.  I fetched the patch (had to apply it
manually as I failed to find a mailing list archive with the original
email (aka the non-HTML version), and gave it a go.  It fixed the
problem.  e2fsck no longer reports errors when I run it after
ext2prepare.

I hope you find time to look at it soon.  I consider including it in
the Debian package for now, but would love to have others opinion on
it first.

Friendly,
-- 
Petter Reinholdtsen

Re: [ext2resize] ext2prepare corrupts ext3 file systems

[Coywolf Qi H. <qi...@fc...>]

On Tue, May 23, 2006 at 09:21:28AM +0200, Petter Reinholdtsen wrote:
> [Andreas Dilger]
> > That's because ext2prepare was never updated to support the "new"
> > ext3 resize inode format.  There was actually a patch posted on
> > ext2-devel which may fix this from Takashi Sato, but I haven't had
> > time to look at it yet:
> 
> Aha.  Thank you for the tip.  I fetched the patch (had to apply it
> manually as I failed to find a mailing list archive with the original
> email (aka the non-HTML version), and gave it a go.  It fixed the
> problem.  e2fsck no longer reports errors when I run it after
> ext2prepare.
> 
> I hope you find time to look at it soon.  I consider including it in
> the Debian package for now, but would love to have others opinion on
> it first.

Those patches were done by *me*. There's a reason why I don't merge them.
You may feel free to take them in your debian package.
-- 
Coywolf Qi Hunt

Re: [ext2resize] ext2prepare corrupts ext3 file systems

[Petter R. <pe...@hu...>]

[Coywolf Qi Hunt]
> Those patches were done by *me*. There's a reason why I don't merge
> them.  You may feel free to take them in your debian package.

I did, and hope the extra testing the patch will receive make you more
confident that it is working.  I do not know the inner working of ext2
and ext3, so I did not check the logic in the patch, but it did get
rid of the warning from e2fsck.

Friendly,
-- 
Petter Reinholdtsen