ext2resize-devel

[ext2resize] Re: Patch 2.2-20003022

[Andreas D. <ad...@ho...>]

Detlef, you write:
> I have tested your patch. With sparse superblock flag turned on the block 
> counter of the last group is correct. Otherwise the the counter is wrong.
> I have attached the debug output for both cases. 

I have figured out the problem, and I'm just compiling a new kernel to
test it, but it is late and I will send you the patch to fix the problem.
The issue is that an ext2 kernel function doesn't behave as I expected
it to, based on how the same function behaves in e2fsprogs.

There are two ways to fix this, either change my code, or change the function
in the kernel.  While it is less likely that making more changes to the kernel
will be accepted at this stage in 2.3, I think my change is the correct way
(it also cleans up the existing code a bit) and I will submit a patch to
Linus as such.  If he doesn't like it, then I can always go back and change
the ext2resize code to be a bit uglier.

For now, what you can do, is in ext2_update_group() change m_blocks to be:

	m_blocks = sb->u.ext2_sb.s_itb_per_group + 2 +
       	         (!(sb->u.ext2_sb.s_feature_ro_compat &
       	            EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER) ||
       	          ext2_group_sparse(block_group) ?
       	          1 + sb->u.ext2_sb.s_db_per_group + resgdt : 0) + blocks;

This should fix the problems with non-sparse-super filesystems not being
resized properly, while also allowing sparse-super filesystems to work.

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

Re[2]: [ext2resize] Re[2]: Problem with ext2online

[<ber...@pa...>]

Cheers for that. I put the line into the fs/Config.in file and finally the line
appeared into the "make xconfig". I selected the option and make the kernel. I
bounced the box and did a quick resize and it WORKS perfectly.

As a matter of testing, I used the load testing script described in one of your
web page and didn;t have any problem. I will carry on using it and if I have any
problem, I will report it to you.

Well done guys, it is a major improvment to Linux.

Cheers.
Bertrand Sirodot.
ber...@pa...





Internet

From:     ad...@ho... on 27/03/2000 05:13


To:  ext2resize-devel

cc:  Bertrand SIRODOT

bcc:

Subject: Re: [ext2resize] Re[2]: Problem with ext2online




Lennert writes:
> I've looked at the kernel patch and I can't see a config option. Andreas,
> where did it go?

My mistake, sorry about that.  It appears to have fallen out of the
recent patches, as I was also working with InterMezzo and OBDFS (real
job) in the same kernel tree as ext2online, and I accidentally deleted
the config option along with the other (non-ext2online related) changes
to Config.in.  What you need is:

if [ "$CONFIG_EXT2_FS" != "n" -a "$CONFIG_EXPERIMENTAL" = "y" ]; then
  bool '  Online ext2 resize support (DANGEROUS)' CONFIG_EXT2_RESIZE
fi

in fs/Config.in, after the CONFIG_EXT2_FS option (same for 2.2 and 2.3).

I've added this to the kernel patches in the CVS tree and they will make
it into the next release, and I've split my kernel development into
separate trees to avoid this problem in the future.

Cheers, Andreas
--
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

_______________________________________________
ext2resize-devel mailing list
ext...@li...
http://lists.sourceforge.net/mailman/listinfo/ext2resize-devel





----------------------------------------------------------------------------------------------
This message is confidential; its contents do not constitute a
commitment by BNP Paribas Group* except where provided 
for in a written agreement between you and BNP Paribas Group*. 
Any unauthorised disclosure, use or dissemination, either 
whole or partial, is prohibited. If you are not the intended 
recipient of the message, please notify the sender immediately.
*BNP Paribas Group  is a trading name of BNP SA and Paribas SA

Ce message est confidentiel; son contenu ne represente en 
aucun cas un engagement de la part du groupe BNP Paribas* 
sous reserve de tout accord conclu par ecrit entre vous et le 
groupe BNP Paribas*. Toute publication, utilisation ou diffusion, 
meme partielle, doit etre autorisee prealablement. Si vous n'etes 
pas destinataire de ce message, merci d'en avertir immediatement
l'expediteur.
*Le groupe BNP Paribas est le nom commercial utilise par BNP SA et Paribas SA

Re: [ext2resize] Re[2]: Problem with ext2online

[Andreas D. <ad...@ho...>]

Lennert writes:
> I've looked at the kernel patch and I can't see a config option. Andreas,
> where did it go?

My mistake, sorry about that.  It appears to have fallen out of the
recent patches, as I was also working with InterMezzo and OBDFS (real
job) in the same kernel tree as ext2online, and I accidentally deleted
the config option along with the other (non-ext2online related) changes
to Config.in.  What you need is:

if [ "$CONFIG_EXT2_FS" != "n" -a "$CONFIG_EXPERIMENTAL" = "y" ]; then
  bool '  Online ext2 resize support (DANGEROUS)' CONFIG_EXT2_RESIZE
fi

in fs/Config.in, after the CONFIG_EXT2_FS option (same for 2.2 and 2.3).

I've added this to the kernel patches in the CVS tree and they will make
it into the next release, and I've split my kernel development into
separate trees to avoid this problem in the future.

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

Re: [ext2resize] status kernel patch?

[Andreas D. <ad...@ho...>]

Adam Foran writes:
> I saw on the fs-devel list recently that Andreas is still trying 
> to get the ext2 online resizing patch into 2.3. Does this effort 
> fall into the "wild fantasy" department or has someone with lots of
> clout with Linus said that it might still have a chance of
> getting in? I'm just curious cause I've got a little program that
> online resizing support would fit in with really well and supporting
> non-standard kernel patches is not really what I want to get into.

I have submitted the kernel patch to Ted Ts'o, but he has been very
busy lately, and I don't think he has passed it on to Linus.  If Ted
says to Linus that it should go in (which he has NOT yet done, AFAIK),
then it would likely still make it in.

There is an outstanding issue with ext2online, and I want to make sure
this is resolved (it may still be an old bug that I fixed locally but
did not make it into the latest release yet).  When I'm sure that there
are no known bugs (hopefully later tonight), then I'm going to submit
the patches to Linus directly myself.

This probably puts online resizing into the "wild fantasy" category,
unless a) Linus thinks this is real cool and it doesn't affect normal
kernel operation, or b) I can convince him that I didn't submit them
earlier because LVM wasn't in the stock kernel and LVM without online
resize is like a Fin without a cell phone.

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

Re: [ext2resize] Re[2]: Problem with ext2online

[Lennert B. <bu...@gn...>]

On Sun, 26 Mar 2000 ber...@pa... wrote:

> Hi,

Hello,


> I have done everything by the book and I still can't see the option
> under "Filesystems". I have tried to add it directly into the .config
> file, but it doesn't make a difference.

I've looked at the kernel patch and I can't see a config option. Andreas,
where did it go?


> A part from that, the offline version (ext2resize) seems to be working
> perfectly both ways (growing and shrinking). ext2fsck works fine and
> the filesystem has been grown or shrinked.

Thanks, I'll take a note of that.


greetings,
Lennert

[ext2resize] Re[2]: Problem with ext2online

[<ber...@pa...>]

Hi,

I have done everything by the book and I still can't see the option under
"Filesystems".
I have tried to add it directly into the .config file, but it doesn't make a
difference.

A part from that, the offline version (ext2resize) seems to be working perfectly
both ways (growing and shrinking). ext2fsck works fine and the filesystem has
been grown or shrinked.

Cheers.
Bertrand Sirodot.
ber...@pa...





Internet

From:     ad...@ho... on 23/03/2000 20:52


To:  Bertrand SIRODOT

cc:

bcc:

Subject: Re: Problem with ext2online




You write:
> I suppose that the problem is that the kernel didn't pick-up the EXT2-RESIZE
> feature. When I recompiled the kernel I haven't seen the option
> CONFIG_EXT2_RESIZE.
> Do you have any idea how to fix that problem??????

You need to go into "Code maturity level options" and select
"Prompt for development and/or incomplete code/driver".  Then under
"Filesystems" select "Online ext2 resize support (DANGEROUS)".

You should note that I'm not aware of anyone who has used ext2online
with a big-endian machine, nor a 64-bit machine.  It is possible that
the user-space and/or kernel code have some bugs in them related to
one or the other of these issues.  I would suggest trying ext2resize
on an unmounted test partition followed by e2fsck -f, as well as
watching the syslog and doing e2fsck after ext2prepare and ext2online.

If you have problems or success, please let me know.  We now have a
project at ext2resize.sourceforge.net, so any bugs should be submitted
there.

Cheers, Andreas
--
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert





----------------------------------------------------------------------------------------------
This message is confidential; its contents do not constitute a
commitment by BNP Paribas Group* except where provided 
for in a written agreement between you and BNP Paribas Group*. 
Any unauthorised disclosure, use or dissemination, either 
whole or partial, is prohibited. If you are not the intended 
recipient of the message, please notify the sender immediately.
*BNP Paribas Group  is a trading name of BNP SA and Paribas SA

Ce message est confidentiel; son contenu ne represente en 
aucun cas un engagement de la part du groupe BNP Paribas* 
sous reserve de tout accord conclu par ecrit entre vous et le 
groupe BNP Paribas*. Toute publication, utilisation ou diffusion, 
meme partielle, doit etre autorisee prealablement. Si vous n'etes 
pas destinataire de ce message, merci d'en avertir immediatement
l'expediteur.
*Le groupe BNP Paribas est le nom commercial utilise par BNP SA et Paribas SA

[ext2resize] status kernel patch?

[W. A. F. <wa...@pa...>]

Hi there,

I saw on the fs-devel list recently that Andreas is still trying 
to get the ext2 online resizing patch into 2.3. Does this effort 
fall into the "wild fantasy" department or has someone with lots of
clout with Linus said that it might still have a chance of
getting in? I'm just curious cause I've got a little program that
online resizing support would fit in with really well and supporting
non-standard kernel patches is not really what I want to get into.

Thanks,

Adam