#90 cmake // fix for static build (BUILD_shared=OFF) for Windows/MSVC

Feature Request
closed-fixed
None
3
2016-03-14
2015-01-15
No

Hello,

On Windows static builds will not linked, because XML_STATIC was not defined.

cmake .. -DBUILD_shared=OFF

Attached patch will fix that case

1 Attachments

Discussion

  • Sebastian Pipping

    Is this patch still needed? I'm missing something like a guard to limit to WIN32.

     
  • Sergey Nikulov

    Sergey Nikulov - 2016-03-12

    I think so, unless you've fixed described case in any other place.

     
  • Sergey Nikulov

    Sergey Nikulov - 2016-03-14

    Yes. Now it's good on patch-90.

    I've checked two builds on Windows 10/MSVS 2015

    cmake .. -G"Visual Studio 14 2015 Win64" -DBUILD_shared=OFF

    work as expected.

     
  • Sebastian Pipping

    • status: open --> closed-fixed
     
  • Sebastian Pipping

    Excellent, thanks for testing. Merged to master now. Closing.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks