[Exmmt-commit] SF.net SVN: exmmt: [54] net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/b
Status: Inactive
Brought to you by:
lgrammel
From: <lgr...@us...> - 2006-06-06 00:55:48
|
Revision: 54 Author: lgrammel Date: 2006-06-05 02:39:28 -0700 (Mon, 05 Jun 2006) ViewCVS: http://svn.sourceforge.net/exmmt/?rev=54&view=rev Log Message: ----------- #1500774 scenario "shopping list" Modified Paths: -------------- net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/Composite.java net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/TreeBuilder.java Modified: net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/Composite.java =================================================================== --- net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/Composite.java 2006-06-05 09:37:54 UTC (rev 53) +++ net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/Composite.java 2006-06-05 09:39:28 UTC (rev 54) @@ -33,6 +33,7 @@ return model; } + // TODO result should be immutable or a copy public List<Composite> getChildren() { return children; } @@ -45,7 +46,7 @@ this.parent = parent; } - public void add(Composite child) { + public void addChild(Composite child) { assert child != null; child.setParent(this); Modified: net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/TreeBuilder.java =================================================================== --- net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/TreeBuilder.java 2006-06-05 09:37:54 UTC (rev 53) +++ net.sourceforge.exmmt/trunk/src/java/net/sourceforge/exmmt/builder/TreeBuilder.java 2006-06-05 09:39:28 UTC (rev 54) @@ -24,16 +24,12 @@ List<Element> childElements = element.getChildren(); for (Element childElement : childElements) { - // TODO getChildren should return immutable - Composite child = build(childElement); - composite.add(child); + composite.addChild(build(childElement)); } List<Attribute> attributes = element.getAttributes(); for (Attribute attribute : attributes) { - // TODO getChildren should return immutable - Composite child = build(attribute); - composite.add(child); + composite.addChild(build(attribute)); } return composite; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |