[eXist-commits] [eXist-db/exist] 94899d: [fix] improve FunctionSignature.equals

[Duncan P. <no...@gi...>]

  Branch: refs/heads/develop
  Home:   https://github.com/eXist-db/exist
  Commit: 94899dec7685d432fad182a0981b429edb6b3d76
      https://github.com/eXist-db/exist/commit/94899dec7685d432fad182a0981b429edb6b3d76
  Author: Juri Leino <gi...@li...>
  Date:   2025-05-01 (Thu, 01 May 2025)

  Changed paths:
    M exist-core/src/main/java/org/exist/xquery/FunctionSignature.java
    M exist-core/src/test/xquery/maps/maps.xqm

  Log Message:
  -----------
  [fix] improve FunctionSignature.equals

fixes #5685

Erroneous comparison of signatures of anonymous functions lead to
wrong tail call optimizations that lead to an NPE further down the call stack.


  Commit: 4c4c8355ac7d63de72fdbff4ea1601b1a1621215
      https://github.com/eXist-db/exist/commit/4c4c8355ac7d63de72fdbff4ea1601b1a1621215
  Author: Juri Leino <gi...@li...>
  Date:   2025-05-01 (Thu, 01 May 2025)

  Changed paths:
    M exist-core/src/main/java/org/exist/xquery/UserDefinedFunction.java

  Log Message:
  -----------
  [fix] dump and toString methods of UserDefinedFunction

Output argument names and add "as" before function return type.


  Commit: b856db5757cee79ba18c0e1ca18e8ff46d680a04
      https://github.com/eXist-db/exist/commit/b856db5757cee79ba18c0e1ca18e8ff46d680a04
  Author: Juri Leino <gi...@li...>
  Date:   2025-05-01 (Thu, 01 May 2025)

  Changed paths:
    M exist-core/src/main/java/org/exist/xquery/UserDefinedFunction.java

  Log Message:
  -----------
  [ignore] cleanup of UserDefinedFunction

- make variables final
- reorder methods
- add code to XPathException constructor
- add annotations
- fix formatting


  Commit: b072566b086452c9f23cfa35d2e951af1138a140
      https://github.com/eXist-db/exist/commit/b072566b086452c9f23cfa35d2e951af1138a140
  Author: Juri Leino <gi...@li...>
  Date:   2025-05-01 (Thu, 01 May 2025)

  Changed paths:
    M exist-core/src/main/java/org/exist/xquery/FunctionSignature.java

  Log Message:
  -----------
  [refactor] small tweaks in FunctionSignature

- final value in addMetadata
- simplify and combine conditions in equals
- fix output of toString (" as " before returntype)
- rename char constant var to ANON_VAR


  Commit: f76323f5669ae52324a2b8127092096df62f267f
      https://github.com/eXist-db/exist/commit/f76323f5669ae52324a2b8127092096df62f267f
  Author: Juri Leino <gi...@li...>
  Date:   2025-05-01 (Thu, 01 May 2025)

  Changed paths:
    M exist-core/src/main/java/org/exist/xquery/FunctionSignature.java

  Log Message:
  -----------
  [refactor] reorder and format FunctionSignature


  Commit: d0a87c2519585062d3d960e3d4ab631ed399bf3e
      https://github.com/eXist-db/exist/commit/d0a87c2519585062d3d960e3d4ab631ed399bf3e
  Author: Duncan Paterson <dun...@us...>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M exist-core/src/main/java/org/exist/xquery/FunctionSignature.java
    M exist-core/src/main/java/org/exist/xquery/UserDefinedFunction.java
    M exist-core/src/test/xquery/maps/maps.xqm

  Log Message:
  -----------
  Merge pull request #5718 from line-o/port/fix/5685

Port/fix/5685


Compare: https://github.com/eXist-db/exist/compare/8f6b5b5ebf58...d0a87c251958

To unsubscribe from these emails, change your notification settings at https://github.com/eXist-db/exist/settings/notifications