[eXist-commits] [eXist-db/exist] ce795b: Leaky trigger state when XQuery method not found

[Dannes W. <no...@gi...>]

  Branch: refs/heads/develop-5.x.x
  Home:   https://github.com/eXist-db/exist
  Commit: ce795bfa95d457e35c866e2fbc9d75a4ff78abf7
      https://github.com/eXist-db/exist/commit/ce795bfa95d457e35c866e2fbc9d75a4ff78abf7
  Author: Alan Paxton <ala...@gm...>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  Leaky trigger state when XQuery method not found

XQuery trigger not found is acceptable behaviour (logs a debug message only, could get very chatty logs otherwise).
BUT the exit path from the exception fails to tidy up the per-thread trigger state. This has been observed to leak memory; the per-thread doesn’t get cleaned up until the thread is deleted, and the trigger cyclic-check stack just builds up.

So we clean up the trigger state when a trigger is not found.

Closes https://github.com/eXist-db/exist/issues/5459


  Commit: 9e2d613453016ab07546c8eb1e17441827d351d3
      https://github.com/eXist-db/exist/commit/9e2d613453016ab07546c8eb1e17441827d351d3
  Author: Alan Paxton <ala...@gm...>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  Avoid 2nd potential XQuery trigger leak

We may leak trigger states to thread local which can potentially occur when
the specified XQueryTrigger library module is not available in the database

Closes https://github.com/eXist-db/exist/issues/5459


  Commit: e7e3cbf7e2839453ff85810bd5e7b7b13cac8c91
      https://github.com/eXist-db/exist/commit/e7e3cbf7e2839453ff85810bd5e7b7b13cac8c91
  Author: Dannes Wessels <di...@us...>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  Merge pull request #5482 from evolvedbinary/5.x.x/hotfix/xquery-trigger-leak

 [5.x.x] Fix an issue where XQuery Trigger state may leak


Compare: https://github.com/eXist-db/exist/compare/a2f66e8b8d5e...e7e3cbf7e283

To unsubscribe from these emails, change your notification settings at https://github.com/eXist-db/exist/settings/notifications