[eXist-commits] [eXist-db/exist] 003128: [bugfix] Leaky trigger state when XQuery method no...

[Dannes W. <no...@gi...>]

  Branch: refs/heads/develop-6.x.x
  Home:   https://github.com/eXist-db/exist
  Commit: 003128b6b74d03c0b092a650d5f9c4463a4430ec
      https://github.com/eXist-db/exist/commit/003128b6b74d03c0b092a650d5f9c4463a4430ec
  Author: Alan Paxton <ala...@gm...>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  [bugfix] Leaky trigger state when XQuery method not found

XQuery trigger not found is acceptable behaviour (logs a debug message only, could get very chatty logs otherwise).
BUT the exit path from the exception fails to tidy up the per-thread trigger state. This has been observed to leak memory; the per-thread doesn’t get cleaned up until the thread is deleted, and the trigger cyclic-check stack just builds up.

So we clean up the trigger state when a trigger is not found.

Closes https://github.com/eXist-db/exist/issues/5459


  Commit: 4ac2f6f6838485c3636af13c1db8f7d82af32e50
      https://github.com/eXist-db/exist/commit/4ac2f6f6838485c3636af13c1db8f7d82af32e50
  Author: Alan Paxton <ala...@gm...>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  [bugfix] Avoid 2nd potential XQuery trigger leak

We may leak trigger states to thread local which can potentially occur when
the specified XQueryTrigger library module is not available in the database

Closes https://github.com/eXist-db/exist/issues/5459


  Commit: a6af4a42144ae8e96693b45c7559b57f740d3327
      https://github.com/eXist-db/exist/commit/a6af4a42144ae8e96693b45c7559b57f740d3327
  Author: Dannes Wessels <di...@us...>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  Merge pull request #5481 from evolvedbinary/6.x.x/hotfix/xquery-trigger-leak

[6.x.x] Fix an issue where XQuery Trigger state may leak


Compare: https://github.com/eXist-db/exist/compare/ab812d53029b...a6af4a42144a

To unsubscribe from these emails, change your notification settings at https://github.com/eXist-db/exist/settings/notifications