[eXist-commits] [eXist-db/exist] 0260bf: Leaky trigger state when XQuery method not found

[Patrick R. <no...@gi...>]

  Branch: refs/heads/develop
  Home:   https://github.com/eXist-db/exist
  Commit: 0260bfd43dd96b3455ea8c606c7e77d960ebce22
      https://github.com/eXist-db/exist/commit/0260bfd43dd96b3455ea8c606c7e77d960ebce22
  Author: Alan Paxton <ala...@gm...>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  Leaky trigger state when XQuery method not found

XQuery trigger not found is acceptable behaviour (logs a debug message only, could get very chatty logs otherwise).
BUT the exit path from the exception fails to tidy up the per-thread trigger state. This has been observed to leak memory; the per-thread doesn’t get cleaned up until the thread is deleted, and the trigger cyclic-check stack just builds up.

So we clean up the trigger state when a trigger is not found.

Closes https://github.com/eXist-db/exist/issues/5459


  Commit: 409a42c2b278b044e30a4a8f834e3e84bf20ddda
      https://github.com/eXist-db/exist/commit/409a42c2b278b044e30a4a8f834e3e84bf20ddda
  Author: Alan Paxton <ala...@gm...>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  Avoid 2nd potential XQuery trigger leak

We may leak trigger states to thread local which can potentially occur when
the specified XQueryTrigger library module is not available in the database

Closes https://github.com/eXist-db/exist/issues/5459


  Commit: 0e45a3da7fe77fc9cb3ee0f2eed9188acf211d82
      https://github.com/eXist-db/exist/commit/0e45a3da7fe77fc9cb3ee0f2eed9188acf211d82
  Author: Patrick Reinhart <pa...@re...>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M exist-core/src/main/java/org/exist/collections/triggers/XQueryTrigger.java

  Log Message:
  -----------
  Merge pull request #5484 from evolvedbinary/hotfix/xquery-trigger-leak

Fix an issue where XQuery Trigger state may leak


Compare: https://github.com/eXist-db/exist/compare/304f847c70ff...0e45a3da7fe7

To unsubscribe from these emails, change your notification settings at https://github.com/eXist-db/exist/settings/notifications