From: Joe W. <jo...@gm...> - 2013-01-11 16:38:43
|
FYI - After consulting with Dannes, I carried this proposal out in rev. 18050. After my change, Tomcat realm is still built by default, but now you can disable it from the build by editing your extensions/local.build.properties file to set include.feature.tomcat-realm to false. On Thu, Jan 10, 2013 at 3:25 PM, Joe Wicentowski <jo...@gm...> wrote: > Hi all, > > Does anyone object to me making the building of tomcat-realm > enforceable by local.build.properties? (See my original email about > this below.) > > My proposal is to change lib/extensions/tomcat-realm/extension.xml > lines 10-11 from: > > <!--property name="extension.include" value="${include.feature.webdav}"/--> > <property name="extension.include" value="yes"/> > > ... to: > > <property name="extension.include" value="${include.feature.tomcat}"/> > > And then I would add a corresponding property to > extensions/build.properties, defaulting to true: > > # Tomcat extension > include.feature.tomcat = true > > My only question is whether tomcat counts as a feature, a module, or > an extension -- with relation to the various categories included in > build.properties. > > Thanks, > Joe > > On Thu, Dec 6, 2012 at 4:30 PM, Joe Wicentowski <jo...@gm...> wrote: >> Hi all, >> >> I noticed that the Tomcat extension seems to be turned on by default. >> At least for me, when I build trunk, I get a >> lib/extensions/exist-tomcat-realm.jar when the build is complete. >> It's probably harmless, but shouldn't extensions be controlled by >> extensions/local.build.properties? >> >> Joe |