From: Joe W. <jo...@gm...> - 2012-02-25 20:51:34
|
Hi Andrzej, >> I would be happy to add documentation to the ant-tasks.xml file to >> include this new "permissions" attribute for the "store" and "create" >> tasks. Just let me know. > > Sure....I'm pretty tied up right now, so if you don't mind taking that on, that would be a big help. I just committed an update to the ant tasks documentation, containing information about the new permissions attribute on the store and create tasks. But I have a question about the 2nd part of your changes. You wrote: "The mode attribute on the chown ANT task is deprecated, but still works for backwards compatibility. Please convert your ANT scripts to use the new permissions attribute instead. If both are specfied, then the permissions attribute is the only one used." I looked and didn't see any changes to "chown" in your commit, only to "chmod". ("chown" doesn't even take a "mode" attribute.) Did you mean "chmod"? Also, you said to "use the new permissions attribute instead", but did you add a new permissions attribute to "chmod"? Or are you suggesting that people stop using "chmod" altogether, and instead modify their scripts to use "store" or "create" with the "permissions" attribute? Thanks in advance for clarifying this. Once I understand this, I'll update the documentation accordingly. >> I can't see any other tasks that need this "permissions" attribute, can you? > > No...between the Create/Store and the Chmod, I think we pretty much have all the bases covered. Cool. >> Also, I noticed one other area in the ant tasks documentation that I >> assume needs to be updated (no pun intended): >> >> The chmod task (http://exist-db.org/exist/ant-tasks.xml#d14366e1667) >> continues to refer to "update" permissions instead of "execute" >> permissions. > > That should probably be changed as well. Great, I changed this in my commit above. >> We should make sure that both the updated ant tasks and the updated >> documentation is committed to stable/exist-2.0.x. > > Agreed....I'm kinda into upgrading our eXist app (very complex....seems that whenever there are > major eXist changes, I'm the "canary in the coalmine" in finding subtle and complex bugs) to the > latest trunk. I've already found some bugs that are showstoppers, things like exceptions in complex > xpath expressions that worked fine before and are OK according to the xpath specs. > > So if you feel like backporting the new stuff to stable, be my guest, 'cause I'm unlikely to get to > it very soon. Sure, I'll be happy to merge your ant task enhancements into stable/exist-2.0.x along with my revisions to the ant task documentation. I plan do this when I have the documentation revisions done. Cheers, Joe |