[Exist-development] What is the purpose of Session in Security Manager?

[Adam R. <ad...@ex...>]

Dmitriy,

Please can you explain what the purpose of Sessions in the Security
Manager are? I see that you recently added these. It seems like the
wrong place for them, Sessions should live outside the Security
Manager if at all - I cant understand why we need them?

Also in the test suite, I frequently see NPE's thrown by this new code - e.g. -

java.lang.NullPointerException
	at org.exist.security.internal.SecurityManagerImpl.access$100(SecurityManagerImpl.java:84)
	at org.exist.security.internal.SecurityManagerImpl$SessionsCheck.execute(SecurityManagerImpl.java:821)
	at org.quartz.core.JobRunShell.run(JobRunShell.java:223)
	at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549)
- Job (eXist.Security.Sessions.Check threw an exception.
org.quartz.SchedulerException: Job threw an unhandled exception. [See
nested exception: java.lang.NullPointerException]
	at org.quartz.core.JobRunShell.run(JobRunShell.java:234)
	at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549)
Caused by: java.lang.NullPointerException
	at org.exist.security.internal.SecurityManagerImpl.access$100(SecurityManagerImpl.java:84)
	at org.exist.security.internal.SecurityManagerImpl$SessionsCheck.execute(SecurityManagerImpl.java:821)
	at org.quartz.core.JobRunShell.run(JobRunShell.java:223)
	... 1 more
- Job eXist.Security.Sessions.Check threw an unhandled Exception:
java.lang.NullPointerException
	at org.exist.security.internal.SecurityManagerImpl.access$100(SecurityManagerImpl.java:84)
	at org.exist.security.internal.SecurityManagerImpl$SessionsCheck.execute(SecurityManagerImpl.java:821)
	at org.quartz.core.JobRunShell.run(JobRunShell.java:223)
	at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549)
- Job (eXist.Security.Sessions.Check threw an exception.
org.quartz.SchedulerException: Job threw an unhandled exception. [See
nested exception: java.lang.NullPointerException]
	at org.quartz.core.JobRunShell.run(JobRunShell.java:234)
	at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549)
Caused by: java.lang.NullPointerException
	at org.exist.security.internal.SecurityManagerImpl.access$100(SecurityManagerImpl.java:84)
	at org.exist.security.internal.SecurityManagerImpl$SessionsCheck.execute(SecurityManagerImpl.java:821)
	at org.quartz.core.JobRunShell.run(JobRunShell.java:223)

-- 
Adam Retter

eXist Developer
{ United Kingdom }
ad...@ex...
irc://irc.freenode.net/existdb